From: Paul Durrant <paul.durrant@citrix.com>
To: xen-devel@lists.xen.org
Cc: Paul Durrant <paul.durrant@citrix.com>
Subject: [PATCH] Properly control platform device creation in upstream QEMU
Date: Thu, 13 Jun 2013 10:52:26 +0100 [thread overview]
Message-ID: <1371117146-5775-1-git-send-email-paul.durrant@citrix.com> (raw)
The xen_platform_pci xl configuration parameter currently has no effect on
upstream QEMU; creation of the platform device is hardcoded.
I have created a patch to QEMU to remove this hardcoded creation. This patch
specifies the appropriate -device argument on the QEMU command line (and
hence creates the device) only when xen_platform_pci is true.
Signed-off-by: Paul Durrant <paul.durrant@citrix.com>
---
tools/libxl/libxl_dm.c | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/tools/libxl/libxl_dm.c b/tools/libxl/libxl_dm.c
index ac1f90e..ce4ad99 100644
--- a/tools/libxl/libxl_dm.c
+++ b/tools/libxl/libxl_dm.c
@@ -383,6 +383,12 @@ static char ** libxl__build_device_model_args_new(libxl__gc *gc,
flexarray_append(dm_args, "-xen-attach");
}
+ if (b_info->type == LIBXL_DOMAIN_TYPE_HVM &&
+ libxl_defbool_val(b_info->u.hvm.xen_platform_pci)) {
+ flexarray_append(dm_args, "-device");
+ flexarray_append(dm_args, "xen-platform");
+ }
+
if (c_info->name) {
flexarray_vappend(dm_args, "-name", c_info->name, NULL);
}
--
1.7.10.4
reply other threads:[~2013-06-13 9:52 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1371117146-5775-1-git-send-email-paul.durrant@citrix.com \
--to=paul.durrant@citrix.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).