xen-devel.lists.xenproject.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] Properly control platform device creation in upstream QEMU
@ 2013-06-13  9:52 Paul Durrant
  0 siblings, 0 replies; only message in thread
From: Paul Durrant @ 2013-06-13  9:52 UTC (permalink / raw)
  To: xen-devel; +Cc: Paul Durrant

The xen_platform_pci xl configuration parameter currently has no effect on
upstream QEMU; creation of the platform device is hardcoded.
I have created a patch to QEMU to remove this hardcoded creation. This patch
specifies the appropriate -device argument on the QEMU command line (and
hence creates the device) only when xen_platform_pci is true.

Signed-off-by: Paul Durrant <paul.durrant@citrix.com>
---
 tools/libxl/libxl_dm.c |    6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/tools/libxl/libxl_dm.c b/tools/libxl/libxl_dm.c
index ac1f90e..ce4ad99 100644
--- a/tools/libxl/libxl_dm.c
+++ b/tools/libxl/libxl_dm.c
@@ -383,6 +383,12 @@ static char ** libxl__build_device_model_args_new(libxl__gc *gc,
         flexarray_append(dm_args, "-xen-attach");
     }
 
+    if (b_info->type == LIBXL_DOMAIN_TYPE_HVM &&
+        libxl_defbool_val(b_info->u.hvm.xen_platform_pci)) {
+        flexarray_append(dm_args, "-device");
+        flexarray_append(dm_args, "xen-platform");
+    }
+
     if (c_info->name) {
         flexarray_vappend(dm_args, "-name", c_info->name, NULL);
     }
-- 
1.7.10.4

^ permalink raw reply related	[flat|nested] only message in thread

only message in thread, other threads:[~2013-06-13  9:52 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-06-13  9:52 [PATCH] Properly control platform device creation in upstream QEMU Paul Durrant

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).