* [xen-unstable test] 18128: regressions - FAIL
@ 2013-06-15 6:16 xen.org
2013-06-15 8:35 ` Ian Campbell
0 siblings, 1 reply; 5+ messages in thread
From: xen.org @ 2013-06-15 6:16 UTC (permalink / raw)
To: xen-devel; +Cc: ian.jackson
flight 18128 xen-unstable real [real]
http://www.chiark.greenend.org.uk/~xensrcts/logs/18128/
Regressions :-(
Tests which did not succeed and are blocking,
including tests which could not be run:
build-armhf 4 xen-build fail REGR. vs. 18121
Tests which did not succeed, but are not blocking:
test-amd64-amd64-xl-pcipt-intel 9 guest-start fail never pass
test-amd64-i386-xend-winxpsp3 16 leak-check/check fail never pass
test-amd64-amd64-xl-qemut-win7-amd64 13 guest-stop fail never pass
test-amd64-amd64-xl-qemuu-winxpsp3 13 guest-stop fail never pass
test-amd64-amd64-xl-qemuu-win7-amd64 13 guest-stop fail never pass
test-amd64-i386-xl-win7-amd64 13 guest-stop fail never pass
test-amd64-amd64-xl-win7-amd64 13 guest-stop fail never pass
test-amd64-i386-xl-qemut-win7-amd64 13 guest-stop fail never pass
test-amd64-amd64-xl-winxpsp3 13 guest-stop fail never pass
test-amd64-amd64-xl-qemut-winxpsp3 13 guest-stop fail never pass
test-amd64-i386-xl-winxpsp3-vcpus1 13 guest-stop fail never pass
test-amd64-i386-xend-qemut-winxpsp3 16 leak-check/check fail never pass
test-amd64-i386-xl-qemut-winxpsp3-vcpus1 13 guest-stop fail never pass
version targeted for testing:
xen 82cb4113b6ace16de192021de20f6cbd991e478f
baseline version:
xen 2caac1caa19bdaeb9ab14b2baf1342e00c4d0495
------------------------------------------------------------
People who touched revisions under test:
George Dunlap <george.dunlap@eu.citrix.com>
Ian Campbell <ian.campbell@citrix.com>
Ian Jackson <Ian.Jackson@eu.citrix.com>
Matthew Daley <mattjd@gmail.com>
------------------------------------------------------------
jobs:
build-amd64 pass
build-armhf fail
build-i386 pass
build-amd64-oldkern pass
build-i386-oldkern pass
build-amd64-pvops pass
build-i386-pvops pass
test-amd64-amd64-xl pass
test-amd64-i386-xl pass
test-amd64-i386-rhel6hvm-amd pass
test-amd64-i386-qemut-rhel6hvm-amd pass
test-amd64-i386-qemuu-rhel6hvm-amd pass
test-amd64-amd64-xl-qemut-win7-amd64 fail
test-amd64-i386-xl-qemut-win7-amd64 fail
test-amd64-amd64-xl-qemuu-win7-amd64 fail
test-amd64-amd64-xl-win7-amd64 fail
test-amd64-i386-xl-win7-amd64 fail
test-amd64-i386-xl-credit2 pass
test-amd64-amd64-xl-pcipt-intel fail
test-amd64-i386-rhel6hvm-intel pass
test-amd64-i386-qemut-rhel6hvm-intel pass
test-amd64-i386-qemuu-rhel6hvm-intel pass
test-amd64-i386-xl-multivcpu pass
test-amd64-amd64-pair pass
test-amd64-i386-pair pass
test-amd64-amd64-xl-sedf-pin pass
test-amd64-amd64-pv pass
test-amd64-i386-pv pass
test-amd64-amd64-xl-sedf pass
test-amd64-i386-xl-qemut-winxpsp3-vcpus1 fail
test-amd64-i386-xl-winxpsp3-vcpus1 fail
test-amd64-i386-xend-qemut-winxpsp3 fail
test-amd64-amd64-xl-qemut-winxpsp3 fail
test-amd64-amd64-xl-qemuu-winxpsp3 fail
test-amd64-i386-xend-winxpsp3 fail
test-amd64-amd64-xl-winxpsp3 fail
------------------------------------------------------------
sg-report-flight on woking.cam.xci-test.com
logs: /home/xc_osstest/logs
images: /home/xc_osstest/images
Logs, config files, etc. are available at
http://www.chiark.greenend.org.uk/~xensrcts/logs
Test harness code can be found at
http://xenbits.xensource.com/gitweb?p=osstest.git;a=summary
Not pushing.
(No revision log; it would be 928 lines long.)
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [xen-unstable test] 18128: regressions - FAIL
2013-06-15 6:16 [xen-unstable test] 18128: regressions - FAIL xen.org
@ 2013-06-15 8:35 ` Ian Campbell
2013-06-15 11:15 ` Andrew Cooper
0 siblings, 1 reply; 5+ messages in thread
From: Ian Campbell @ 2013-06-15 8:35 UTC (permalink / raw)
To: xen.org; +Cc: Julien Grall, Tim Deegan, xen-devel, Stefano Stabellini
On Sat, 2013-06-15 at 07:16 +0100, xen.org wrote:
> flight 18128 xen-unstable real [real]
> http://www.chiark.greenend.org.uk/~xensrcts/logs/18128/
>
> Regressions :-(
>
> Tests which did not succeed and are blocking,
> including tests which could not be run:
> build-armhf 4 xen-build fail REGR. vs. 18121
kernel.c: In function 'kernel_elf_load':
kernel.c:162:18: error: 'struct elf_binary' has no member named 'dest'
make[4]: *** [kernel.o] Error 1
The bisector has separately fingered ed65808a8ed4 "libelf: check all
pointer accesses".
8<-----------------------
>From d1b3125b7e4d9ad3b1d8bb78781dd95fc2af2fee Mon Sep 17 00:00:00 2001
From: Ian Campbell <ian.campbell@citrix.com>
Date: Sat, 15 Jun 2013 09:30:47 +0100
Subject: [PATCH] xen: arm: fix build after libelf changes.
ed65808a8ed4 "libelf: check all pointer accesses" caused:
kernel.c: In function 'kernel_elf_load':
kernel.c:162:18: error: 'struct elf_binary' has no member named 'dest'
make[4]: *** [kernel.o] Error 1
The field is now called dest_base. We also need to populate dest_size.
This fixes the build for me although have not tested it. I have a feeling that
loading the kernel from an ELF file on ARM doesn't currently work anyway
(everyone uses the zImage loader as far as I am aware).
Signed-off-by: Ian Campbell <ian.campbell@citrix.com>
Cc: ian.jackson@eu.citrix.com
Cc: stefano.stabellini@citrix.com
Cc: julien.grall@citrix.com
Cc: tim@xen.org
---
xen/arch/arm/kernel.c | 4 +++-
1 files changed, 3 insertions(+), 1 deletions(-)
diff --git a/xen/arch/arm/kernel.c b/xen/arch/arm/kernel.c
index 43cf2ab..aba5441 100644
--- a/xen/arch/arm/kernel.c
+++ b/xen/arch/arm/kernel.c
@@ -159,7 +159,9 @@ static int kernel_try_zimage_prepare(struct kernel_info *info,
static void kernel_elf_load(struct kernel_info *info)
{
printk("Loading ELF image into guest memory\n");
- info->elf.elf.dest = (void*)(unsigned long)info->elf.parms.virt_kstart;
+ info->elf.elf.dest_base = (void*)(unsigned long)info->elf.parms.virt_kstart;
+ info->elf.elf.dest_size =
+ info->elf.parms.virt_kend - info->elf.parms.virt_kstart;
elf_load_binary(&info->elf.elf);
printk("Free temporary kernel buffer\n");
--
1.7.2.5
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [xen-unstable test] 18128: regressions - FAIL
2013-06-15 8:35 ` Ian Campbell
@ 2013-06-15 11:15 ` Andrew Cooper
2013-06-15 12:00 ` Ian Campbell
2013-06-16 19:24 ` Ian Campbell
0 siblings, 2 replies; 5+ messages in thread
From: Andrew Cooper @ 2013-06-15 11:15 UTC (permalink / raw)
To: Ian Campbell
Cc: Julien Grall, Tim (Xen.org), xen-devel@lists.xensource.com,
Ian Jackson, Stefano Stabellini
On 15/06/2013 09:35, Ian Campbell wrote:
> On Sat, 2013-06-15 at 07:16 +0100, xen.org wrote:
>> flight 18128 xen-unstable real [real]
>> http://www.chiark.greenend.org.uk/~xensrcts/logs/18128/
>>
>> Regressions :-(
>>
>> Tests which did not succeed and are blocking,
>> including tests which could not be run:
>> build-armhf 4 xen-build fail REGR. vs. 18121
> kernel.c: In function 'kernel_elf_load':
> kernel.c:162:18: error: 'struct elf_binary' has no member named 'dest'
> make[4]: *** [kernel.o] Error 1
>
> The bisector has separately fingered ed65808a8ed4 "libelf: check all
> pointer accesses".
>
> 8<-----------------------
>
> From d1b3125b7e4d9ad3b1d8bb78781dd95fc2af2fee Mon Sep 17 00:00:00 2001
> From: Ian Campbell <ian.campbell@citrix.com>
> Date: Sat, 15 Jun 2013 09:30:47 +0100
> Subject: [PATCH] xen: arm: fix build after libelf changes.
>
> ed65808a8ed4 "libelf: check all pointer accesses" caused:
> kernel.c: In function 'kernel_elf_load':
> kernel.c:162:18: error: 'struct elf_binary' has no member named 'dest'
> make[4]: *** [kernel.o] Error 1
>
> The field is now called dest_base. We also need to populate dest_size.
>
> This fixes the build for me although have not tested it. I have a feeling that
> loading the kernel from an ELF file on ARM doesn't currently work anyway
> (everyone uses the zImage loader as far as I am aware).
>
> Signed-off-by: Ian Campbell <ian.campbell@citrix.com>
Reviewed-by: Andrew Cooper <andrew.cooper3@citrix.com>
Although it might perhaps be better to fail kernel_elf_load() with
panic("Not implemented yet") if it really has never been tried. It is
likely to be less subtle than what actually does break.
> Cc: ian.jackson@eu.citrix.com
> Cc: stefano.stabellini@citrix.com
> Cc: julien.grall@citrix.com
> Cc: tim@xen.org
> ---
> xen/arch/arm/kernel.c | 4 +++-
> 1 files changed, 3 insertions(+), 1 deletions(-)
>
> diff --git a/xen/arch/arm/kernel.c b/xen/arch/arm/kernel.c
> index 43cf2ab..aba5441 100644
> --- a/xen/arch/arm/kernel.c
> +++ b/xen/arch/arm/kernel.c
> @@ -159,7 +159,9 @@ static int kernel_try_zimage_prepare(struct kernel_info *info,
> static void kernel_elf_load(struct kernel_info *info)
> {
> printk("Loading ELF image into guest memory\n");
> - info->elf.elf.dest = (void*)(unsigned long)info->elf.parms.virt_kstart;
> + info->elf.elf.dest_base = (void*)(unsigned long)info->elf.parms.virt_kstart;
> + info->elf.elf.dest_size =
> + info->elf.parms.virt_kend - info->elf.parms.virt_kstart;
> elf_load_binary(&info->elf.elf);
>
> printk("Free temporary kernel buffer\n");
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [xen-unstable test] 18128: regressions - FAIL
2013-06-15 11:15 ` Andrew Cooper
@ 2013-06-15 12:00 ` Ian Campbell
2013-06-16 19:24 ` Ian Campbell
1 sibling, 0 replies; 5+ messages in thread
From: Ian Campbell @ 2013-06-15 12:00 UTC (permalink / raw)
To: Andrew Cooper
Cc: Julien Grall, Tim (Xen.org), xen-devel@lists.xensource.com,
Ian Jackson, Stefano Stabellini
On Sat, 2013-06-15 at 12:15 +0100, Andrew Cooper wrote:
> On 15/06/2013 09:35, Ian Campbell wrote:
> > On Sat, 2013-06-15 at 07:16 +0100, xen.org wrote:
> >> flight 18128 xen-unstable real [real]
> >> http://www.chiark.greenend.org.uk/~xensrcts/logs/18128/
> >>
> >> Regressions :-(
> >>
> >> Tests which did not succeed and are blocking,
> >> including tests which could not be run:
> >> build-armhf 4 xen-build fail REGR. vs. 18121
> > kernel.c: In function 'kernel_elf_load':
> > kernel.c:162:18: error: 'struct elf_binary' has no member named 'dest'
> > make[4]: *** [kernel.o] Error 1
> >
> > The bisector has separately fingered ed65808a8ed4 "libelf: check all
> > pointer accesses".
> >
> > 8<-----------------------
> >
> > From d1b3125b7e4d9ad3b1d8bb78781dd95fc2af2fee Mon Sep 17 00:00:00 2001
> > From: Ian Campbell <ian.campbell@citrix.com>
> > Date: Sat, 15 Jun 2013 09:30:47 +0100
> > Subject: [PATCH] xen: arm: fix build after libelf changes.
> >
> > ed65808a8ed4 "libelf: check all pointer accesses" caused:
> > kernel.c: In function 'kernel_elf_load':
> > kernel.c:162:18: error: 'struct elf_binary' has no member named 'dest'
> > make[4]: *** [kernel.o] Error 1
> >
> > The field is now called dest_base. We also need to populate dest_size.
> >
> > This fixes the build for me although have not tested it. I have a feeling that
> > loading the kernel from an ELF file on ARM doesn't currently work anyway
> > (everyone uses the zImage loader as far as I am aware).
> >
> > Signed-off-by: Ian Campbell <ian.campbell@citrix.com>
>
> Reviewed-by: Andrew Cooper <andrew.cooper3@citrix.com>
Thanks.
> Although it might perhaps be better to fail kernel_elf_load() with
> panic("Not implemented yet") if it really has never been tried. It is
> likely to be less subtle than what actually does break.
It did used to work, we used it before we got zImage support, and I
don't know for sure its broken, I just suspect it is.
We should probably just rip it out at some point, but for now lets just
get the build error fixed.
>
> > Cc: ian.jackson@eu.citrix.com
> > Cc: stefano.stabellini@citrix.com
> > Cc: julien.grall@citrix.com
> > Cc: tim@xen.org
> > ---
> > xen/arch/arm/kernel.c | 4 +++-
> > 1 files changed, 3 insertions(+), 1 deletions(-)
> >
> > diff --git a/xen/arch/arm/kernel.c b/xen/arch/arm/kernel.c
> > index 43cf2ab..aba5441 100644
> > --- a/xen/arch/arm/kernel.c
> > +++ b/xen/arch/arm/kernel.c
> > @@ -159,7 +159,9 @@ static int kernel_try_zimage_prepare(struct kernel_info *info,
> > static void kernel_elf_load(struct kernel_info *info)
> > {
> > printk("Loading ELF image into guest memory\n");
> > - info->elf.elf.dest = (void*)(unsigned long)info->elf.parms.virt_kstart;
> > + info->elf.elf.dest_base = (void*)(unsigned long)info->elf.parms.virt_kstart;
> > + info->elf.elf.dest_size =
> > + info->elf.parms.virt_kend - info->elf.parms.virt_kstart;
> > elf_load_binary(&info->elf.elf);
> >
> > printk("Free temporary kernel buffer\n");
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [xen-unstable test] 18128: regressions - FAIL
2013-06-15 11:15 ` Andrew Cooper
2013-06-15 12:00 ` Ian Campbell
@ 2013-06-16 19:24 ` Ian Campbell
1 sibling, 0 replies; 5+ messages in thread
From: Ian Campbell @ 2013-06-16 19:24 UTC (permalink / raw)
To: Andrew Cooper
Cc: Julien Grall, Tim (Xen.org), xen-devel@lists.xensource.com,
Ian Jackson, Stefano Stabellini
On Sat, 2013-06-15 at 12:15 +0100, Andrew Cooper wrote:
> > From d1b3125b7e4d9ad3b1d8bb78781dd95fc2af2fee Mon Sep 17 00:00:00 2001
> > From: Ian Campbell <ian.campbell@citrix.com>
> > Date: Sat, 15 Jun 2013 09:30:47 +0100
> > Subject: [PATCH] xen: arm: fix build after libelf changes.
> >
> > ed65808a8ed4 "libelf: check all pointer accesses" caused:
> > kernel.c: In function 'kernel_elf_load':
> > kernel.c:162:18: error: 'struct elf_binary' has no member named 'dest'
> > make[4]: *** [kernel.o] Error 1
> >
> > The field is now called dest_base. We also need to populate dest_size.
> >
> > This fixes the build for me although have not tested it. I have a feeling that
> > loading the kernel from an ELF file on ARM doesn't currently work anyway
> > (everyone uses the zImage loader as far as I am aware).
> >
> > Signed-off-by: Ian Campbell <ian.campbell@citrix.com>
>
> Reviewed-by: Andrew Cooper <andrew.cooper3@citrix.com>
In the interests of getting a test push I've stuck this into the tree
with your review, since it's an area which you are currently rather
familiar.
Thanks!
Ian.
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2013-06-16 19:24 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-06-15 6:16 [xen-unstable test] 18128: regressions - FAIL xen.org
2013-06-15 8:35 ` Ian Campbell
2013-06-15 11:15 ` Andrew Cooper
2013-06-15 12:00 ` Ian Campbell
2013-06-16 19:24 ` Ian Campbell
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).