xen-devel.lists.xenproject.org archive mirror
 help / color / mirror / Atom feed
From: Ian Campbell <Ian.Campbell@citrix.com>
To: Andrew Cooper <andrew.cooper3@citrix.com>
Cc: Julien Grall <julien.grall@citrix.com>,
	"Tim (Xen.org)" <tim@xen.org>,
	"xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>,
	Ian Jackson <Ian.Jackson@eu.citrix.com>,
	Stefano Stabellini <Stefano.Stabellini@eu.citrix.com>
Subject: Re: [xen-unstable test] 18128: regressions - FAIL
Date: Sun, 16 Jun 2013 20:24:37 +0100	[thread overview]
Message-ID: <1371410677.18293.14.camel@dagon.hellion.org.uk> (raw)
In-Reply-To: <51BC4CB7.8050204@citrix.com>

On Sat, 2013-06-15 at 12:15 +0100, Andrew Cooper wrote:
> > From d1b3125b7e4d9ad3b1d8bb78781dd95fc2af2fee Mon Sep 17 00:00:00 2001
> > From: Ian Campbell <ian.campbell@citrix.com>
> > Date: Sat, 15 Jun 2013 09:30:47 +0100
> > Subject: [PATCH] xen: arm: fix build after libelf changes.
> >
> > ed65808a8ed4 "libelf: check all pointer accesses" caused:
> >     kernel.c: In function 'kernel_elf_load':
> >     kernel.c:162:18: error: 'struct elf_binary' has no member named 'dest'
> >     make[4]: *** [kernel.o] Error 1
> >
> > The field is now called dest_base. We also need to populate dest_size.
> >
> > This fixes the build for me although have not tested it. I have a feeling that
> > loading the kernel from an ELF file on ARM doesn't currently work anyway
> > (everyone uses the zImage loader as far as I am aware).
> >
> > Signed-off-by: Ian Campbell <ian.campbell@citrix.com>
> 
> Reviewed-by: Andrew Cooper <andrew.cooper3@citrix.com>

In the interests of getting a test push I've stuck this into the tree
with your review, since it's an area which you are currently rather
familiar.

Thanks!

Ian.

      parent reply	other threads:[~2013-06-16 19:24 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-06-15  6:16 [xen-unstable test] 18128: regressions - FAIL xen.org
2013-06-15  8:35 ` Ian Campbell
2013-06-15 11:15   ` Andrew Cooper
2013-06-15 12:00     ` Ian Campbell
2013-06-16 19:24     ` Ian Campbell [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1371410677.18293.14.camel@dagon.hellion.org.uk \
    --to=ian.campbell@citrix.com \
    --cc=Ian.Jackson@eu.citrix.com \
    --cc=Stefano.Stabellini@eu.citrix.com \
    --cc=andrew.cooper3@citrix.com \
    --cc=julien.grall@citrix.com \
    --cc=tim@xen.org \
    --cc=xen-devel@lists.xensource.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).