From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ian Campbell <Ian.Campbell@citrix.com>
Subject: Re: [xen-unstable test] 18128: regressions - FAIL
Date: Sun, 16 Jun 2013 20:24:37 +0100
Message-ID: <1371410677.18293.14.camel@dagon.hellion.org.uk>
References: <osstest-18128-mainreport@xen.org>
	<1371285334.25232.51.camel@dagon.hellion.org.uk>
	<51BC4CB7.8050204@citrix.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <51BC4CB7.8050204@citrix.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Andrew Cooper <andrew.cooper3@citrix.com>
Cc: Julien Grall <julien.grall@citrix.com>, "Tim (Xen.org)" <tim@xen.org>, "xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>, Ian Jackson <Ian.Jackson@eu.citrix.com>, Stefano Stabellini <Stefano.Stabellini@eu.citrix.com>
List-Id: xen-devel@lists.xenproject.org

On Sat, 2013-06-15 at 12:15 +0100, Andrew Cooper wrote:
> > From d1b3125b7e4d9ad3b1d8bb78781dd95fc2af2fee Mon Sep 17 00:00:00 2001
> > From: Ian Campbell <ian.campbell@citrix.com>
> > Date: Sat, 15 Jun 2013 09:30:47 +0100
> > Subject: [PATCH] xen: arm: fix build after libelf changes.
> >
> > ed65808a8ed4 "libelf: check all pointer accesses" caused:
> >     kernel.c: In function 'kernel_elf_load':
> >     kernel.c:162:18: error: 'struct elf_binary' has no member named 'dest'
> >     make[4]: *** [kernel.o] Error 1
> >
> > The field is now called dest_base. We also need to populate dest_size.
> >
> > This fixes the build for me although have not tested it. I have a feeling that
> > loading the kernel from an ELF file on ARM doesn't currently work anyway
> > (everyone uses the zImage loader as far as I am aware).
> >
> > Signed-off-by: Ian Campbell <ian.campbell@citrix.com>
> 
> Reviewed-by: Andrew Cooper <andrew.cooper3@citrix.com>

In the interests of getting a test push I've stuck this into the tree
with your review, since it's an area which you are currently rather
familiar.

Thanks!

Ian.