From: George Dunlap <george.dunlap@eu.citrix.com>
To: xen-devel@lists.xen.org
Cc: Keir Fraser <keir@xen.org>,
Ian Campbell <ian.campbell@citrix.com>,
Hanweidong <hanweidong@huawei.com>,
George Dunlap <george.dunlap@eu.citrix.com>,
Stefano Stabellini <stefano.stabellini@citrix.com>,
Ian Jackson <ian.jackson@citrix.com>
Subject: [PATCH v3 1/8] hvmloader: Remove all 64-bit print arguments
Date: Thu, 20 Jun 2013 17:33:20 +0100 [thread overview]
Message-ID: <1371746007-19073-2-git-send-email-george.dunlap@eu.citrix.com> (raw)
In-Reply-To: <1371746007-19073-1-git-send-email-george.dunlap@eu.citrix.com>
The printf() available to hvmloader does not handle 64-bit data types;
manually break them down as two 32-bit strings.
Signed-off-by: George Dunlap <george.dunlap@eu.citrix.com>
CC: Ian Campbell <ian.campbell@citrix.com>
CC: Ian Jackson <ian.jackson@citrix.com>
CC: Stefano Stabellini <stefano.stabellini@citrix.com>
CC: Hanweidong <hanweidong@huawei.com>
CC: Keir Fraser <keir@xen.org>
---
tools/firmware/hvmloader/pci.c | 11 +++++++----
1 file changed, 7 insertions(+), 4 deletions(-)
diff --git a/tools/firmware/hvmloader/pci.c b/tools/firmware/hvmloader/pci.c
index c78d4d3..aa54bc1 100644
--- a/tools/firmware/hvmloader/pci.c
+++ b/tools/firmware/hvmloader/pci.c
@@ -290,8 +290,9 @@ void pci_setup(void)
if ( (base < resource->base) || (base > resource->max) )
{
- printf("pci dev %02x:%x bar %02x size %llx: no space for "
- "resource!\n", devfn>>3, devfn&7, bar_reg, bar_sz);
+ printf("pci dev %02x:%x bar %02x size %x%08x: no space for "
+ "resource!\n", devfn>>3, devfn&7, bar_reg,
+ (uint32_t)(bar_sz>>32), (uint32_t)bar_sz);
continue;
}
@@ -300,8 +301,10 @@ void pci_setup(void)
pci_writel(devfn, bar_reg, bar_data);
if (using_64bar)
pci_writel(devfn, bar_reg + 4, bar_data_upper);
- printf("pci dev %02x:%x bar %02x size %llx: %08x\n",
- devfn>>3, devfn&7, bar_reg, bar_sz, bar_data);
+ printf("pci dev %02x:%x bar %02x size %x%08x: %08x\n",
+ devfn>>3, devfn&7, bar_reg,
+ (uint32_t)(bar_sz>>32), (uint32_t)bar_sz,
+ bar_data);
/* Now enable the memory or I/O mapping. */
--
1.7.9.5
next prev parent reply other threads:[~2013-06-20 16:33 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-20 16:33 [PATCH 0/8] Relocate devices rather than memory for qemu-xen George Dunlap
2013-06-20 16:33 ` George Dunlap [this message]
2013-06-20 17:06 ` [PATCH v3 1/8] hvmloader: Remove all 64-bit print arguments Stefano Stabellini
2013-06-20 17:09 ` Ian Jackson
2013-06-21 8:37 ` George Dunlap
2013-06-21 8:34 ` George Dunlap
2013-06-21 9:22 ` George Dunlap
2013-06-21 10:22 ` [PATCH v3 1/8] hvmloader: Remove all 64-bit print arguments [and 1 more messages] Ian Jackson
2013-06-21 10:23 ` [PATCH v3 1/8] hvmloader: Remove all 64-bit print arguments Ian Jackson
2013-06-20 16:33 ` [PATCH v3 2/8] hvmloader: Make the printfs more informative George Dunlap
2013-06-20 17:12 ` Stefano Stabellini
2013-06-21 9:35 ` George Dunlap
2013-06-21 9:50 ` George Dunlap
2013-06-21 10:53 ` Stefano Stabellini
2013-06-21 10:53 ` Stefano Stabellini
2013-06-21 10:35 ` Ian Jackson
2013-06-20 16:33 ` [PATCH v3 3/8] hvmloader: Set up highmem resouce appropriately if there is no RAM above 4G George Dunlap
2013-06-20 17:16 ` Stefano Stabellini
2013-06-21 7:01 ` Jan Beulich
2013-06-21 9:06 ` George Dunlap
2013-06-21 10:38 ` Ian Jackson
2013-06-20 16:33 ` [PATCH v3 4/8] hvmloader: Fix check for needing a 64-bit bar George Dunlap
2013-06-20 16:33 ` [PATCH v3 5/8] hvmloader: Correct bug in low mmio region accounting George Dunlap
2013-06-20 17:20 ` Stefano Stabellini
2013-06-21 7:09 ` Jan Beulich
2013-06-20 16:33 ` [PATCH v3 6/8] hvmloader: Load large devices into high MMIO space as needed George Dunlap
2013-06-20 17:23 ` Stefano Stabellini
2013-06-21 7:12 ` Jan Beulich
2013-06-20 16:33 ` [PATCH v3 7/8] hvmloader: Remove minimum size for BARs to relocate to 64-bit space George Dunlap
2013-06-20 16:33 ` [PATCH v3 8/8] libxl, hvmloader: Don't relocate memory for MMIO hole George Dunlap
2013-06-20 17:38 ` Stefano Stabellini
2013-06-21 8:31 ` George Dunlap
2013-06-21 11:21 ` Stefano Stabellini
2013-06-21 11:31 ` Ian Jackson
2013-06-21 7:17 ` Jan Beulich
2013-06-21 8:32 ` George Dunlap
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1371746007-19073-2-git-send-email-george.dunlap@eu.citrix.com \
--to=george.dunlap@eu.citrix.com \
--cc=hanweidong@huawei.com \
--cc=ian.campbell@citrix.com \
--cc=ian.jackson@citrix.com \
--cc=keir@xen.org \
--cc=stefano.stabellini@citrix.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).