From: Jacob Shin <jacob.shin@amd.com>
To: Jan Beulich <jbeulich@suse.com>, Liu Jinsong <jinsong.liu@intel.com>
Cc: Jacob Shin <jacob.shin@amd.com>,
Suravee Suthikulanit <suravee.suthikulpanit@amd.com>,
xen-devel@lists.xen.org
Subject: [PATCH V2 1/2] cpufreq, xenpm: fix cpufreq and xenpm mismatch
Date: Thu, 20 Jun 2013 12:04:08 -0500 [thread overview]
Message-ID: <1371747849-1817-1-git-send-email-jacob.shin@amd.com> (raw)
Currently cpufreq and xenpm are out of sync. Fix cpufreq reporting of
if turbo mode is enabled or not. Fix xenpm to not decode for tristate,
but a boolean.
Signed-off-by: Jacob Shin <jacob.shin@amd.com>
---
tools/misc/xenpm.c | 14 +++-----------
xen/drivers/cpufreq/utility.c | 2 +-
2 files changed, 4 insertions(+), 12 deletions(-)
diff --git a/tools/misc/xenpm.c b/tools/misc/xenpm.c
index b5f1383..2e57f1f 100644
--- a/tools/misc/xenpm.c
+++ b/tools/misc/xenpm.c
@@ -31,10 +31,6 @@
#define ARRAY_SIZE(a) (sizeof (a) / sizeof ((a)[0]))
-#define CPUFREQ_TURBO_DISABLED -1
-#define CPUFREQ_TURBO_UNSUPPORTED 0
-#define CPUFREQ_TURBO_ENABLED 1
-
static xc_interface *xc_handle;
static unsigned int max_cpu_nr;
@@ -699,13 +695,9 @@ static void print_cpufreq_para(int cpuid, struct xc_get_cpufreq_para *p_cpufreq)
p_cpufreq->scaling_max_freq,
p_cpufreq->scaling_min_freq,
p_cpufreq->scaling_cur_freq);
- if (p_cpufreq->turbo_enabled != CPUFREQ_TURBO_UNSUPPORTED) {
- printf("turbo mode : ");
- if (p_cpufreq->turbo_enabled == CPUFREQ_TURBO_ENABLED)
- printf("enabled\n");
- else
- printf("disabled\n");
- }
+
+ printf("turbo mode : %s\n",
+ p_cpufreq->turbo_enabled ? "enabled" : "disabled or n/a");
printf("\n");
}
diff --git a/xen/drivers/cpufreq/utility.c b/xen/drivers/cpufreq/utility.c
index 3dd70e2..519f862 100644
--- a/xen/drivers/cpufreq/utility.c
+++ b/xen/drivers/cpufreq/utility.c
@@ -428,7 +428,7 @@ int cpufreq_get_turbo_status(int cpuid)
struct cpufreq_policy *policy;
policy = per_cpu(cpufreq_cpu_policy, cpuid);
- return policy && policy->turbo;
+ return policy && policy->turbo == CPUFREQ_TURBO_ENABLED;
}
/*********************************************************************
--
1.7.9.5
next reply other threads:[~2013-06-20 17:04 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-20 17:04 Jacob Shin [this message]
2013-06-20 17:04 ` [PATCH V2 2/2] cpufreq, powernow: enable/disable core performance boost for all CPUs in the Node Jacob Shin
2013-06-20 21:18 ` Liu, Jinsong
2013-06-21 6:35 ` Jan Beulich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1371747849-1817-1-git-send-email-jacob.shin@amd.com \
--to=jacob.shin@amd.com \
--cc=jbeulich@suse.com \
--cc=jinsong.liu@intel.com \
--cc=suravee.suthikulpanit@amd.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).