From: George Dunlap <george.dunlap@eu.citrix.com>
To: xen-devel@lists.xen.org
Cc: Keir Fraser <keir@xen.org>,
Ian Campbell <ian.campbell@citrix.com>,
Hanweidong <hanweidong@huawei.com>,
George Dunlap <george.dunlap@eu.citrix.com>,
Stefano Stabellini <stefano.stabellini@citrix.com>,
Ian Jackson <ian.jackson@citrix.com>
Subject: [PATCH v5 3/8] hvmloader: Set up highmem resouce appropriately if there is no RAM above 4G
Date: Fri, 21 Jun 2013 17:08:46 +0100 [thread overview]
Message-ID: <1371830931-3904-4-git-send-email-george.dunlap@eu.citrix.com> (raw)
In-Reply-To: <1371830931-3904-1-git-send-email-george.dunlap@eu.citrix.com>
hvmloader will read hvm_info->high_mem_pgend to calculate where to
start the highmem PCI region. However, if the guest does not have any
memory in the high region, this is set to zero, which will cause
hvmloader to use the "0" for the base of the highmem region, rather
than 1 << 32.
Check to see whether hvm_info->high_mem_pgend is set; if so, do the
normal calculation; otherwise, use 1<<32.
v4:
- Handle case where hfm_info->high_mem_pgend is non-zero but doesn't
point into high memory, throwing a warning.
Signed-off-by: George Dunlap <george.dunlap@eu.citrix.com>
Acked-by: Ian Jackson <ian.jackson@eu.citrix.com>
Acked-by: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
CC: Ian Campbell <ian.campbell@citrix.com>
CC: Ian Jackson <ian.jackson@citrix.com>
CC: Stefano Stabellini <stefano.stabellini@citrix.com>
CC: Hanweidong <hanweidong@huawei.com>
CC: Keir Fraser <keir@xen.org>
---
tools/firmware/hvmloader/pci.c | 13 ++++++++++++-
1 file changed, 12 insertions(+), 1 deletion(-)
diff --git a/tools/firmware/hvmloader/pci.c b/tools/firmware/hvmloader/pci.c
index 44168e2..a3d03ed 100644
--- a/tools/firmware/hvmloader/pci.c
+++ b/tools/firmware/hvmloader/pci.c
@@ -246,7 +246,18 @@ void pci_setup(void)
hvm_info->high_mem_pgend += nr_pages;
}
- high_mem_resource.base = ((uint64_t)hvm_info->high_mem_pgend) << PAGE_SHIFT;
+ high_mem_resource.base = ((uint64_t)hvm_info->high_mem_pgend) << PAGE_SHIFT;
+ if ( high_mem_resource.base < 1ull << 32 )
+ {
+ if ( hvm_info->high_mem_pgend != 0 )
+ printf("WARNING: hvm_info->high_mem_pgend %x"
+ " does not point into high memory!",
+ hvm_info->high_mem_pgend);
+ high_mem_resource.base = 1ull << 32;
+ }
+ printf("%sRAM in high memory; setting high_mem resource base to "PRIllx"\n",
+ hvm_info->high_mem_pgend?"":"No ",
+ PRIllx_arg(high_mem_resource.base));
high_mem_resource.max = 1ull << cpu_phys_addr();
mem_resource.base = pci_mem_start;
mem_resource.max = pci_mem_end;
--
1.7.9.5
next prev parent reply other threads:[~2013-06-21 16:08 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-21 16:08 [PATCH v5 0/8] Relocate devices rather than memory for qemu-xen George Dunlap
2013-06-21 16:08 ` [PATCH v5 1/8] hvmloader: Remove all 64-bit print arguments George Dunlap
2013-06-21 16:08 ` [PATCH v5 2/8] hvmloader: Make the printfs more informative George Dunlap
2013-06-21 16:08 ` George Dunlap [this message]
2013-06-21 16:08 ` [PATCH v5 4/8] hvmloader: Fix check for needing a 64-bit bar George Dunlap
2013-06-21 16:08 ` [PATCH v5 5/8] hvmloader: Correct bug in low mmio region accounting George Dunlap
2013-06-21 16:08 ` [PATCH v5 6/8] hvmloader: Load large devices into high MMIO space as needed George Dunlap
2013-06-21 16:08 ` [PATCH v5 7/8] hvmloader: Remove minimum size for BARs to relocate to 64-bit space George Dunlap
2013-06-21 16:08 ` [PATCH v5 8/8] libxl, hvmloader: Don't relocate memory for MMIO hole George Dunlap
2013-06-25 13:23 ` Ian Campbell
2013-06-24 11:27 ` [PATCH v5 0/8] Relocate devices rather than memory for qemu-xen Ian Jackson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1371830931-3904-4-git-send-email-george.dunlap@eu.citrix.com \
--to=george.dunlap@eu.citrix.com \
--cc=hanweidong@huawei.com \
--cc=ian.campbell@citrix.com \
--cc=ian.jackson@citrix.com \
--cc=keir@xen.org \
--cc=stefano.stabellini@citrix.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).