From: George Dunlap <george.dunlap@eu.citrix.com>
To: xen-devel@lists.xen.org
Cc: George Dunlap <george.dunlap@eu.citrix.com>,
Ian Jackson <ian.jackson@citrix.com>,
Ian Campbell <ian.campbell@citrix.com>,
Jan Beulich <jbeulich@suse.com>,
Roger Pau Monne <roger.pau@citrix.com>
Subject: [PATCH 1/2] libxl: Allow network driver domains when run_hotplug_scritps is set
Date: Fri, 5 Jul 2013 12:13:54 +0100 [thread overview]
Message-ID: <1373022835-3807-1-git-send-email-george.dunlap@eu.citrix.com> (raw)
As of commit 05bfd984dfe7014f1f5ea1133608b9bab589c120, hotplug scripts
are not run if backend_domid != LIBXL_TOOSTACK_DOMID; so there is no reason
to restrict this for network driver domains any more.
This is a candidate for backporting to 4.3.
Signed-off-by: George Dunlap <george.dunlap@eu.citrix.com>
CC: Ian Campbell <ian.campbell@citrix.com>
CC: Ian Jackson <ian.jackson@citrix.com>
CC: Roger Pau Monne <roger.pau@citrix.com>
CC: Jan Beulich <jbeulich@suse.com>
---
docs/misc/xl-network-configuration.markdown | 6 ++----
tools/libxl/libxl.c | 7 -------
2 files changed, 2 insertions(+), 11 deletions(-)
diff --git a/docs/misc/xl-network-configuration.markdown b/docs/misc/xl-network-configuration.markdown
index e0d3d2a..3c439d4 100644
--- a/docs/misc/xl-network-configuration.markdown
+++ b/docs/misc/xl-network-configuration.markdown
@@ -131,10 +131,8 @@ specified IP address to be used by the guest (blocking all others).
### backend
Specifies the backend domain which this device should attach to. This
-defaults to domain 0. This option does not work if `run_hotplug_scripts`
-is not disabled in xl.conf (see xl.conf(5) man page for more information
-on this option). Specifying another domain requires setting up a driver
-domain which is outside the scope of this document.
+defaults to domain 0. Specifying another domain requires setting up a
+driver domain which is outside the scope of this document.
### rate
diff --git a/tools/libxl/libxl.c b/tools/libxl/libxl.c
index bd63a30..81785df 100644
--- a/tools/libxl/libxl.c
+++ b/tools/libxl/libxl.c
@@ -2820,13 +2820,6 @@ int libxl__device_nic_setdefault(libxl__gc *gc, libxl_device_nic *nic,
rc = libxl__resolve_domid(gc, nic->backend_domname, &nic->backend_domid);
if (rc < 0) return rc;
- if (nic->backend_domid != LIBXL_TOOLSTACK_DOMID && run_hotplug_scripts) {
- LOG(ERROR, "cannot use a backend domain different than %d if"
- "hotplug scripts are executed from libxl",
- LIBXL_TOOLSTACK_DOMID);
- return ERROR_FAIL;
- }
-
switch (libxl__domain_type(gc, domid)) {
case LIBXL_DOMAIN_TYPE_HVM:
if (!nic->nictype)
--
1.7.9.5
next reply other threads:[~2013-07-05 11:13 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-05 11:13 George Dunlap [this message]
2013-07-05 11:13 ` [PATCH 2/2] libxl: Add vif.default.backend to xl.conf George Dunlap
2013-07-05 11:47 ` Roger Pau Monné
2013-07-22 21:38 ` Ian Campbell
2013-07-05 11:45 ` [PATCH 1/2] libxl: Allow network driver domains when run_hotplug_scritps is set Roger Pau Monné
2013-07-17 11:19 ` [PATCH 1/2] libxl: Allow network driver domains when run_hotplug_scritps is set [and 1 more messages] Ian Jackson
2013-07-17 11:23 ` George Dunlap
2013-07-18 11:20 ` Ian Jackson
2013-07-18 11:21 ` George Dunlap
2013-09-13 13:44 ` Ian Jackson
2013-07-15 14:00 ` [PATCH 1/2] libxl: Allow network driver domains when run_hotplug_scritps is set George Dunlap
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1373022835-3807-1-git-send-email-george.dunlap@eu.citrix.com \
--to=george.dunlap@eu.citrix.com \
--cc=ian.campbell@citrix.com \
--cc=ian.jackson@citrix.com \
--cc=jbeulich@suse.com \
--cc=roger.pau@citrix.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).