[PATCH] xen/cpuidle: Reduce logging level for unknown apic_ids

[PATCH] xen/cpuidle: Reduce logging level for unknown apic_ids

[Andrew Cooper]

Dom0 uses this hypercall to pass ACPI information to Xen.

It is not very uncommon for more cpus to be listed in the ACPI tables than are
present on the system, particularly on systems with a common BIOS for a 2 and
4 socket server varients.

As Dom0 does not control the number of entries in the ACPI tables, and is
required to pass everything it finds to Xen, reduce the ERR to an INFO.

Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
CC: Keir Fraser <keir@xen.org>
CC: Jan Beulich <JBeulich@suse.com>
---
 xen/arch/x86/acpi/cpu_idle.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/xen/arch/x86/acpi/cpu_idle.c b/xen/arch/x86/acpi/cpu_idle.c
index 8cb1514..90e0a49 100644
--- a/xen/arch/x86/acpi/cpu_idle.c
+++ b/xen/arch/x86/acpi/cpu_idle.c
@@ -1031,7 +1031,7 @@ long set_cx_pminfo(uint32_t cpu, struct xen_processor_power *power)
     cpu_id = get_cpu_id(cpu);
     if ( cpu_id == -1 )
     {
-        printk(XENLOG_ERR "no cpu_id for acpi_id %d\n", cpu);
+        printk(XENLOG_INFO "no cpu_id for acpi_id %d\n", cpu);
         return -EINVAL;
     }
 
-- 
1.7.10.4

Re: [PATCH] xen/cpuidle: Reduce logging level for unknown apic_ids

[Jan Beulich]

>>> On 15.07.13 at 22:09, Andrew Cooper <andrew.cooper3@citrix.com> wrote:
> --- a/xen/arch/x86/acpi/cpu_idle.c
> +++ b/xen/arch/x86/acpi/cpu_idle.c
> @@ -1031,7 +1031,7 @@ long set_cx_pminfo(uint32_t cpu, struct xen_processor_power *power)
>      cpu_id = get_cpu_id(cpu);
>      if ( cpu_id == -1 )
>      {
> -        printk(XENLOG_ERR "no cpu_id for acpi_id %d\n", cpu);
> +        printk(XENLOG_INFO "no cpu_id for acpi_id %d\n", cpu);

Could we make this a warning on the first hit, and informational
on subsequent ones, so that at the default log level there's at
least some trace of this in the logs? Or alternatively make this
a warning in all cases, but gate other than the first invocation
on the opt_cpu_info flag (which would then need to be moved
out of __cpuinitdata)?

Also, once at it, could you change the message to something
less tied to C variable names, e.g. "No CPU ID for ACPI ID %#x\n"?

Jan