xen-devel.lists.xenproject.org archive mirror
 help / color / mirror / Atom feed
From: Daniel Kiper <daniel.kiper-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
To: andrew.cooper3-Sxgqhf6Nn4DQT0dZR+AlfA@public.gmane.org,
	kumagai-atsushi-biTfD1RFvDe45+QrQBaojngSJqDPrsil@public.gmane.org,
	kexec-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
	xen-devel-GuqFBffKawuULHF6PoxzQEEOCMrvLtNR@public.gmane.org
Cc: Daniel Kiper <daniel.kiper-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
Subject: [PATCH v2 2/7] elf: Properly check buf size in get_pt_note_info()
Date: Tue, 16 Jul 2013 14:32:04 +0200	[thread overview]
Message-ID: <1373977929-4253-3-git-send-email-daniel.kiper@oracle.com> (raw)
In-Reply-To: <1373977929-4253-1-git-send-email-daniel.kiper-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>

get_pt_note_info() always ignores VMCOREINFO_XEN note because
buf size must be smaller than note size including \0 char.
Usualy this condition is true but when VMCOREINFO_XEN note
is encountered it does not work due to buf size defined
as sizeof("VMCOREINFO_XEN"). This patch fixes that bug
and VMCOREINFO_XEN note living in /proc/vmcore file
could be properly detected now.

v2 - suggestions/fixes:
   - properly check buf size instead of increasing buf size
     (suggested by Andrew Cooper).

Signed-off-by: Daniel Kiper <daniel.kiper-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
---
 elf_info.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/elf_info.c b/elf_info.c
index 0c1e36a..e350b99 100644
--- a/elf_info.c
+++ b/elf_info.c
@@ -332,7 +332,7 @@ get_pt_note_info(void)
 		size_desc   = note_descsz(note);
 		offset_desc = offset + offset_note_desc(note);
 
-		if (!size_name || size_name >= sizeof(buf))
+		if (!size_name || size_name > sizeof(buf))
 			goto next_note;
 
 		if (read(fd_memory, &buf, sizeof(buf)) != sizeof(buf)) {
-- 
1.7.10.4

  parent reply	other threads:[~2013-07-16 12:32 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-07-16 12:32 [PATCH v2 0/7] makedumpfile: Xen fixes and minor cleanups Daniel Kiper
     [not found] ` <1373977929-4253-1-git-send-email-daniel.kiper-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
2013-07-16 12:32   ` [PATCH v2 1/7] xen: Improve calculation of beginning of virtual address space Daniel Kiper
     [not found]     ` <1373977929-4253-2-git-send-email-daniel.kiper-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
2013-07-18  8:03       ` Atsushi Kumagai
2013-07-16 12:32   ` Daniel Kiper [this message]
     [not found]     ` <1373977929-4253-3-git-send-email-daniel.kiper-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
2013-07-18  8:03       ` [PATCH v2 2/7] elf: Properly check buf size in get_pt_note_info() Atsushi Kumagai
2013-07-16 12:32   ` [PATCH v2 3/7] xen: Take into account new frame table address since Xen 4.3 Daniel Kiper
     [not found]     ` <1373977929-4253-4-git-send-email-daniel.kiper-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
2013-07-18  8:03       ` Atsushi Kumagai
2013-07-16 12:32   ` [PATCH v2 4/7] xen: Enforce page size only when xen-syms file is used Daniel Kiper
     [not found]     ` <1373977929-4253-5-git-send-email-daniel.kiper-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
2013-07-19  9:20       ` Atsushi Kumagai
     [not found]         ` <20130719182024.7695f88a6e4fe1160a10c74c-biTfD1RFvDe45+QrQBaojngSJqDPrsil@public.gmane.org>
2013-07-19 13:44           ` Daniel Kiper
     [not found]             ` <20130719134451.GF11233-ri7RxvcH2jeCtUdEpT35kVHq7GDQUN6HS7aiLakcVNdmR6Xm/wNWPw@public.gmane.org>
2013-07-22  7:35               ` Atsushi Kumagai
     [not found]                 ` <20130722163529.39ce6b1903324f8c3a0e7a44-biTfD1RFvDe45+QrQBaojngSJqDPrsil@public.gmane.org>
2013-07-22 21:23                   ` Daniel Kiper
2013-07-16 12:32   ` [PATCH v2 5/7] Do not break progress messages Daniel Kiper
     [not found]     ` <1373977929-4253-6-git-send-email-daniel.kiper-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
2013-07-19  9:20       ` Atsushi Kumagai
2013-07-16 12:32   ` [PATCH v2 6/7] Mute some compiler warnings Daniel Kiper
     [not found]     ` <1373977929-4253-7-git-send-email-daniel.kiper-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
2013-07-19  0:03       ` HATAYAMA Daisuke
     [not found]         ` <51E88265.1000005-+CUm20s59erQFUHtdCDX3A@public.gmane.org>
2013-07-19  9:20           ` Atsushi Kumagai
2013-07-16 12:32   ` [PATCH v2 7/7] Use elf_getshdrstrndx() instead of elf_getshstrndx() Daniel Kiper
     [not found]     ` <1373977929-4253-8-git-send-email-daniel.kiper-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
2013-07-18  8:03       ` Atsushi Kumagai
     [not found]         ` <20130718170322.ea01294e20c9cdc810b40eb9-biTfD1RFvDe45+QrQBaojngSJqDPrsil@public.gmane.org>
2013-07-18 12:52           ` Daniel Kiper

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1373977929-4253-3-git-send-email-daniel.kiper@oracle.com \
    --to=daniel.kiper-qhclzuegtsvqt0dzr+alfa@public.gmane.org \
    --cc=andrew.cooper3-Sxgqhf6Nn4DQT0dZR+AlfA@public.gmane.org \
    --cc=kexec-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
    --cc=kumagai-atsushi-biTfD1RFvDe45+QrQBaojngSJqDPrsil@public.gmane.org \
    --cc=xen-devel-GuqFBffKawuULHF6PoxzQEEOCMrvLtNR@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).