From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Kiper Subject: [PATCH v2 2/7] elf: Properly check buf size in get_pt_note_info() Date: Tue, 16 Jul 2013 14:32:04 +0200 Message-ID: <1373977929-4253-3-git-send-email-daniel.kiper@oracle.com> References: <1373977929-4253-1-git-send-email-daniel.kiper@oracle.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1373977929-4253-1-git-send-email-daniel.kiper-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "kexec" Errors-To: kexec-bounces+glkk-kexec=m.gmane.org-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org To: andrew.cooper3-Sxgqhf6Nn4DQT0dZR+AlfA@public.gmane.org, kumagai-atsushi-biTfD1RFvDe45+QrQBaojngSJqDPrsil@public.gmane.org, kexec-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, xen-devel-GuqFBffKawuULHF6PoxzQEEOCMrvLtNR@public.gmane.org Cc: Daniel Kiper List-Id: xen-devel@lists.xenproject.org get_pt_note_info() always ignores VMCOREINFO_XEN note because buf size must be smaller than note size including \0 char. Usualy this condition is true but when VMCOREINFO_XEN note is encountered it does not work due to buf size defined as sizeof("VMCOREINFO_XEN"). This patch fixes that bug and VMCOREINFO_XEN note living in /proc/vmcore file could be properly detected now. v2 - suggestions/fixes: - properly check buf size instead of increasing buf size (suggested by Andrew Cooper). Signed-off-by: Daniel Kiper --- elf_info.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/elf_info.c b/elf_info.c index 0c1e36a..e350b99 100644 --- a/elf_info.c +++ b/elf_info.c @@ -332,7 +332,7 @@ get_pt_note_info(void) size_desc = note_descsz(note); offset_desc = offset + offset_note_desc(note); - if (!size_name || size_name >= sizeof(buf)) + if (!size_name || size_name > sizeof(buf)) goto next_note; if (read(fd_memory, &buf, sizeof(buf)) != sizeof(buf)) { -- 1.7.10.4