From: Ian Campbell <ian.campbell@citrix.com>
To: xen-devel@lists.xen.org
Cc: keir@xen.org, Ian Campbell <ian.campbell@citrix.com>, jbeulich@suse.com
Subject: [PATCH] xen: x86: drop the ".gz" suffix when installing
Date: Wed, 17 Jul 2013 12:13:57 +0100 [thread overview]
Message-ID: <1374059637-7262-1-git-send-email-ian.campbell@citrix.com> (raw)
In-Reply-To: <51E52C9202000078000E5405@nat28.tlf.novell.com>
As Jan says it is pretty meaningless under /boot anyway. However I am slightly
concerned about breaking bootloaders (or more specifically their help scripts
which automatically generate config files). By inspection at leastr grub 2's
update-grub script (as present in Debian Wheezy) seems to cope (it matches on
xen* not xen*.gz)
Signed-off-by: Ian Campbell <ian.campbell@citrix.com>
Cc: jbeulich@suse.com
Cc: keir@xen.org
---
xen/Makefile | 16 ++++++++--------
1 files changed, 8 insertions(+), 8 deletions(-)
diff --git a/xen/Makefile b/xen/Makefile
index 343e789..ef8a1cd 100644
--- a/xen/Makefile
+++ b/xen/Makefile
@@ -37,10 +37,10 @@ _build: $(TARGET)$(Z)
.PHONY: _install
_install: $(TARGET)$(Z)
[ -d $(DESTDIR)/boot ] || $(INSTALL_DIR) $(DESTDIR)/boot
- $(INSTALL_DATA) $(TARGET)$(Z) $(DESTDIR)/boot/$(notdir $(TARGET))-$(XEN_FULLVERSION)$(Z)
- ln -f -s $(notdir $(TARGET))-$(XEN_FULLVERSION)$(Z) $(DESTDIR)/boot/$(notdir $(TARGET))-$(XEN_VERSION).$(XEN_SUBVERSION)$(Z)
- ln -f -s $(notdir $(TARGET))-$(XEN_FULLVERSION)$(Z) $(DESTDIR)/boot/$(notdir $(TARGET))-$(XEN_VERSION)$(Z)
- ln -f -s $(notdir $(TARGET))-$(XEN_FULLVERSION)$(Z) $(DESTDIR)/boot/$(notdir $(TARGET))$(Z)
+ $(INSTALL_DATA) $(TARGET)$(Z) $(DESTDIR)/boot/$(notdir $(TARGET))-$(XEN_FULLVERSION)
+ ln -f -s $(notdir $(TARGET))-$(XEN_FULLVERSION) $(DESTDIR)/boot/$(notdir $(TARGET))-$(XEN_VERSION).$(XEN_SUBVERSION)
+ ln -f -s $(notdir $(TARGET))-$(XEN_FULLVERSION) $(DESTDIR)/boot/$(notdir $(TARGET))-$(XEN_VERSION)
+ ln -f -s $(notdir $(TARGET))-$(XEN_FULLVERSION) $(DESTDIR)/boot/$(notdir $(TARGET))
$(INSTALL_DATA) $(TARGET)-syms $(DESTDIR)/boot/$(notdir $(TARGET))-syms-$(XEN_FULLVERSION)
if [ -r $(TARGET).efi -a -n '$(EFI_DIR)' ]; then \
[ -d $(DESTDIR)$(EFI_DIR) ] || $(INSTALL_DIR) $(DESTDIR)$(EFI_DIR); \
@@ -59,10 +59,10 @@ _install: $(TARGET)$(Z)
_uninstall: D=$(DESTDIR)
_uninstall: T=$(notdir $(TARGET))
_uninstall:
- rm -f $(D)/boot/$(T)-$(XEN_FULLVERSION)$(Z)
- rm -f $(D)/boot/$(T)-$(XEN_VERSION).$(XEN_SUBVERSION)$(Z)
- rm -f $(D)/boot/$(T)-$(XEN_VERSION)$(Z)
- rm -f $(D)/boot/$(T)$(Z)
+ rm -f $(D)/boot/$(T)-$(XEN_FULLVERSION)
+ rm -f $(D)/boot/$(T)-$(XEN_VERSION).$(XEN_SUBVERSION)
+ rm -f $(D)/boot/$(T)-$(XEN_VERSION)
+ rm -f $(D)/boot/$(T)
rm -f $(D)/boot/$(T)-syms-$(XEN_FULLVERSION)
rm -f $(D)$(EFI_DIR)/$(T)-$(XEN_FULLVERSION).efi
rm -f $(D)$(EFI_DIR)/$(T)-$(XEN_VERSION).$(XEN_SUBVERSION).efi
--
1.7.2.5
next prev parent reply other threads:[~2013-07-17 11:13 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-12 11:59 [PATCH] xen: arm: make zImage the default target which we install Ian Campbell
2013-07-15 8:38 ` [PATCH] xen: allow architecture to choose whether to compress installed xen binary Ian Campbell
2013-07-15 9:44 ` Jan Beulich
2013-07-16 9:15 ` Ian Campbell
2013-07-16 9:20 ` Jan Beulich
2013-07-17 11:13 ` Ian Campbell
2013-07-17 11:31 ` Jan Beulich
2013-07-17 11:37 ` Ian Campbell
2013-07-17 11:13 ` Ian Campbell [this message]
2013-07-17 11:26 ` [PATCH] xen: x86: drop the ".gz" suffix when installing Jan Beulich
2013-07-17 11:35 ` Ian Campbell
2013-07-18 12:05 ` [PATCH] xen: arm: make zImage the default target which we install Julien Grall
2013-07-18 12:10 ` Ian Campbell
2013-07-18 12:12 ` Julien Grall
2013-07-19 14:18 ` Ian Campbell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1374059637-7262-1-git-send-email-ian.campbell@citrix.com \
--to=ian.campbell@citrix.com \
--cc=jbeulich@suse.com \
--cc=keir@xen.org \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).