From: Ian Campbell <ian.campbell@citrix.com>
To: xen-devel@lists.xen.org
Cc: julien.grall@citrix.com, tim@xen.org,
Ian Campbell <ian.campbell@citrix.com>,
stefano.stabellini@eu.citrix.com
Subject: [PATCH] xen: arm: remove unnecessary cache flush in write_pte
Date: Wed, 17 Jul 2013 12:19:28 +0100 [thread overview]
Message-ID: <1374059968-7565-1-git-send-email-ian.campbell@citrix.com> (raw)
On a ARMv7/v8 SMP system the MMU is coherent
Suggested-by: Marc Zyngier <marc.zyngier@arm.com>
Signed-off-by: Ian Campbell <ian.campbell@citrix.com>
---
xen/include/asm-arm/arm32/page.h | 2 --
xen/include/asm-arm/arm64/page.h | 2 --
2 files changed, 0 insertions(+), 4 deletions(-)
diff --git a/xen/include/asm-arm/arm32/page.h b/xen/include/asm-arm/arm32/page.h
index 38bcffd..3a06a22 100644
--- a/xen/include/asm-arm/arm32/page.h
+++ b/xen/include/asm-arm/arm32/page.h
@@ -16,8 +16,6 @@ static inline void write_pte(lpae_t *p, lpae_t pte)
/* Safely write the entry (STRD is atomic on CPUs that support LPAE) */
"strd %0, %H0, [%1];"
"dsb;"
- /* Push this cacheline to the PoC so the rest of the system sees it. */
- STORE_CP32(1, DCCMVAC)
/* Ensure that the data flush is completed before proceeding */
"dsb;"
: : "r" (pte.bits), "r" (p) : "memory");
diff --git a/xen/include/asm-arm/arm64/page.h b/xen/include/asm-arm/arm64/page.h
index bd48fe3..542f886 100644
--- a/xen/include/asm-arm/arm64/page.h
+++ b/xen/include/asm-arm/arm64/page.h
@@ -11,8 +11,6 @@ static inline void write_pte(lpae_t *p, lpae_t pte)
"dsb sy;"
"str %0, [%1];" /* Write the entry */
"dsb sy;"
- /* Push this cacheline to the PoC so the rest of the system sees it. */
- "dc cvac, %1;"
/* Ensure that the data flush is completed before proceeding */
"dsb sy;"
: : "r" (pte.bits), "r" (p) : "memory");
--
1.7.2.5
next reply other threads:[~2013-07-17 11:19 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-17 11:19 Ian Campbell [this message]
2013-07-29 14:57 ` [PATCH] xen: arm: remove unnecessary cache flush in write_pte Ian Campbell
2013-07-29 15:12 ` Tim Deegan
2013-07-29 15:16 ` Ian Campbell
2013-07-29 15:58 ` Ian Campbell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1374059968-7565-1-git-send-email-ian.campbell@citrix.com \
--to=ian.campbell@citrix.com \
--cc=julien.grall@citrix.com \
--cc=stefano.stabellini@eu.citrix.com \
--cc=tim@xen.org \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).