From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ian Campbell Subject: [PATCH v2 1/3] xen: x86: drop the ".gz" suffix when installing Date: Thu, 18 Jul 2013 09:41:41 +0100 Message-ID: <1374136903-3620-1-git-send-email-ian.campbell@citrix.com> References: <1374136884.26728.46.camel@kazak.uk.xensource.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1374136884.26728.46.camel@kazak.uk.xensource.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: xen-devel@lists.xen.org Cc: keir@xen.org, Ian Campbell , stefano.stabellini@eu.citrix.com, tim@xen.org, julien.grall@citrix.com, jbeulich@suse.com List-Id: xen-devel@lists.xenproject.org As Jan says it is pretty meaningless under /boot anyway. However I am slightly concerned about breaking bootloaders (or more specifically their help scripts which automatically generate config files). By inspection at least grub 2's update-grub script (as present in Debian Wheezy) seems to cope (it matches on xen* not xen*.gz) Signed-off-by: Ian Campbell Acked-by: Keir Fraser Acked-by: Julien Grall Cc: jbeulich@suse.com --- v2: reordered in series to reduce unnecessary churn --- xen/Makefile | 16 ++++++++-------- 1 files changed, 8 insertions(+), 8 deletions(-) diff --git a/xen/Makefile b/xen/Makefile index 854a370..1106c26 100644 --- a/xen/Makefile +++ b/xen/Makefile @@ -34,10 +34,10 @@ _build: $(TARGET).gz .PHONY: _install _install: $(TARGET).gz [ -d $(DESTDIR)/boot ] || $(INSTALL_DIR) $(DESTDIR)/boot - $(INSTALL_DATA) $(TARGET).gz $(DESTDIR)/boot/$(notdir $(TARGET))-$(XEN_FULLVERSION).gz - ln -f -s $(notdir $(TARGET))-$(XEN_FULLVERSION).gz $(DESTDIR)/boot/$(notdir $(TARGET))-$(XEN_VERSION).$(XEN_SUBVERSION).gz - ln -f -s $(notdir $(TARGET))-$(XEN_FULLVERSION).gz $(DESTDIR)/boot/$(notdir $(TARGET))-$(XEN_VERSION).gz - ln -f -s $(notdir $(TARGET))-$(XEN_FULLVERSION).gz $(DESTDIR)/boot/$(notdir $(TARGET)).gz + $(INSTALL_DATA) $(TARGET).gz $(DESTDIR)/boot/$(notdir $(TARGET))-$(XEN_FULLVERSION) + ln -f -s $(notdir $(TARGET))-$(XEN_FULLVERSION) $(DESTDIR)/boot/$(notdir $(TARGET))-$(XEN_VERSION).$(XEN_SUBVERSION) + ln -f -s $(notdir $(TARGET))-$(XEN_FULLVERSION) $(DESTDIR)/boot/$(notdir $(TARGET))-$(XEN_VERSION) + ln -f -s $(notdir $(TARGET))-$(XEN_FULLVERSION) $(DESTDIR)/boot/$(notdir $(TARGET)) $(INSTALL_DATA) $(TARGET)-syms $(DESTDIR)/boot/$(notdir $(TARGET))-syms-$(XEN_FULLVERSION) if [ -r $(TARGET).efi -a -n '$(EFI_DIR)' ]; then \ [ -d $(DESTDIR)$(EFI_DIR) ] || $(INSTALL_DIR) $(DESTDIR)$(EFI_DIR); \ @@ -56,10 +56,10 @@ _install: $(TARGET).gz _uninstall: D=$(DESTDIR) _uninstall: T=$(notdir $(TARGET)) _uninstall: - rm -f $(D)/boot/$(T)-$(XEN_FULLVERSION).gz - rm -f $(D)/boot/$(T)-$(XEN_VERSION).$(XEN_SUBVERSION).gz - rm -f $(D)/boot/$(T)-$(XEN_VERSION).gz - rm -f $(D)/boot/$(T).gz + rm -f $(D)/boot/$(T)-$(XEN_FULLVERSION) + rm -f $(D)/boot/$(T)-$(XEN_VERSION).$(XEN_SUBVERSION) + rm -f $(D)/boot/$(T)-$(XEN_VERSION) + rm -f $(D)/boot/$(T) rm -f $(D)/boot/$(T)-syms-$(XEN_FULLVERSION) rm -f $(D)$(EFI_DIR)/$(T)-$(XEN_FULLVERSION).efi rm -f $(D)$(EFI_DIR)/$(T)-$(XEN_VERSION).$(XEN_SUBVERSION).efi -- 1.7.2.5