[PATCH] enable claim by default. (v2).

[PATCH] enable claim by default. (v2).

[Konrad Rzeszutek Wilk]

Greetings Ian and George,

During the Xen 4.3 release we briefly chatted about enabling the
claim by default. The reasoning is that he functionality here is
not just specific to tmem enabled guests. Any generic guest can benefit
from this and it allows the user to get up-to-date memory information on how
much free memory there really is - and how much is being
consumed for the guest creation. By default it is disabled.
This turns it on by default.

 docs/man/xl.conf.pod.5 |    2 +-
 tools/examples/xl.conf |    2 +-
 tools/libxl/xl.c       |    2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)

Konrad Rzeszutek Wilk (1):
      xl: Enable by default claim mode.

[PATCH] xl: Enable by default claim mode.

[Konrad Rzeszutek Wilk]

During the Xen 4.3 release we discussed that this feature could be
turned on by default - as it benefits all of the guests - not just
tmem related.

Signed-off-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
[v1: Enable by default in the code, not just in the config file]
---
 docs/man/xl.conf.pod.5 |    2 +-
 tools/examples/xl.conf |    2 +-
 tools/libxl/xl.c       |    2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/docs/man/xl.conf.pod.5 b/docs/man/xl.conf.pod.5
index 1229c8a..125f786 100644
--- a/docs/man/xl.conf.pod.5
+++ b/docs/man/xl.conf.pod.5
@@ -139,7 +139,7 @@ Xen hypervisor argument and as well on the Linux kernel command line.
 Note that the claim call is not attempted if C<superpages> option is
 used in the guest config (see xl.cfg(5)).
 
-Default: C<0>
+Default: C<1>
 
 =over 4
 
diff --git a/tools/examples/xl.conf b/tools/examples/xl.conf
index 9c037a6..d5a2384 100644
--- a/tools/examples/xl.conf
+++ b/tools/examples/xl.conf
@@ -31,5 +31,5 @@
 # Reserve a claim of memory when launching a guest. This guarantees immediate
 # feedback whether the guest can be launched due to memory exhaustion
 # (which can take a long time to find out if launching huge guests).
-# see xl.conf(5) for details.
+# see xl.conf(5) for details. By default it is enabled.
 #claim_mode=0
diff --git a/tools/libxl/xl.c b/tools/libxl/xl.c
index 1ce820c..0750f60 100644
--- a/tools/libxl/xl.c
+++ b/tools/libxl/xl.c
@@ -46,7 +46,7 @@ char *default_vifscript = NULL;
 char *default_bridge = NULL;
 char *default_gatewaydev = NULL;
 enum output_format default_output_format = OUTPUT_FORMAT_JSON;
-int claim_mode = 0;
+int claim_mode = 1;
 
 static xentoollog_level minmsglevel = XTL_PROGRESS;
 
-- 
1.7.7.6

Re: [PATCH] xl: Enable by default claim mode.

[Ian Campbell]

On Thu, 2013-07-18 at 22:43 -0400, Konrad Rzeszutek Wilk wrote:
> During the Xen 4.3 release we discussed that this feature could be
> turned on by default - as it benefits all of the guests - not just
> tmem related.
> 
> Signed-off-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
> [v1: Enable by default in the code, not just in the config file]
> ---
>  docs/man/xl.conf.pod.5 |    2 +-
>  tools/examples/xl.conf |    2 +-
>  tools/libxl/xl.c       |    2 +-
>  3 files changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/docs/man/xl.conf.pod.5 b/docs/man/xl.conf.pod.5
> index 1229c8a..125f786 100644
> --- a/docs/man/xl.conf.pod.5
> +++ b/docs/man/xl.conf.pod.5
> @@ -139,7 +139,7 @@ Xen hypervisor argument and as well on the Linux kernel command line.
>  Note that the claim call is not attempted if C<superpages> option is
>  used in the guest config (see xl.cfg(5)).
>  
> -Default: C<0>
> +Default: C<1>
>  
>  =over 4
>  
> diff --git a/tools/examples/xl.conf b/tools/examples/xl.conf
> index 9c037a6..d5a2384 100644
> --- a/tools/examples/xl.conf
> +++ b/tools/examples/xl.conf
> @@ -31,5 +31,5 @@
>  # Reserve a claim of memory when launching a guest. This guarantees immediate
>  # feedback whether the guest can be launched due to memory exhaustion
>  # (which can take a long time to find out if launching huge guests).
> -# see xl.conf(5) for details.
> +# see xl.conf(5) for details. By default it is enabled.
>  #claim_mode=0
 -#claim_mode=0
 +#claim_mode=1

Please.

IOW the commented out value should reflect the default. No need for the
additional words then either.


> diff --git a/tools/libxl/xl.c b/tools/libxl/xl.c
> index 1ce820c..0750f60 100644
> --- a/tools/libxl/xl.c
> +++ b/tools/libxl/xl.c
> @@ -46,7 +46,7 @@ char *default_vifscript = NULL;
>  char *default_bridge = NULL;
>  char *default_gatewaydev = NULL;
>  enum output_format default_output_format = OUTPUT_FORMAT_JSON;
> -int claim_mode = 0;
> +int claim_mode = 1;
>  
>  static xentoollog_level minmsglevel = XTL_PROGRESS;
>  

Re: [PATCH] xl: Enable by default claim mode.

[George Dunlap]

On Fri, Jul 19, 2013 at 10:17 AM, Ian Campbell <Ian.Campbell@citrix.com> wrote:
> On Thu, 2013-07-18 at 22:43 -0400, Konrad Rzeszutek Wilk wrote:
>> During the Xen 4.3 release we discussed that this feature could be
>> turned on by default - as it benefits all of the guests - not just
>> tmem related.
>>
>> Signed-off-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
>> [v1: Enable by default in the code, not just in the config file]
>> ---
>>  docs/man/xl.conf.pod.5 |    2 +-
>>  tools/examples/xl.conf |    2 +-
>>  tools/libxl/xl.c       |    2 +-
>>  3 files changed, 3 insertions(+), 3 deletions(-)
>>
>> diff --git a/docs/man/xl.conf.pod.5 b/docs/man/xl.conf.pod.5
>> index 1229c8a..125f786 100644
>> --- a/docs/man/xl.conf.pod.5
>> +++ b/docs/man/xl.conf.pod.5
>> @@ -139,7 +139,7 @@ Xen hypervisor argument and as well on the Linux kernel command line.
>>  Note that the claim call is not attempted if C<superpages> option is
>>  used in the guest config (see xl.cfg(5)).
>>
>> -Default: C<0>
>> +Default: C<1>
>>
>>  =over 4
>>
>> diff --git a/tools/examples/xl.conf b/tools/examples/xl.conf
>> index 9c037a6..d5a2384 100644
>> --- a/tools/examples/xl.conf
>> +++ b/tools/examples/xl.conf
>> @@ -31,5 +31,5 @@
>>  # Reserve a claim of memory when launching a guest. This guarantees immediate
>>  # feedback whether the guest can be launched due to memory exhaustion
>>  # (which can take a long time to find out if launching huge guests).
>> -# see xl.conf(5) for details.
>> +# see xl.conf(5) for details. By default it is enabled.
>>  #claim_mode=0
>  -#claim_mode=0
>  +#claim_mode=1
>
> Please.
>
> IOW the commented out value should reflect the default. No need for the
> additional words then either.

With that change:

Acked-by: George Dunlap <george.dunlap@eu.citrix.com>

Re: [PATCH] xl: Enable by default claim mode.

[Ian Jackson]

Konrad Rzeszutek Wilk writes ("[PATCH] xl: Enable by default claim mode."):
> During the Xen 4.3 release we discussed that this feature could be
> turned on by default - as it benefits all of the guests - not just
> tmem related.
> 
> Signed-off-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>

Never mind, here it is and I see it's been applied.

Thanks,
Ian.

Re: [PATCH] enable claim by default. (v2).

[Ian Jackson]

Konrad Rzeszutek Wilk writes ("[PATCH] enable claim by default. (v2)."):
> During the Xen 4.3 release we briefly chatted about enabling the
> claim by default. The reasoning is that he functionality here is
> not just specific to tmem enabled guests. Any generic guest can benefit
> from this and it allows the user to get up-to-date memory information on how
> much free memory there really is - and how much is being
> consumed for the guest creation. By default it is disabled.
> This turns it on by default.

I think this is a good idea.  However, your email didn't actually seem
to have the patch in it ?

Ian.