* [PATCH] xl: Enable by default claim mode.
2013-07-19 2:43 [PATCH] enable claim by default. (v2) Konrad Rzeszutek Wilk
@ 2013-07-19 2:43 ` Konrad Rzeszutek Wilk
2013-07-19 9:17 ` Ian Campbell
2013-08-07 10:38 ` Ian Jackson
0 siblings, 2 replies; 6+ messages in thread
From: Konrad Rzeszutek Wilk @ 2013-07-19 2:43 UTC (permalink / raw)
To: xen-devel, george.dunlap, ian.campbell, ian.jackson
During the Xen 4.3 release we discussed that this feature could be
turned on by default - as it benefits all of the guests - not just
tmem related.
Signed-off-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
[v1: Enable by default in the code, not just in the config file]
---
docs/man/xl.conf.pod.5 | 2 +-
tools/examples/xl.conf | 2 +-
tools/libxl/xl.c | 2 +-
3 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/docs/man/xl.conf.pod.5 b/docs/man/xl.conf.pod.5
index 1229c8a..125f786 100644
--- a/docs/man/xl.conf.pod.5
+++ b/docs/man/xl.conf.pod.5
@@ -139,7 +139,7 @@ Xen hypervisor argument and as well on the Linux kernel command line.
Note that the claim call is not attempted if C<superpages> option is
used in the guest config (see xl.cfg(5)).
-Default: C<0>
+Default: C<1>
=over 4
diff --git a/tools/examples/xl.conf b/tools/examples/xl.conf
index 9c037a6..d5a2384 100644
--- a/tools/examples/xl.conf
+++ b/tools/examples/xl.conf
@@ -31,5 +31,5 @@
# Reserve a claim of memory when launching a guest. This guarantees immediate
# feedback whether the guest can be launched due to memory exhaustion
# (which can take a long time to find out if launching huge guests).
-# see xl.conf(5) for details.
+# see xl.conf(5) for details. By default it is enabled.
#claim_mode=0
diff --git a/tools/libxl/xl.c b/tools/libxl/xl.c
index 1ce820c..0750f60 100644
--- a/tools/libxl/xl.c
+++ b/tools/libxl/xl.c
@@ -46,7 +46,7 @@ char *default_vifscript = NULL;
char *default_bridge = NULL;
char *default_gatewaydev = NULL;
enum output_format default_output_format = OUTPUT_FORMAT_JSON;
-int claim_mode = 0;
+int claim_mode = 1;
static xentoollog_level minmsglevel = XTL_PROGRESS;
--
1.7.7.6
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] xl: Enable by default claim mode.
2013-07-19 2:43 ` [PATCH] xl: Enable by default claim mode Konrad Rzeszutek Wilk
@ 2013-07-19 9:17 ` Ian Campbell
2013-07-19 15:32 ` George Dunlap
2013-08-07 10:38 ` Ian Jackson
1 sibling, 1 reply; 6+ messages in thread
From: Ian Campbell @ 2013-07-19 9:17 UTC (permalink / raw)
To: Konrad Rzeszutek Wilk; +Cc: george.dunlap, xen-devel, ian.jackson
On Thu, 2013-07-18 at 22:43 -0400, Konrad Rzeszutek Wilk wrote:
> During the Xen 4.3 release we discussed that this feature could be
> turned on by default - as it benefits all of the guests - not just
> tmem related.
>
> Signed-off-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
> [v1: Enable by default in the code, not just in the config file]
> ---
> docs/man/xl.conf.pod.5 | 2 +-
> tools/examples/xl.conf | 2 +-
> tools/libxl/xl.c | 2 +-
> 3 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/docs/man/xl.conf.pod.5 b/docs/man/xl.conf.pod.5
> index 1229c8a..125f786 100644
> --- a/docs/man/xl.conf.pod.5
> +++ b/docs/man/xl.conf.pod.5
> @@ -139,7 +139,7 @@ Xen hypervisor argument and as well on the Linux kernel command line.
> Note that the claim call is not attempted if C<superpages> option is
> used in the guest config (see xl.cfg(5)).
>
> -Default: C<0>
> +Default: C<1>
>
> =over 4
>
> diff --git a/tools/examples/xl.conf b/tools/examples/xl.conf
> index 9c037a6..d5a2384 100644
> --- a/tools/examples/xl.conf
> +++ b/tools/examples/xl.conf
> @@ -31,5 +31,5 @@
> # Reserve a claim of memory when launching a guest. This guarantees immediate
> # feedback whether the guest can be launched due to memory exhaustion
> # (which can take a long time to find out if launching huge guests).
> -# see xl.conf(5) for details.
> +# see xl.conf(5) for details. By default it is enabled.
> #claim_mode=0
-#claim_mode=0
+#claim_mode=1
Please.
IOW the commented out value should reflect the default. No need for the
additional words then either.
> diff --git a/tools/libxl/xl.c b/tools/libxl/xl.c
> index 1ce820c..0750f60 100644
> --- a/tools/libxl/xl.c
> +++ b/tools/libxl/xl.c
> @@ -46,7 +46,7 @@ char *default_vifscript = NULL;
> char *default_bridge = NULL;
> char *default_gatewaydev = NULL;
> enum output_format default_output_format = OUTPUT_FORMAT_JSON;
> -int claim_mode = 0;
> +int claim_mode = 1;
>
> static xentoollog_level minmsglevel = XTL_PROGRESS;
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH] xl: Enable by default claim mode.
@ 2013-07-19 15:31 Konrad Rzeszutek Wilk
2013-07-22 21:39 ` Ian Campbell
0 siblings, 1 reply; 6+ messages in thread
From: Konrad Rzeszutek Wilk @ 2013-07-19 15:31 UTC (permalink / raw)
To: Ian.Campbell, xen-devel, George.Dunlap
During the Xen 4.3 release we discussed that this feature could be
turned on by default - as it benefits all of the guests - not just
tmem related.
Signed-off-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
[v1: Enable by default in the code, not just in the config file]
[v2: Reflect the default value in the config file]
Acked-by: George Dunlap <george.dunlap@eu.citrix.com>
---
docs/man/xl.conf.pod.5 | 2 +-
tools/examples/xl.conf | 2 +-
tools/libxl/xl.c | 2 +-
3 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/docs/man/xl.conf.pod.5 b/docs/man/xl.conf.pod.5
index 1229c8a..125f786 100644
--- a/docs/man/xl.conf.pod.5
+++ b/docs/man/xl.conf.pod.5
@@ -139,7 +139,7 @@ Xen hypervisor argument and as well on the Linux kernel command line.
Note that the claim call is not attempted if C<superpages> option is
used in the guest config (see xl.cfg(5)).
-Default: C<0>
+Default: C<1>
=over 4
diff --git a/tools/examples/xl.conf b/tools/examples/xl.conf
index 9c037a6..12ea737 100644
--- a/tools/examples/xl.conf
+++ b/tools/examples/xl.conf
@@ -32,4 +32,4 @@
# feedback whether the guest can be launched due to memory exhaustion
# (which can take a long time to find out if launching huge guests).
# see xl.conf(5) for details.
-#claim_mode=0
+#claim_mode=1
diff --git a/tools/libxl/xl.c b/tools/libxl/xl.c
index 1ce820c..0750f60 100644
--- a/tools/libxl/xl.c
+++ b/tools/libxl/xl.c
@@ -46,7 +46,7 @@ char *default_vifscript = NULL;
char *default_bridge = NULL;
char *default_gatewaydev = NULL;
enum output_format default_output_format = OUTPUT_FORMAT_JSON;
-int claim_mode = 0;
+int claim_mode = 1;
static xentoollog_level minmsglevel = XTL_PROGRESS;
--
1.7.7.6
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] xl: Enable by default claim mode.
2013-07-19 9:17 ` Ian Campbell
@ 2013-07-19 15:32 ` George Dunlap
0 siblings, 0 replies; 6+ messages in thread
From: George Dunlap @ 2013-07-19 15:32 UTC (permalink / raw)
To: Ian Campbell
Cc: Konrad Rzeszutek Wilk, xen-devel@lists.xensource.com, Ian Jackson
On Fri, Jul 19, 2013 at 10:17 AM, Ian Campbell <Ian.Campbell@citrix.com> wrote:
> On Thu, 2013-07-18 at 22:43 -0400, Konrad Rzeszutek Wilk wrote:
>> During the Xen 4.3 release we discussed that this feature could be
>> turned on by default - as it benefits all of the guests - not just
>> tmem related.
>>
>> Signed-off-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
>> [v1: Enable by default in the code, not just in the config file]
>> ---
>> docs/man/xl.conf.pod.5 | 2 +-
>> tools/examples/xl.conf | 2 +-
>> tools/libxl/xl.c | 2 +-
>> 3 files changed, 3 insertions(+), 3 deletions(-)
>>
>> diff --git a/docs/man/xl.conf.pod.5 b/docs/man/xl.conf.pod.5
>> index 1229c8a..125f786 100644
>> --- a/docs/man/xl.conf.pod.5
>> +++ b/docs/man/xl.conf.pod.5
>> @@ -139,7 +139,7 @@ Xen hypervisor argument and as well on the Linux kernel command line.
>> Note that the claim call is not attempted if C<superpages> option is
>> used in the guest config (see xl.cfg(5)).
>>
>> -Default: C<0>
>> +Default: C<1>
>>
>> =over 4
>>
>> diff --git a/tools/examples/xl.conf b/tools/examples/xl.conf
>> index 9c037a6..d5a2384 100644
>> --- a/tools/examples/xl.conf
>> +++ b/tools/examples/xl.conf
>> @@ -31,5 +31,5 @@
>> # Reserve a claim of memory when launching a guest. This guarantees immediate
>> # feedback whether the guest can be launched due to memory exhaustion
>> # (which can take a long time to find out if launching huge guests).
>> -# see xl.conf(5) for details.
>> +# see xl.conf(5) for details. By default it is enabled.
>> #claim_mode=0
> -#claim_mode=0
> +#claim_mode=1
>
> Please.
>
> IOW the commented out value should reflect the default. No need for the
> additional words then either.
With that change:
Acked-by: George Dunlap <george.dunlap@eu.citrix.com>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] xl: Enable by default claim mode.
2013-07-19 15:31 [PATCH] xl: Enable by default claim mode Konrad Rzeszutek Wilk
@ 2013-07-22 21:39 ` Ian Campbell
0 siblings, 0 replies; 6+ messages in thread
From: Ian Campbell @ 2013-07-22 21:39 UTC (permalink / raw)
To: Konrad Rzeszutek Wilk; +Cc: George.Dunlap, xen-devel
On Fri, 2013-07-19 at 11:31 -0400, Konrad Rzeszutek Wilk wrote:
> During the Xen 4.3 release we discussed that this feature could be
> turned on by default - as it benefits all of the guests - not just
> tmem related.
>
> Signed-off-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
> [v1: Enable by default in the code, not just in the config file]
> [v2: Reflect the default value in the config file]
> Acked-by: George Dunlap <george.dunlap@eu.citrix.com>
I inferred this one was v3 and therefore the correct on to apply so:
acked + applied.
Ian
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] xl: Enable by default claim mode.
2013-07-19 2:43 ` [PATCH] xl: Enable by default claim mode Konrad Rzeszutek Wilk
2013-07-19 9:17 ` Ian Campbell
@ 2013-08-07 10:38 ` Ian Jackson
1 sibling, 0 replies; 6+ messages in thread
From: Ian Jackson @ 2013-08-07 10:38 UTC (permalink / raw)
To: Konrad Rzeszutek Wilk; +Cc: george.dunlap, xen-devel, ian.campbell
Konrad Rzeszutek Wilk writes ("[PATCH] xl: Enable by default claim mode."):
> During the Xen 4.3 release we discussed that this feature could be
> turned on by default - as it benefits all of the guests - not just
> tmem related.
>
> Signed-off-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Never mind, here it is and I see it's been applied.
Thanks,
Ian.
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2013-08-07 10:38 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-07-19 15:31 [PATCH] xl: Enable by default claim mode Konrad Rzeszutek Wilk
2013-07-22 21:39 ` Ian Campbell
-- strict thread matches above, loose matches on Subject: below --
2013-07-19 2:43 [PATCH] enable claim by default. (v2) Konrad Rzeszutek Wilk
2013-07-19 2:43 ` [PATCH] xl: Enable by default claim mode Konrad Rzeszutek Wilk
2013-07-19 9:17 ` Ian Campbell
2013-07-19 15:32 ` George Dunlap
2013-08-07 10:38 ` Ian Jackson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).