From: Mukesh Rathor <mukesh.rathor@oracle.com>
To: Xen-devel@lists.xensource.com, keir.xen@gmail.com
Subject: [V10 PATCH 07/23] PVH xen: vmcs related preparatory changes for PVH
Date: Tue, 23 Jul 2013 18:59:15 -0700 [thread overview]
Message-ID: <1374631171-15224-8-git-send-email-mukesh.rathor@oracle.com> (raw)
In-Reply-To: <1374631171-15224-1-git-send-email-mukesh.rathor@oracle.com>
In this patch, some common code is factored out of construct_vmcs() to create
vmx_set_common_host_vmcs_fields() to be used by PVH.
Signed-off-by: Mukesh Rathor <mukesh.rathor@oracle.com>
Acked-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Reviewed-by: Jan Beulich <jbeulich@suse.com>
---
xen/arch/x86/hvm/vmx/vmcs.c | 58 +++++++++++++++++++++++-------------------
1 files changed, 32 insertions(+), 26 deletions(-)
diff --git a/xen/arch/x86/hvm/vmx/vmcs.c b/xen/arch/x86/hvm/vmx/vmcs.c
index de9f592..36f167f 100644
--- a/xen/arch/x86/hvm/vmx/vmcs.c
+++ b/xen/arch/x86/hvm/vmx/vmcs.c
@@ -825,11 +825,40 @@ void virtual_vmcs_vmwrite(void *vvmcs, u32 vmcs_encoding, u64 val)
virtual_vmcs_exit(vvmcs);
}
-static int construct_vmcs(struct vcpu *v)
+static void vmx_set_common_host_vmcs_fields(struct vcpu *v)
{
- struct domain *d = v->domain;
uint16_t sysenter_cs;
unsigned long sysenter_eip;
+
+ /* Host data selectors. */
+ __vmwrite(HOST_SS_SELECTOR, __HYPERVISOR_DS);
+ __vmwrite(HOST_DS_SELECTOR, __HYPERVISOR_DS);
+ __vmwrite(HOST_ES_SELECTOR, __HYPERVISOR_DS);
+ __vmwrite(HOST_FS_SELECTOR, 0);
+ __vmwrite(HOST_GS_SELECTOR, 0);
+ __vmwrite(HOST_FS_BASE, 0);
+ __vmwrite(HOST_GS_BASE, 0);
+
+ /* Host control registers. */
+ v->arch.hvm_vmx.host_cr0 = read_cr0() | X86_CR0_TS;
+ __vmwrite(HOST_CR0, v->arch.hvm_vmx.host_cr0);
+ __vmwrite(HOST_CR4,
+ mmu_cr4_features | (xsave_enabled(v) ? X86_CR4_OSXSAVE : 0));
+
+ /* Host CS:RIP. */
+ __vmwrite(HOST_CS_SELECTOR, __HYPERVISOR_CS);
+ __vmwrite(HOST_RIP, (unsigned long)vmx_asm_vmexit_handler);
+
+ /* Host SYSENTER CS:RIP. */
+ rdmsrl(MSR_IA32_SYSENTER_CS, sysenter_cs);
+ __vmwrite(HOST_SYSENTER_CS, sysenter_cs);
+ rdmsrl(MSR_IA32_SYSENTER_EIP, sysenter_eip);
+ __vmwrite(HOST_SYSENTER_EIP, sysenter_eip);
+}
+
+static int construct_vmcs(struct vcpu *v)
+{
+ struct domain *d = v->domain;
u32 vmexit_ctl = vmx_vmexit_control;
u32 vmentry_ctl = vmx_vmentry_control;
@@ -932,30 +961,7 @@ static int construct_vmcs(struct vcpu *v)
__vmwrite(POSTED_INTR_NOTIFICATION_VECTOR, posted_intr_vector);
}
- /* Host data selectors. */
- __vmwrite(HOST_SS_SELECTOR, __HYPERVISOR_DS);
- __vmwrite(HOST_DS_SELECTOR, __HYPERVISOR_DS);
- __vmwrite(HOST_ES_SELECTOR, __HYPERVISOR_DS);
- __vmwrite(HOST_FS_SELECTOR, 0);
- __vmwrite(HOST_GS_SELECTOR, 0);
- __vmwrite(HOST_FS_BASE, 0);
- __vmwrite(HOST_GS_BASE, 0);
-
- /* Host control registers. */
- v->arch.hvm_vmx.host_cr0 = read_cr0() | X86_CR0_TS;
- __vmwrite(HOST_CR0, v->arch.hvm_vmx.host_cr0);
- __vmwrite(HOST_CR4,
- mmu_cr4_features | (xsave_enabled(v) ? X86_CR4_OSXSAVE : 0));
-
- /* Host CS:RIP. */
- __vmwrite(HOST_CS_SELECTOR, __HYPERVISOR_CS);
- __vmwrite(HOST_RIP, (unsigned long)vmx_asm_vmexit_handler);
-
- /* Host SYSENTER CS:RIP. */
- rdmsrl(MSR_IA32_SYSENTER_CS, sysenter_cs);
- __vmwrite(HOST_SYSENTER_CS, sysenter_cs);
- rdmsrl(MSR_IA32_SYSENTER_EIP, sysenter_eip);
- __vmwrite(HOST_SYSENTER_EIP, sysenter_eip);
+ vmx_set_common_host_vmcs_fields(v);
/* MSR intercepts. */
__vmwrite(VM_EXIT_MSR_LOAD_COUNT, 0);
--
1.7.2.3
next prev parent reply other threads:[~2013-07-24 1:59 UTC|newest]
Thread overview: 174+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-24 1:59 [V10 PATCH 00/23]PVH xen: Phase I, Version 10 patches Mukesh Rathor
2013-07-24 1:59 ` [V10 PATCH 01/23] PVH xen: Add readme docs/misc/pvh-readme.txt Mukesh Rathor
2013-08-16 10:18 ` George Dunlap
2013-08-16 13:17 ` George Dunlap
2013-08-16 14:11 ` Konrad Rzeszutek Wilk
2013-08-16 21:39 ` Mukesh Rathor
2013-07-24 1:59 ` [V10 PATCH 02/23] PVH xen: turn gdb_frames/gdt_ents into union Mukesh Rathor
2013-07-24 1:59 ` [V10 PATCH 03/23] PVH xen: add params to read_segment_register Mukesh Rathor
2013-07-24 1:59 ` [V10 PATCH 04/23] PVH xen: Move e820 fields out of pv_domain struct Mukesh Rathor
2013-07-24 11:29 ` Andrew Cooper
2013-07-24 1:59 ` [V10 PATCH 05/23] PVH xen: hvm related preparatory changes for PVH Mukesh Rathor
2013-07-24 1:59 ` [V10 PATCH 06/23] PVH xen: vmx " Mukesh Rathor
2013-07-24 1:59 ` Mukesh Rathor [this message]
2013-07-24 1:59 ` [V10 PATCH 08/23] PVH xen: Introduce PVH guest type and some basic changes Mukesh Rathor
2013-08-06 11:29 ` George Dunlap
2013-08-06 11:47 ` Jan Beulich
2013-08-06 12:06 ` George Dunlap
2013-08-06 23:26 ` Mukesh Rathor
2013-08-07 7:14 ` Jan Beulich
2013-08-07 9:14 ` George Dunlap
2013-08-07 13:10 ` George Dunlap
2013-08-07 22:37 ` Mukesh Rathor
2013-08-08 8:57 ` George Dunlap
2013-07-24 1:59 ` [V10 PATCH 09/23] PVH xen: introduce pvh_set_vcpu_info() and vmx_pvh_set_vcpu_info() Mukesh Rathor
2013-07-25 13:47 ` Tim Deegan
2013-07-26 0:58 ` Mukesh Rathor
2013-07-26 10:29 ` Tim Deegan
2013-08-05 11:08 ` Jan Beulich
2013-08-06 1:34 ` Mukesh Rathor
2013-08-07 1:53 ` Mukesh Rathor
2013-08-07 6:34 ` Jan Beulich
2013-08-07 10:01 ` Tim Deegan
2013-08-07 10:07 ` Ian Campbell
2013-08-08 1:27 ` Mukesh Rathor
2013-08-05 11:03 ` Jan Beulich
2013-08-05 11:10 ` Jan Beulich
2013-08-08 1:05 ` Mukesh Rathor
2013-08-08 6:56 ` Jan Beulich
2013-08-08 22:07 ` Mukesh Rathor
2013-08-09 23:41 ` Mukesh Rathor
2013-08-12 7:54 ` Jan Beulich
2013-08-12 10:24 ` Tim Deegan
2013-08-12 11:04 ` Jan Beulich
2013-08-12 11:53 ` Tim Deegan
2013-08-12 13:24 ` Jan Beulich
2013-08-13 0:28 ` Mukesh Rathor
2013-08-13 0:27 ` Mukesh Rathor
2013-08-13 10:49 ` Jan Beulich
2013-08-14 2:21 ` Mukesh Rathor
2013-08-12 9:00 ` Tim Deegan
2013-08-13 0:02 ` Mukesh Rathor
2013-08-13 8:51 ` Tim Deegan
2013-07-24 1:59 ` [V10 PATCH 10/23] PVH xen: domain create, context switch related code changes Mukesh Rathor
2013-07-25 14:01 ` Tim Deegan
2013-07-26 1:02 ` Mukesh Rathor
2013-08-05 11:16 ` Jan Beulich
2013-08-07 10:24 ` George Dunlap
2013-08-08 1:40 ` Mukesh Rathor
2013-08-08 7:29 ` Jan Beulich
2013-08-08 9:02 ` George Dunlap
2013-08-08 9:08 ` Jan Beulich
2013-08-09 0:12 ` Mukesh Rathor
2013-08-07 10:48 ` George Dunlap
2013-08-08 1:42 ` Mukesh Rathor
2013-08-08 9:14 ` George Dunlap
2013-08-16 15:32 ` George Dunlap
2013-08-16 16:11 ` Jan Beulich
2013-08-20 0:52 ` Mukesh Rathor
2013-08-20 9:29 ` George Dunlap
2013-08-22 23:24 ` Mukesh Rathor
2013-07-24 1:59 ` [V10 PATCH 11/23] PVH xen: support invalid op emulation for PVH Mukesh Rathor
2013-08-07 11:29 ` George Dunlap
2013-08-08 1:49 ` Mukesh Rathor
2013-08-08 8:55 ` George Dunlap
2013-08-09 0:17 ` Mukesh Rathor
2013-08-10 2:13 ` Mukesh Rathor
2013-08-12 7:38 ` Jan Beulich
2013-08-14 1:13 ` Mukesh Rathor
2013-08-12 9:35 ` George Dunlap
2013-07-24 1:59 ` [V10 PATCH 12/23] PVH xen: Support privileged " Mukesh Rathor
2013-08-07 13:49 ` George Dunlap
2013-08-07 14:23 ` Jan Beulich
2013-08-07 14:47 ` George Dunlap
2013-08-08 1:59 ` Mukesh Rathor
2013-08-08 7:35 ` Jan Beulich
2013-08-08 14:21 ` George Dunlap
2013-08-08 14:18 ` George Dunlap
2013-08-08 14:36 ` George Dunlap
2013-08-09 1:32 ` Mukesh Rathor
2013-08-09 6:54 ` Jan Beulich
2013-08-09 18:10 ` Konrad Rzeszutek Wilk
2013-08-09 21:15 ` Keir Fraser
2013-08-12 9:43 ` George Dunlap
2013-07-24 1:59 ` [V10 PATCH 13/23] PVH xen: interrupt/event-channel delivery to PVH Mukesh Rathor
2013-08-07 15:37 ` George Dunlap
2013-08-08 2:05 ` Mukesh Rathor
2013-07-24 1:59 ` [V10 PATCH 14/23] PVH xen: additional changes to support PVH guest creation and execution Mukesh Rathor
2013-08-07 15:50 ` George Dunlap
2013-08-08 8:21 ` Ian Campbell
2013-08-20 14:13 ` George Dunlap
2013-08-20 21:32 ` Mukesh Rathor
2013-08-21 8:37 ` George Dunlap
2013-08-22 23:27 ` Mukesh Rathor
2013-07-24 1:59 ` [V10 PATCH 15/23] PVH xen: mapcache and show registers Mukesh Rathor
2013-07-24 1:59 ` [V10 PATCH 16/23] PVH xen: mtrr, tsc, timers, grant changes Mukesh Rathor
2013-08-07 16:04 ` George Dunlap
2013-07-24 1:59 ` [V10 PATCH 17/23] PVH xen: Checks, asserts, and limitations for PVH Mukesh Rathor
2013-07-24 1:59 ` [V10 PATCH 18/23] PVH xen: add hypercall support " Mukesh Rathor
2013-08-07 16:43 ` George Dunlap
2013-08-08 2:12 ` Mukesh Rathor
2013-08-08 7:41 ` Jan Beulich
2013-08-08 8:26 ` Ian Campbell
2013-08-09 0:55 ` Mukesh Rathor
2013-08-09 6:56 ` Jan Beulich
2013-08-08 9:20 ` George Dunlap
2013-08-08 10:18 ` Jan Beulich
2013-08-20 21:41 ` Mukesh Rathor
2013-07-24 1:59 ` [V10 PATCH 19/23] PVH xen: vmcs related changes Mukesh Rathor
2013-08-09 10:25 ` George Dunlap
2013-08-10 0:23 ` Mukesh Rathor
2013-08-12 7:42 ` Jan Beulich
2013-08-12 10:15 ` George Dunlap
2013-08-12 10:17 ` George Dunlap
2013-08-12 11:22 ` George Dunlap
2013-08-12 11:25 ` George Dunlap
2013-08-12 13:53 ` Jan Beulich
2013-08-09 13:39 ` George Dunlap
2013-08-10 0:20 ` Mukesh Rathor
2013-08-19 16:00 ` George Dunlap
2013-08-19 16:03 ` George Dunlap
2013-08-19 22:38 ` Mukesh Rathor
2013-08-19 22:21 ` Mukesh Rathor
2013-08-20 14:27 ` George Dunlap
2013-08-20 22:48 ` Mukesh Rathor
2013-07-24 1:59 ` [V10 PATCH 20/23] PVH xen: HVM support of PVH guest creation/destruction Mukesh Rathor
2013-07-24 1:59 ` [V10 PATCH 21/23] PVH xen: VMX " Mukesh Rathor
2013-08-05 11:25 ` Jan Beulich
2013-08-09 13:44 ` George Dunlap
2013-08-10 1:59 ` Mukesh Rathor
2013-08-12 10:23 ` George Dunlap
2013-07-24 1:59 ` [V10 PATCH 22/23] PVH xen: preparatory patch for the pvh vmexit handler patch Mukesh Rathor
2013-08-09 14:14 ` George Dunlap
2013-08-09 14:44 ` Konrad Rzeszutek Wilk
2013-08-09 14:47 ` George Dunlap
2013-07-24 1:59 ` [V10 PATCH 23/23] PVH xen: introduce vmexit handler for PVH Mukesh Rathor
2013-07-25 16:28 ` Tim Deegan
2013-07-26 2:30 ` Mukesh Rathor
2013-07-26 10:45 ` Tim Deegan
2013-08-07 0:37 ` Mukesh Rathor
2013-08-07 9:54 ` Tim Deegan
2013-08-15 15:51 ` George Dunlap
2013-08-15 16:37 ` Tim Deegan
2013-08-15 16:44 ` George Dunlap
2013-08-05 11:37 ` Jan Beulich
2013-08-12 16:00 ` George Dunlap
2013-08-12 16:13 ` George Dunlap
2013-08-12 17:30 ` George Dunlap
2013-08-22 1:44 ` Mukesh Rathor
2013-08-22 23:22 ` Mukesh Rathor
2013-08-23 7:16 ` Jan Beulich
2013-08-23 22:51 ` Mukesh Rathor
2013-08-26 8:09 ` Jan Beulich
2013-08-12 16:21 ` George Dunlap
2013-08-22 1:46 ` Mukesh Rathor
2013-07-24 6:21 ` [V10 PATCH 00/23]PVH xen: Phase I, Version 10 patches Keir Fraser
2013-07-24 12:24 ` Andrew Cooper
2013-07-24 15:04 ` Konrad Rzeszutek Wilk
2013-07-24 20:25 ` Keir Fraser
2013-07-25 1:07 ` Mukesh Rathor
2013-07-27 1:05 ` Mukesh Rathor
2013-08-05 11:13 ` Jan Beulich
2013-07-25 16:39 ` Tim Deegan
2013-07-26 18:55 ` Mukesh Rathor
2013-07-27 0:59 ` Mukesh Rathor
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1374631171-15224-8-git-send-email-mukesh.rathor@oracle.com \
--to=mukesh.rathor@oracle.com \
--cc=Xen-devel@lists.xensource.com \
--cc=keir.xen@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).