From: David Vrabel <david.vrabel@citrix.com>
To: xen-devel@lists.xen.org
Cc: Boris Ostrovsky <boris.ostrovsky@oracle.com>,
Wei Liu <wei.liu2@citrix.com>,
David Vrabel <david.vrabel@citrix.com>
Subject: [PATCH 01/12] xen/events: refactor retrigger_dynirq() and resend_irq_on_evtchn()
Date: Fri, 9 Aug 2013 19:15:10 +0100 [thread overview]
Message-ID: <1376072121-17786-2-git-send-email-david.vrabel@citrix.com> (raw)
In-Reply-To: <1376072121-17786-1-git-send-email-david.vrabel@citrix.com>
From: David Vrabel <david.vrabel@citrix.com>
These two function did the same thing with different parameters, put
the common bits in retrigger_evtchn().
Signed-off-by: David Vrabel <david.vrabel@citrix.com>
---
drivers/xen/events.c | 27 +++++++++------------------
1 files changed, 9 insertions(+), 18 deletions(-)
diff --git a/drivers/xen/events.c b/drivers/xen/events.c
index a58ac43..1697cf2 100644
--- a/drivers/xen/events.c
+++ b/drivers/xen/events.c
@@ -1529,13 +1529,13 @@ static int set_affinity_irq(struct irq_data *data, const struct cpumask *dest,
return rebind_irq_to_cpu(data->irq, tcpu);
}
-int resend_irq_on_evtchn(unsigned int irq)
+static int retrigger_evtchn(int evtchn)
{
- int masked, evtchn = evtchn_from_irq(irq);
+ int masked;
struct shared_info *s = HYPERVISOR_shared_info;
if (!VALID_EVTCHN(evtchn))
- return 1;
+ return 0;
masked = sync_test_and_set_bit(evtchn, BM(s->evtchn_mask));
sync_set_bit(evtchn, BM(s->evtchn_pending));
@@ -1545,6 +1545,11 @@ int resend_irq_on_evtchn(unsigned int irq)
return 1;
}
+int resend_irq_on_evtchn(unsigned int irq)
+{
+ return retrigger_evtchn(evtchn_from_irq(irq));
+}
+
static void enable_dynirq(struct irq_data *data)
{
int evtchn = evtchn_from_irq(data->irq);
@@ -1579,21 +1584,7 @@ static void mask_ack_dynirq(struct irq_data *data)
static int retrigger_dynirq(struct irq_data *data)
{
- int evtchn = evtchn_from_irq(data->irq);
- struct shared_info *sh = HYPERVISOR_shared_info;
- int ret = 0;
-
- if (VALID_EVTCHN(evtchn)) {
- int masked;
-
- masked = sync_test_and_set_bit(evtchn, BM(sh->evtchn_mask));
- sync_set_bit(evtchn, BM(sh->evtchn_pending));
- if (!masked)
- unmask_evtchn(evtchn);
- ret = 1;
- }
-
- return ret;
+ return retrigger_evtchn(evtchn_from_irq(data->irq));
}
static void restore_pirqs(void)
--
1.7.2.5
next prev parent reply other threads:[~2013-08-09 18:15 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-09 18:15 [RFC PATCHv2 00/12] Linux: FIFO-based event channel ABI David Vrabel
2013-08-09 18:15 ` David Vrabel [this message]
2013-08-16 17:46 ` [PATCH 01/12] xen/events: refactor retrigger_dynirq() and resend_irq_on_evtchn() Wei Liu
2013-09-05 17:28 ` David Vrabel
2013-08-09 18:15 ` [PATCH 02/12] xen/events: remove unnecessary init_evtchn_cpu_bindings() David Vrabel
2013-08-09 18:15 ` [PATCH 03/12] xen/events: introduce test_and_set_mask David Vrabel
2013-08-09 18:15 ` [PATCH 04/12] xen/events: replace raw bit ops with functions David Vrabel
2013-08-09 18:15 ` [PATCH 05/12] xen/events: move drivers/xen/events.c into drivers/xen/events/ David Vrabel
2013-08-09 18:15 ` [PATCH 06/12] xen/events: move 2-level specific code into its own file David Vrabel
2013-08-09 18:15 ` [PATCH 07/12] xen/events: add struct evtchn_ops for the low-level port operations David Vrabel
2013-08-16 17:47 ` Wei Liu
2013-08-19 10:39 ` David Vrabel
2013-08-19 10:52 ` Wei Liu
2013-08-09 18:15 ` [PATCH 08/12] xen/events: allow setup of irq_info to fail David Vrabel
2013-08-09 18:15 ` [PATCH 09/12] xen/events: add a evtchn_op for port setup David Vrabel
2013-08-09 18:15 ` [PATCH 10/12] xen/events: Refactor evtchn_to_irq array to be dynamically allocated David Vrabel
2013-08-09 18:15 ` [PATCH 11/12] xen/events: Add the hypervisor interface for the FIFO-based event channels David Vrabel
2013-08-09 18:15 ` [PATCH 12/12] xen/events: use the FIFO-based ABI if available David Vrabel
2013-08-16 17:47 ` Wei Liu
2013-08-19 11:55 ` David Vrabel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1376072121-17786-2-git-send-email-david.vrabel@citrix.com \
--to=david.vrabel@citrix.com \
--cc=boris.ostrovsky@oracle.com \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).