xen-devel.lists.xenproject.org archive mirror
 help / color / mirror / Atom feed
From: Ian Campbell <ian.campbell@citrix.com>
To: Bob Proulx <bob@proulx.com>
Cc: xen-devel@lists.xen.org
Subject: Re: [PATCH] vif-bridge: fix cut behavior change
Date: Tue, 13 Aug 2013 21:21:57 +0100	[thread overview]
Message-ID: <1376425317.9273.22.camel@hastur.hellion.org.uk> (raw)
In-Reply-To: <1376032699-9869-1-git-send-email-bob@proulx.com>

On Fri, 2013-08-09 at 01:18 -0600, Bob Proulx wrote:
> A recent change in GNU cut disallows use of a newline as a field
> delimiter.  Avoid the problematic use of cut in vif-bridge.
> 
> Signed-off-by: Bob Proulx <bob@proulx.com>

Acked-by: Ian Campbell <ian.campbell@citrix.com>

Both of the committers who generally deal with toolside stuff are away
(at debconf) at the moment, but this is on my list to deal with when I
get back.

Cheers,
Ian.

> ---
>  tools/hotplug/Linux/vif-bridge | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/tools/hotplug/Linux/vif-bridge b/tools/hotplug/Linux/vif-bridge
> index f489519..9a6f82a 100644
> --- a/tools/hotplug/Linux/vif-bridge
> +++ b/tools/hotplug/Linux/vif-bridge
> @@ -37,8 +37,7 @@ bridge=$(xenstore_read_default "$XENBUS_PATH/bridge" "$bridge")
>  
>  if [ -z "$bridge" ]
>  then
> -  bridge=$(brctl show | cut -d "
> -" -f 2 | cut -f 1)
> +  bridge=$(brctl show | awk 'NR==2{print$1}')
>  
>    if [ -z "$bridge" ]
>    then

  reply	other threads:[~2013-08-13 20:21 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-08-09  7:18 [PATCH] vif-bridge: fix cut behavior change Bob Proulx
2013-08-13 20:21 ` Ian Campbell [this message]
2013-08-20 15:04   ` Ian Campbell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1376425317.9273.22.camel@hastur.hellion.org.uk \
    --to=ian.campbell@citrix.com \
    --cc=bob@proulx.com \
    --cc=xen-devel@lists.xen.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).