From: Julien Grall <julien.grall@linaro.org>
To: stefano.stabellini@eu.citrix.com, ian.campbell@citrix.com
Cc: xen-devel@lists.xen.org, Julien Grall <julien.grall@linaro.org>,
andre.przywara@linaro.org, patches@linaro.org
Subject: [RFC 15/24] xen/arm: Use dt_device_match to avoid multiple if conditions
Date: Fri, 16 Aug 2013 22:05:47 +0100 [thread overview]
Message-ID: <1376687156-6737-16-git-send-email-julien.grall@linaro.org> (raw)
In-Reply-To: <1376687156-6737-1-git-send-email-julien.grall@linaro.org>
There is some place in Xen ARM code where multiple if conditions is used
check the presence of a node or find a node.
These pieces of code can be replace by an array and using proper device tree
helpers.
Signed-off-by: Julien Grall <julien.grall@linaro.org>
---
xen/arch/arm/domain_build.c | 12 +++++++++---
xen/arch/arm/time.c | 11 ++++++++---
2 files changed, 17 insertions(+), 6 deletions(-)
diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c
index a324c3b..604ec1c 100644
--- a/xen/arch/arm/domain_build.c
+++ b/xen/arch/arm/domain_build.c
@@ -435,6 +435,14 @@ static int map_device(struct domain *d, const struct dt_device_node *dev)
return 0;
}
+static const struct dt_device_match skip_matches[] __initconst =
+{
+ DT_MATCH_COMPATIBLE("xen,xen"),
+ DT_MATCH_TYPE("memory"),
+ DT_MATCH_PATH("/chosen"),
+ { /* sentinel */ },
+};
+
static int handle_node(struct domain *d, const struct dt_device_node *np)
{
const struct dt_device_node *child;
@@ -443,9 +451,7 @@ static int handle_node(struct domain *d, const struct dt_device_node *np)
DPRINT("handle %s\n", dt_node_full_name(np));
/* Skip theses nodes and the sub-nodes */
- if ( dt_device_is_compatible(np, "xen,xen") ||
- dt_device_type_is_equal(np, "memory") ||
- !strcmp("/chosen", dt_node_full_name(np)) )
+ if ( dt_match_node(skip_matches, np ) )
return 0;
if ( dt_device_used_by(np) != DOMID_XEN )
diff --git a/xen/arch/arm/time.c b/xen/arch/arm/time.c
index b5864ef..05e58ba 100644
--- a/xen/arch/arm/time.c
+++ b/xen/arch/arm/time.c
@@ -98,6 +98,13 @@ static uint32_t calibrate_timer(void)
}
*/
+static const struct dt_device_match timer_ids[] __initdata =
+{
+ DT_MATCH_COMPATIBLE("arm,armv7-timer"),
+ DT_MATCH_COMPATIBLE("arm,armv8-timer"),
+ { /* sentinel */ },
+};
+
/* Set up the timer on the boot CPU */
int __init init_xen_time(void)
{
@@ -105,9 +112,7 @@ int __init init_xen_time(void)
int res;
unsigned int i;
- dev = dt_find_compatible_node(NULL, NULL, "arm,armv7-timer");
- if ( !dev )
- dev = dt_find_compatible_node(NULL, NULL, "arm,armv8-timer");
+ dev = dt_find_matching_node(NULL, timer_ids);
if ( !dev )
panic("Unable to find a compatible timer in the device tree\n");
--
1.7.10.4
next prev parent reply other threads:[~2013-08-16 21:05 UTC|newest]
Thread overview: 84+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-16 21:05 [RFC 00/24] Allow Xen to boot with a raw Device Tree Julien Grall
2013-08-16 21:05 ` [RFC 01/24] xen/char: dt-uart: Allow the user to give a path to the node Julien Grall
2013-08-16 21:25 ` Andre Przywara
2013-08-19 15:09 ` Julien Grall
2013-08-22 12:23 ` Ian Campbell
2013-08-16 21:05 ` [RFC 02/24] xen: Introduce __initconst to store initial const data Julien Grall
2013-08-19 9:46 ` Jan Beulich
2013-08-19 14:56 ` Ian Campbell
2013-08-20 7:12 ` Jan Beulich
2013-08-20 8:31 ` Ian Campbell
2013-08-20 8:53 ` Jan Beulich
2013-08-20 8:59 ` Julien Grall
2013-08-22 13:07 ` Ian Campbell
2013-08-16 21:05 ` [RFC 03/24] xen/dts: Don't check the number of address and size cells in process_cpu_node Julien Grall
2013-08-19 0:59 ` Chen Baozi
2013-08-22 12:51 ` Ian Campbell
2013-08-22 13:14 ` Julien Grall
2013-08-22 14:05 ` Ian Campbell
2013-08-16 21:05 ` [RFC 04/24] xen/dts: Constify device_tree_flattened Julien Grall
2013-08-22 13:05 ` Ian Campbell
2013-08-22 13:35 ` Julien Grall
2013-08-22 14:07 ` Ian Campbell
2013-08-16 21:05 ` [RFC 05/24] xen/arm: Move __PSCI* from traps.c to the header Julien Grall
2013-08-22 13:05 ` Ian Campbell
2013-08-16 21:05 ` [RFC 06/24] xen: Add new string functions Julien Grall
2013-08-19 9:54 ` Jan Beulich
2013-08-19 14:57 ` Ian Campbell
2013-08-19 15:13 ` Julien Grall
2013-08-20 8:32 ` Jan Beulich
2013-08-16 21:05 ` [RFC 07/24] xen: Use the right string comparison function in device tree Julien Grall
2013-08-22 13:11 ` Ian Campbell
2013-08-22 13:23 ` Julien Grall
2013-08-16 21:05 ` [RFC 08/24] xen/dts: Don't add a fake property "name" in the " Julien Grall
2013-08-22 13:16 ` Ian Campbell
2013-08-22 13:43 ` Julien Grall
2013-08-22 14:08 ` Ian Campbell
2013-08-16 21:05 ` [RFC 09/24] xen/dts: Add new helpers to use " Julien Grall
2013-08-22 13:21 ` Ian Campbell
2013-08-22 13:48 ` Julien Grall
2013-08-22 14:09 ` Ian Campbell
2013-08-16 21:05 ` [RFC 10/24] xen/dts: Remove device_get_reg call in process_memory_node Julien Grall
2013-08-22 13:23 ` Ian Campbell
2013-08-22 13:54 ` Julien Grall
2013-08-22 14:10 ` Ian Campbell
2013-08-16 21:05 ` [RFC 11/24] xen/dts: Remove device_get_reg call in process_cpu_node Julien Grall
2013-08-16 21:05 ` [RFC 12/24] xen/dts: Remove device_get_reg call in process_multiboot_node Julien Grall
2013-08-16 21:05 ` [RFC 13/24] xen/dts: Check the CPU ID is not greater than NR_CPUS Julien Grall
2013-08-22 13:24 ` Ian Campbell
2013-08-16 21:05 ` [RFC 14/24] xen/video: hdlcd: Convert the driver to the new device tree API Julien Grall
2013-08-22 13:28 ` Ian Campbell
2013-08-22 14:02 ` Julien Grall
2013-08-22 14:11 ` Ian Campbell
2013-08-16 21:05 ` Julien Grall [this message]
2013-08-22 13:30 ` [RFC 15/24] xen/arm: Use dt_device_match to avoid multiple if conditions Ian Campbell
2013-08-22 14:04 ` Julien Grall
2013-08-16 21:05 ` [RFC 16/24] xen/arm: Build DOM0 FDT by browsing the device tree structure Julien Grall
2013-08-22 13:49 ` Ian Campbell
2013-08-22 14:10 ` Julien Grall
2013-08-22 14:13 ` Ian Campbell
2013-08-16 21:05 ` [RFC 17/24] xen/arm: Mark each device used by Xen as disabled in DOM0 FDT Julien Grall
2013-08-22 13:50 ` Ian Campbell
2013-08-22 14:15 ` Julien Grall
2013-08-22 14:22 ` Ian Campbell
2013-08-16 21:05 ` [RFC 18/24] xen/arm: Don't map disabled device in DOM0 Julien Grall
2013-08-16 21:05 ` [RFC 19/24] xen/arm: Create a fake PSCI node in dom0 device tree Julien Grall
2013-08-21 13:50 ` Julien Grall
2013-08-16 21:05 ` [RFC 20/24] xen/arm: Add new platform specific callback device_is_blacklist Julien Grall
2013-08-22 13:57 ` Ian Campbell
2013-08-16 21:05 ` [RFC 21/24] xen/arm: vexpress: Blacklist a list of board specific devices Julien Grall
2013-08-22 14:00 ` Ian Campbell
2013-08-22 14:24 ` Julien Grall
2013-08-22 14:36 ` Ian Campbell
2013-08-22 14:51 ` Julien Grall
2013-08-22 15:02 ` Ian Campbell
2013-08-22 15:28 ` Julien Grall
2013-08-22 15:32 ` Ian Campbell
2013-08-16 21:05 ` [RFC 22/24] xen/arm: exynos5: Blacklist MCT device Julien Grall
2013-08-16 21:05 ` [RFC 23/24] xen/dts: Clean up the exported API for device tree Julien Grall
2013-08-22 14:01 ` Ian Campbell
2013-08-16 21:05 ` [RFC 24/24] xen/arm: Check if the device is available before using it Julien Grall
2013-08-22 14:01 ` Ian Campbell
2013-08-19 22:11 ` [RFC 00/24] Allow Xen to boot with a raw Device Tree Julien Grall
2013-08-20 8:33 ` Ian Campbell
2013-08-20 8:48 ` Julien Grall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1376687156-6737-16-git-send-email-julien.grall@linaro.org \
--to=julien.grall@linaro.org \
--cc=andre.przywara@linaro.org \
--cc=ian.campbell@citrix.com \
--cc=patches@linaro.org \
--cc=stefano.stabellini@eu.citrix.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).