From: Ian Campbell <Ian.Campbell@citrix.com>
To: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
Cc: Keir Fraser <keir@xen.org>,
xen-devel@lists.xensource.com, tim@xen.org,
Jan Beulich <JBeulich@suse.com>
Subject: Re: [PATCH v4 1/4] xen/arm: implement steal_page
Date: Mon, 19 Aug 2013 17:20:02 +0100 [thread overview]
Message-ID: <1376929202.9708.67.camel@dagon.hellion.org.uk> (raw)
In-Reply-To: <1376565519-24814-1-git-send-email-stefano.stabellini@eu.citrix.com>
On Thu, 2013-08-15 at 12:18 +0100, Stefano Stabellini wrote:
> Signed-off-by: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
You needed to include the x86 folks here. Adding Keir and Jan.
Subject needs to change, you are no longer implementing steal_page but
moving it. I assume it is unchanged but please say so in the commit
message.
> + /* Unlink from original owner. */
> + if ( !(memflags & MEMF_no_refcount) && !domain_adjust_tot_pages(d, -1) )
We never call domain_adjust_tot_pages from anywhere on ARM -- I wonder
if we should be ;-)
Ah, the counter to this drop is in donate_page() -- which is define
right above steal_page on x86 and is an ASSERT(0) on x86. I don't think
it makes sense to move one without the other.
Ian.
next prev parent reply other threads:[~2013-08-19 16:20 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-15 11:17 [PATCH v4 0/4] introduce XENMEM_exchange_and_pin and XENMEM_unpin Stefano Stabellini
2013-08-15 11:18 ` [PATCH v4 1/4] xen/arm: implement steal_page Stefano Stabellini
2013-08-19 16:20 ` Ian Campbell [this message]
2013-08-15 11:18 ` [PATCH v4 2/4] xen/arm: introduce a generic p2m walker and use it in p2m_lookup Stefano Stabellini
2013-08-19 16:30 ` Ian Campbell
2013-08-15 11:18 ` [PATCH v4 3/4] xen: implement guest_physmap_(un)pin_range Stefano Stabellini
2013-08-19 16:35 ` Ian Campbell
2013-09-06 16:06 ` Stefano Stabellini
2013-09-06 16:12 ` Ian Campbell
2013-08-15 11:18 ` [PATCH v4 4/4] xen: introduce XENMEM_exchange_and_pin and XENMEM_unpin Stefano Stabellini
2013-08-15 13:03 ` Jan Beulich
2013-09-06 17:55 ` Stefano Stabellini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1376929202.9708.67.camel@dagon.hellion.org.uk \
--to=ian.campbell@citrix.com \
--cc=JBeulich@suse.com \
--cc=keir@xen.org \
--cc=stefano.stabellini@eu.citrix.com \
--cc=tim@xen.org \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).