From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ian Campbell <Ian.Campbell@citrix.com>
Subject: Re: [PATCH v4 1/4] xen/arm: implement steal_page
Date: Mon, 19 Aug 2013 17:20:02 +0100
Message-ID: <1376929202.9708.67.camel@dagon.hellion.org.uk>
References: <alpine.DEB.2.02.1308151211080.4470@kaball.uk.xensource.com>
	<1376565519-24814-1-git-send-email-stefano.stabellini@eu.citrix.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <1376565519-24814-1-git-send-email-stefano.stabellini@eu.citrix.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
Cc: Keir Fraser <keir@xen.org>, xen-devel@lists.xensource.com, tim@xen.org, Jan Beulich <JBeulich@suse.com>
List-Id: xen-devel@lists.xenproject.org

On Thu, 2013-08-15 at 12:18 +0100, Stefano Stabellini wrote:
> Signed-off-by: Stefano Stabellini <stefano.stabellini@eu.citrix.com>

You needed to include the x86 folks here. Adding Keir and Jan.

Subject needs to change, you are no longer implementing steal_page but
moving it. I assume it is unchanged but please say so in the commit
message.

> +    /* Unlink from original owner. */
> +    if ( !(memflags & MEMF_no_refcount) && !domain_adjust_tot_pages(d, -1) )

We never call domain_adjust_tot_pages from anywhere on ARM -- I wonder
if we should be ;-)

Ah, the counter to this drop is in donate_page() -- which is define
right above steal_page on x86 and is an ASSERT(0) on x86. I don't think
it makes sense to move one without the other.

Ian.