From: Ian Campbell <Ian.Campbell@citrix.com>
To: Julien Grall <julien.grall@linaro.org>
Cc: "xen-devel@lists.xen.org" <xen-devel@lists.xen.org>,
Patch Tracking <patches@linaro.org>,
Andre Przywara <andre.przywara@linaro.org>,
Stefano Stabellini <stefano.stabellini@eu.citrix.com>
Subject: Re: [PATCH] ARM: add Calxeda Midway platform
Date: Wed, 21 Aug 2013 08:23:50 +0100 [thread overview]
Message-ID: <1377069830.31198.3.camel@dagon.hellion.org.uk> (raw)
In-Reply-To: <CAPnVf8x_MjNt89rHZ7fHrtNb-bLT5SGj2vT+ZPkHP+Ju1x_Fxw@mail.gmail.com>
On Tue, 2013-08-20 at 20:01 +0100, Julien Grall wrote:
> On 20 August 2013 16:03, Ian Campbell <Ian.Campbell@citrix.com> wrote:
> > On Tue, 2013-08-13 at 17:13 +0200, Andre Przywara wrote:
> >> Calxeda Midway is an ARMv7 server platform with Cortex-A15 cores.
> >> The peripheral side has many similarities with the machine known as
> >> Highbank.
> >> Add Calxeda Midway to the list of supported platforms to avoid a
> >> warning on boot and provide the proper reset method.
> >>
> >> Signed-off-by: Andre Przywara <andre.przywara@linaro.org>
> >
> > acked + applied, thanks.
> >
> >
>
> Few mails before, I asked Andre to change one thing in his patch.
> He planned to send a new version later.
Sorry, I skimmed the thread but missed your request for a change.
(trimming quotes would be a massive help here)
Andre, can you send an incremental patch please?
Julien suggested replacing "static const char const *" with "const char
* const", was the lack of "static" in the replacement deliberate?
Julien suggested that the other platform code was similarly broken,
could fix that at the same time too?
Ian.
prev parent reply other threads:[~2013-08-21 7:23 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-13 15:13 [PATCH] ARM: add Calxeda Midway platform Andre Przywara
2013-08-13 22:02 ` Ian Campbell
2013-08-14 9:33 ` Julien Grall
2013-08-15 14:52 ` Ian Campbell
2013-08-14 9:44 ` Julien Grall
2013-08-14 9:54 ` Andre Przywara
2013-08-20 15:03 ` Ian Campbell
2013-08-20 19:01 ` Julien Grall
2013-08-21 7:23 ` Ian Campbell [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1377069830.31198.3.camel@dagon.hellion.org.uk \
--to=ian.campbell@citrix.com \
--cc=andre.przywara@linaro.org \
--cc=julien.grall@linaro.org \
--cc=patches@linaro.org \
--cc=stefano.stabellini@eu.citrix.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).