From: Yang Zhang <yang.z.zhang@intel.com>
To: xen-devel@lists.xensource.com
Cc: Yang Zhang <yang.z.zhang@Intel.com>,
Andrew.Cooper3@citrix.com, eddie.dong@intel.com,
jun.nakajima@intel.com, JBeulich@suse.com
Subject: [PATCH v3 2/4] Nested VMX: Force check ISR when L2 is running
Date: Thu, 22 Aug 2013 15:24:58 +0800 [thread overview]
Message-ID: <1377156300-32215-3-git-send-email-yang.z.zhang@intel.com> (raw)
In-Reply-To: <1377156300-32215-1-git-send-email-yang.z.zhang@intel.com>
From: Yang Zhang <yang.z.zhang@Intel.com>
External interrupt is allowed to notify CPU only when it has higher
priority than current in servicing interrupt. With APIC-v, the priority
comparing is done by hardware and hardware will inject the interrupt to
VCPU when it recognizes an interrupt. Currently, there is no virtual
APIC-v feature available for L1 to use, so when L2 is running, we still need
to compare interrupt priority with ISR in hypervisor instead via hardware.
Signed-off-by: Yang Zhang <yang.z.zhang@Intel.com>
---
xen/arch/x86/hvm/vlapic.c | 4 +++-
1 files changed, 3 insertions(+), 1 deletions(-)
diff --git a/xen/arch/x86/hvm/vlapic.c b/xen/arch/x86/hvm/vlapic.c
index 7a154f9..f1530fd 100644
--- a/xen/arch/x86/hvm/vlapic.c
+++ b/xen/arch/x86/hvm/vlapic.c
@@ -37,6 +37,7 @@
#include <asm/hvm/io.h>
#include <asm/hvm/support.h>
#include <asm/hvm/vmx/vmx.h>
+#include <asm/hvm/nestedhvm.h>
#include <public/hvm/ioreq.h>
#include <public/hvm/params.h>
@@ -1037,7 +1038,8 @@ int vlapic_has_pending_irq(struct vcpu *v)
if ( irr == -1 )
return -1;
- if ( vlapic_virtual_intr_delivery_enabled() )
+ if ( vlapic_virtual_intr_delivery_enabled() &&
+ !nestedhvm_vcpu_in_guestmode(v) )
return irr;
isr = vlapic_find_highest_isr(vlapic);
--
1.7.1
next prev parent reply other threads:[~2013-08-22 7:24 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-22 7:24 [PATCH v3 0/4] Nested VMX: APIC-v related bug fixing Yang Zhang
2013-08-22 7:24 ` [PATCH v3 1/4] Nested VMX: Check whether interrupt is blocked by TPR Yang Zhang
2013-08-22 7:24 ` Yang Zhang [this message]
2013-08-22 7:24 ` [PATCH v3 3/4] Nested VMX: Clear APIC-v control bit in vmcs02 Yang Zhang
2013-08-22 7:25 ` [PATCH v3 4/4] Nested VMX: Update APIC-v(RVI/SVI) when vmexit to L1 Yang Zhang
2013-08-22 7:35 ` [PATCH v3 0/4] Nested VMX: APIC-v related bug fixing Dong, Eddie
2013-08-23 7:12 ` Jan Beulich
2013-08-23 7:17 ` Zhang, Yang Z
2013-08-23 7:25 ` Jan Beulich
2013-08-23 7:38 ` Zhang, Yang Z
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1377156300-32215-3-git-send-email-yang.z.zhang@intel.com \
--to=yang.z.zhang@intel.com \
--cc=Andrew.Cooper3@citrix.com \
--cc=JBeulich@suse.com \
--cc=eddie.dong@intel.com \
--cc=jun.nakajima@intel.com \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).