xen-devel.lists.xenproject.org archive mirror
 help / color / mirror / Atom feed
From: Dario Faggioli <dario.faggioli@citrix.com>
To: Li Yechen <lccycc123@gmail.com>
Cc: Elena Ufimtseva <ufimtseva@gmail.com>,
	Ian.Jackson@eu.citrix.com,
	"xen-devel@lists.xen.org" <xen-devel@lists.xen.org>,
	Ian Campbell <Ian.Campbell@eu.citrix.com>,
	David Vrabel <david.vrabel@citrix.com>,
	Jan Beulich <JBeulich@suse.com>
Subject: Re: [RFC v2][PATCH 1/3] docs: design and intended usage for NUMA-aware ballooning
Date: Sun, 25 Aug 2013 23:24:57 +0200	[thread overview]
Message-ID: <1377465897.2754.30.camel@Abyss> (raw)
In-Reply-To: <CAP5+zHT6qUVmfd3iNxCLgDLW-g_J=mknvUL7=M6iLgQV0e2+Ew@mail.gmail.com>


[-- Attachment #1.1: Type: text/plain, Size: 2682 bytes --]

On mar, 2013-08-20 at 23:15 +0800, Li Yechen wrote:
> Hi David, 
> On Mon, Aug 19, 2013 at 8:58 PM, David Vrabel
> <david.vrabel@citrix.com> wrote:
>         The physical NUMA topology must not be exposed to guests that
>         have a
>
> Most of you have the same option that the interface should be in Xen,
> not in Guest
> balloon. I'm agree with it. In next version I'll think of how to
> implement this interface
> between xen and balloon.  
>
Perfect. That is not that much different from what you already have, the
only bit that will need some rework is the ballooning up path (see
George's e-mails).

>         In general, I'm not keen on adding ABIs or interfaces that
>         don't solve
>         real world problems, particularly if they're easy to misuse
>         and end up
>         with something that is very suboptimal.
> Dario, could the test examples that you sent to me several month be
> represented
> as a real-word example?
> The example shows that, after several guests create and shut-up, the
> node
> affinity is a mess
>         
They were not real-world example. As I said before, that is a
chicken-&-egg problem: there are not real world examples until we
implement the feature! :-P

What I think you're talking about is an old (2010 ?) Xen Summit
presentation from someone working on the same problem before, but then
not finishing it.

I don't have the link handy right now... I'll see if I can find it and
post it here.

> Oh, I think this is a better interface!
> I'd very appreciate this than what I have now. However, the code I
> show here
> _does_not_really_work_. It just pass some small tests. And I'm afraid
> that 
> there may be some bugs in my code.
> Could I set up David's interface as a secondary goal, waiting until
> this code
> is full tested? I'm really not that confident :)
> 
EhEh... All code has bugs. :-)

As I said, I also like this interface more. However, what I think you
should concentrate on (apart from, of course, debugging) is producing a
version of the series which does not use any new xenstore keys/interface
at all, and just balloons up and down taking pages evenly from all the
guest's virtual NUMA nodes.

After that, we can come back to implement a more fine grained control,
probably via this interface David is proposing here.

What do you think?

Thanks and Regards,
Dario

-- 
<<This happens because I choose it to happen!>> (Raistlin Majere)
-----------------------------------------------------------------
Dario Faggioli, Ph.D, http://about.me/dario.faggioli
Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK)


[-- Attachment #1.2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 198 bytes --]

[-- Attachment #2: Type: text/plain, Size: 126 bytes --]

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel

  reply	other threads:[~2013-08-25 21:24 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-08-16  4:13 [RFC v2][PATCH 1/3] docs: design and intended usage for NUMA-aware ballooning Yechen Li
2013-08-16  9:09 ` Jan Beulich
2013-08-16 10:18   ` Li Yechen
     [not found]   ` <CAP5+zHQ128UVGsGjxsNdvSOupt42Gue2+1nLVg-KYrb=exqqCw@mail.gmail.com>
2013-08-16 13:21     ` Jan Beulich
2013-08-16 14:17       ` Li Yechen
2013-08-16 14:55         ` Jan Beulich
2013-08-16 22:53       ` Dario Faggioli
2013-08-19  9:22         ` Jan Beulich
2013-08-20 14:18           ` Dario Faggioli
2013-08-16 23:30   ` Dario Faggioli
2013-08-19  9:17     ` Jan Beulich
2013-08-20 14:05       ` Dario Faggioli
2013-08-20 14:24         ` Jan Beulich
2013-08-19 11:05   ` George Dunlap
2013-08-20 14:31     ` Dario Faggioli
2013-08-19 12:58 ` David Vrabel
2013-08-19 13:26   ` George Dunlap
2013-08-20 14:20     ` David Vrabel
2013-08-20 14:55   ` Dario Faggioli
2013-08-20 15:15   ` Li Yechen
2013-08-25 21:24     ` Dario Faggioli [this message]
2013-09-26 14:15       ` Li Yechen
2013-09-26 14:15         ` Li Yechen
2013-08-23 20:53   ` Konrad Rzeszutek Wilk
2013-08-25 21:18     ` Dario Faggioli

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1377465897.2754.30.camel@Abyss \
    --to=dario.faggioli@citrix.com \
    --cc=Ian.Campbell@eu.citrix.com \
    --cc=Ian.Jackson@eu.citrix.com \
    --cc=JBeulich@suse.com \
    --cc=david.vrabel@citrix.com \
    --cc=lccycc123@gmail.com \
    --cc=ufimtseva@gmail.com \
    --cc=xen-devel@lists.xen.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).