From mboxrd@z Thu Jan  1 00:00:00 1970
From: Dario Faggioli <dario.faggioli@citrix.com>
Subject: Re: [PATCH v2 3/5] xl: allow for node-wise
 specification of vcpu pinning
Date: Tue, 10 Sep 2013 19:38:22 +0200
Message-ID: <1378834702.2821.48.camel@Solace>
References: <20130906154725.10218.45008.stgit@hit-nxdomain.opendns.com>
	<20130906155540.10218.3642.stgit@hit-nxdomain.opendns.com>
	<21034.1272.405345.870600@mariner.uk.xensource.com>
Mime-Version: 1.0
Content-Type: multipart/mixed; boundary="===============2339595500497644042=="
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <21034.1272.405345.870600@mariner.uk.xensource.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Ian Jackson <Ian.Jackson@eu.citrix.com>
Cc: George Dunlap <george.dunlap@eu.citrix.com>, Ian Campbell <ian.campbell@citrix.com>, xen-devel@lists.xen.org
List-Id: xen-devel@lists.xenproject.org

--===============2339595500497644042==
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature"; boundary="=-aTrI9jkXPr8hgppmW5CH"

--=-aTrI9jkXPr8hgppmW5CH
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On ven, 2013-09-06 at 17:38 +0100, Ian Jackson wrote:
> Dario Faggioli writes ("[PATCH v2 3/5] xl: allow for node-wise specificat=
ion of vcpu pinning"):
> > +static int update_cpumap_range(const char *str, libxl_bitmap *cpumap)
> > +{
> > +    unsigned long ida, idb;
> > +    libxl_bitmap node_cpumap;
> > +    bool is_not =3D false, is_nodes =3D false;
> > +    int rc =3D 0;
> > +
> > +    libxl_bitmap_init(&node_cpumap);
> > +
> > +    rc =3D libxl_node_bitmap_alloc(ctx, &node_cpumap, 0);
> > +    if (rc) {
> > +        fprintf(stderr, "libxl_node_bitmap_alloc failed.\n");
> > +        return rc;
>=20
> This could be "goto out".  I think that's clearer.  It follows the
> "zero everything right at the top, and use `goto out' for every
> premature exit" pattern.
>=20
Agreed, will do.

Dario

--=20
<<This happens because I choose it to happen!>> (Raistlin Majere)
-----------------------------------------------------------------
Dario Faggioli, Ph.D, http://about.me/dario.faggioli
Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK)


--=-aTrI9jkXPr8hgppmW5CH
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: This is a digitally signed message part
Content-Transfer-Encoding: 7bit

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.14 (GNU/Linux)

iEYEABECAAYFAlIvWQ4ACgkQk4XaBE3IOsTgbACfdVVhvXUCjtEif4lJpbr33ObU
h28An0AFY1697789A3j28LQO8IoIMlZb
=vE4h
-----END PGP SIGNATURE-----

--=-aTrI9jkXPr8hgppmW5CH--


--===============2339595500497644042==
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel

--===============2339595500497644042==--