From: Julien Grall <julien.grall@linaro.org>
To: xen-devel@lists.xen.org
Cc: patches@linaro.org, ian.campbell@citrix.com,
Julien Grall <julien.grall@linaro.org>,
stefano.stabellini@eu.citrix.com
Subject: [PATCH v2 4/6] xen/arm: Fix assert in send_SGI_one
Date: Wed, 11 Sep 2013 12:59:42 +0100 [thread overview]
Message-ID: <1378900784-16949-5-git-send-email-julien.grall@linaro.org> (raw)
In-Reply-To: <1378900784-16949-1-git-send-email-julien.grall@linaro.org>
The GIC can handle maximum 8 cpus (0...7). The CPU id 7 is still valid.
Signed-off-by: Julien Grall <julien.grall@linaro.org>
---
xen/arch/arm/gic.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/xen/arch/arm/gic.c b/xen/arch/arm/gic.c
index 7ea9ed6..88431c7 100644
--- a/xen/arch/arm/gic.c
+++ b/xen/arch/arm/gic.c
@@ -488,7 +488,7 @@ void send_SGI_mask(const cpumask_t *cpumask, enum gic_sgi sgi)
void send_SGI_one(unsigned int cpu, enum gic_sgi sgi)
{
- ASSERT(cpu < 7); /* Targets bitmap only supports 8 CPUs */
+ ASSERT(cpu < NR_GIC_CPU_IF); /* Targets bitmap only supports 8 CPUs */
send_SGI_mask(cpumask_of(cpu), sgi);
}
--
1.7.10.4
next prev parent reply other threads:[~2013-09-11 11:59 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-11 11:59 [PATCH v2 0/6] Dissociate logical and gic/hardware CPU ID Julien Grall
2013-09-11 11:59 ` [PATCH v2 1/6] xen/arm: use cpumask_t to describe cpu mask in gic_route_dt_irq Julien Grall
2013-09-11 11:59 ` [PATCH v2 2/6] xen/arm: Initialize correctly IRQ routing Julien Grall
2013-09-11 11:59 ` [PATCH v2 3/6] xen/arm: gic: Use the correct CPU ID Julien Grall
2013-09-17 14:36 ` Ian Campbell
2013-09-17 15:04 ` Julien Grall
2013-09-11 11:59 ` Julien Grall [this message]
2013-09-11 11:59 ` [PATCH v2 5/6] xen/arm: Dissociate logical and hardware " Julien Grall
2013-09-17 14:39 ` Ian Campbell
2013-09-17 15:02 ` Julien Grall
2013-09-17 15:08 ` Ian Campbell
2013-09-17 15:18 ` Julien Grall
2013-09-17 15:25 ` Ian Campbell
2013-09-11 11:59 ` [PATCH v2 6/6] xen/arm: Use the hardware ID to boot correctly secondary cpus Julien Grall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1378900784-16949-5-git-send-email-julien.grall@linaro.org \
--to=julien.grall@linaro.org \
--cc=ian.campbell@citrix.com \
--cc=patches@linaro.org \
--cc=stefano.stabellini@eu.citrix.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).