xen-devel.lists.xenproject.org archive mirror
 help / color / mirror / Atom feed
From: Tim Deegan <tim@xen.org>
To: xen-devel@lists.xen.org
Subject: [PATCH 1/9] x86/mm: Don't dereference p2m pointer before NULL check.
Date: Thu, 12 Sep 2013 13:15:22 +0100	[thread overview]
Message-ID: <1378988130-24172-2-git-send-email-tim@xen.org> (raw)
In-Reply-To: <1378988130-24172-1-git-send-email-tim@xen.org>

Not a security bug, because in fact this is never called with a NULL
argument.

Coverity CID 1055955

Signed-off-by: Tim Deegan <tim@xen.org>
---
 xen/arch/x86/mm/p2m.c |    4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/xen/arch/x86/mm/p2m.c b/xen/arch/x86/mm/p2m.c
index f5ddd20..8f380ed 100644
--- a/xen/arch/x86/mm/p2m.c
+++ b/xen/arch/x86/mm/p2m.c
@@ -453,7 +453,7 @@ void p2m_teardown(struct p2m_domain *p2m)
  * We know we don't have any extra mappings to these pages */
 {
     struct page_info *pg;
-    struct domain *d = p2m->domain;
+    struct domain *d;
     unsigned long gfn;
     p2m_type_t t;
     mfn_t mfn;
@@ -461,6 +461,8 @@ void p2m_teardown(struct p2m_domain *p2m)
     if (p2m == NULL)
         return;
 
+    d = p2m->domain;
+
     p2m_lock(p2m);
 
     /* Try to unshare any remaining shared p2m entries. Safeguard
-- 
1.7.10.4

  reply	other threads:[~2013-09-12 12:15 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-09-12 12:15 More Coverity-reported issues Tim Deegan
2013-09-12 12:15 ` Tim Deegan [this message]
2013-09-12 12:15 ` [PATCH 2/9] passthrough/amd: Drop unnecessary lock lookup Tim Deegan
2013-09-12 13:35   ` Jan Beulich
2013-09-12 12:15 ` [PATCH 3/9] passthrough/amd: Missing 'break' Tim Deegan
2013-09-17 15:04   ` Suravee Suthikulpanit
2013-09-12 12:15 ` [PATCH 4/9] passthrough/amd: Shuffle declaration Tim Deegan
2013-09-12 13:38   ` Jan Beulich
2013-09-12 13:44     ` Tim Deegan
2013-09-12 14:03       ` Jan Beulich
2013-09-17 15:19         ` Suravee Suthikulpanit
2013-09-12 12:15 ` [PATCH 5/9] cpufreq: avoid integer overflows Tim Deegan
2013-09-12 13:49   ` Jan Beulich
2013-09-13  7:18   ` Liu, Jinsong
2013-09-12 12:15 ` [PATCH 6/9] cpufreq: missing check of copy_from_guest() Tim Deegan
2013-09-12 13:54   ` Jan Beulich
2013-09-13  7:18   ` Liu, Jinsong
2013-09-12 12:15 ` [PATCH 7/9] ehci-dbgp: avoid division by zero Tim Deegan
2013-09-12 13:55   ` Jan Beulich
2013-09-12 12:15 ` [PATCH 8/9] ehci-dbgp: drop dead code Tim Deegan
2013-09-12 14:01   ` Jan Beulich
2013-09-12 12:15 ` [PATCH 9/9] acpi/pmstat: fix check for empty name strings Tim Deegan
2013-09-12 14:02   ` Jan Beulich
2013-09-12 13:11 ` More Coverity-reported issues Andrew Cooper

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1378988130-24172-2-git-send-email-tim@xen.org \
    --to=tim@xen.org \
    --cc=xen-devel@lists.xen.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).