From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tim Deegan Subject: [PATCH 8/9] ehci-dbgp: drop dead code. Date: Thu, 12 Sep 2013 13:15:29 +0100 Message-ID: <1378988130-24172-9-git-send-email-tim@xen.org> References: <1378988130-24172-1-git-send-email-tim@xen.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1378988130-24172-1-git-send-email-tim@xen.org> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: xen-devel@lists.xen.org Cc: Jan Beulich List-Id: xen-devel@lists.xenproject.org We can only reach this spot by breaking out of the scan loop, so by construction ret > 0. Coverity CID 1055259 Signed-off-by: Tim Deegan Cc: Jan Beulich --- xen/drivers/char/ehci-dbgp.c | 5 ----- 1 file changed, 5 deletions(-) diff --git a/xen/drivers/char/ehci-dbgp.c b/xen/drivers/char/ehci-dbgp.c index 0ac2dd9..b900d60 100644 --- a/xen/drivers/char/ehci-dbgp.c +++ b/xen/drivers/char/ehci-dbgp.c @@ -946,11 +946,6 @@ try_again: dbgp_printk("could not find attached debug device\n"); goto err; } - if ( ret < 0 ) - { - dbgp_printk("attached device is not a debug device\n"); - goto err; - } dbgp->out.endpoint = dbgp_desc.bDebugOutEndpoint; dbgp->in.endpoint = dbgp_desc.bDebugInEndpoint; -- 1.7.10.4