[PATCH] xl: fix `xl cpupool-list' behavior in case no pool name is provided

[PATCH] xl: fix `xl cpupool-list' behavior in case no pool name is provided

[Dario Faggioli]

since it errors out, asking for at least one argument, and does
not display any useful output, which is wrong (we want the list
and the info about all the existing cpupools).

IOW, the output is as follows:

 ~# xl cpupool-list -c
 'xl cpupool-list' requires at least 1 argument.
 ...

While it should be as follows:

 ~# xl cpupool-list -c
 Name               CPU list
 Pool-0             0,1,2,3,4,5,6,7,8,9,10,11,12,13,14,15

Signed-off-by: Dario Faggioli <dario.faggioli@citrix.com>
---
 tools/libxl/xl_cmdimpl.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/libxl/xl_cmdimpl.c b/tools/libxl/xl_cmdimpl.c
index 884f050..35b3e29 100644
--- a/tools/libxl/xl_cmdimpl.c
+++ b/tools/libxl/xl_cmdimpl.c
@@ -6570,7 +6570,7 @@ int main_cpupoollist(int argc, char **argv)
     char *name;
     int ret = 0;
 
-    SWITCH_FOREACH_OPT(opt, "hc", opts, "cpupool-list", 1) {
+    SWITCH_FOREACH_OPT(opt, "hc", opts, "cpupool-list", 0) {
     case 'c':
         opt_cpus = 1;
         break;

Re: [PATCH] xl: fix `xl cpupool-list' behavior in case no pool name is provided

[Juergen Gross]

On 11.09.2013 13:06, Dario Faggioli wrote:
> since it errors out, asking for at least one argument, and does
> not display any useful output, which is wrong (we want the list
> and the info about all the existing cpupools).
>
> IOW, the output is as follows:
>
>   ~# xl cpupool-list -c
>   'xl cpupool-list' requires at least 1 argument.
>   ...
>
> While it should be as follows:
>
>   ~# xl cpupool-list -c
>   Name               CPU list
>   Pool-0             0,1,2,3,4,5,6,7,8,9,10,11,12,13,14,15
>
> Signed-off-by: Dario Faggioli <dario.faggioli@citrix.com>

Acked-by: Juergen Gross <juergen.gross@ts.fujitsu.com>

> ---
>   tools/libxl/xl_cmdimpl.c |    2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/libxl/xl_cmdimpl.c b/tools/libxl/xl_cmdimpl.c
> index 884f050..35b3e29 100644
> --- a/tools/libxl/xl_cmdimpl.c
> +++ b/tools/libxl/xl_cmdimpl.c
> @@ -6570,7 +6570,7 @@ int main_cpupoollist(int argc, char **argv)
>       char *name;
>       int ret = 0;
>
> -    SWITCH_FOREACH_OPT(opt, "hc", opts, "cpupool-list", 1) {
> +    SWITCH_FOREACH_OPT(opt, "hc", opts, "cpupool-list", 0) {
>       case 'c':
>           opt_cpus = 1;
>           break;
>
>
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xen.org
> http://lists.xen.org/xen-devel
>
>


-- 
Juergen Gross                 Principal Developer Operating Systems
PBG PDG ES&S SWE OS6                   Telephone: +49 (0) 89 3222 2967
Fujitsu Technology Solutions              e-mail: juergen.gross@ts.fujitsu.com
Domagkstr. 28                           Internet: ts.fujitsu.com
D-80807 Muenchen                 Company details: ts.fujitsu.com/imprint.html

Re: [PATCH] xl: fix `xl cpupool-list' behavior in case no pool name is provided

[Dario Faggioli]

[-- Attachment #1.1: Type: text/plain, Size: 1162 bytes --]

On mer, 2013-09-11 at 13:13 +0200, Juergen Gross wrote:
> On 11.09.2013 13:06, Dario Faggioli wrote:
> > since it errors out, asking for at least one argument, and does
> > not display any useful output, which is wrong (we want the list
> > and the info about all the existing cpupools).
> >
> > IOW, the output is as follows:
> >
> >   ~# xl cpupool-list -c
> >   'xl cpupool-list' requires at least 1 argument.
> >   ...
> >
> > While it should be as follows:
> >
> >   ~# xl cpupool-list -c
> >   Name               CPU list
> >   Pool-0             0,1,2,3,4,5,6,7,8,9,10,11,12,13,14,15
> >
> > Signed-off-by: Dario Faggioli <dario.faggioli@citrix.com>
> 
> Acked-by: Juergen Gross <juergen.gross@ts.fujitsu.com>
> 
BTW, I just checked, and this affects 4.3.0 too.

I'll request a backport for this patch as soon as it hits the unstable
repository.

Regards,
Dario

-- 
<<This happens because I choose it to happen!>> (Raistlin Majere)
-----------------------------------------------------------------
Dario Faggioli, Ph.D, http://about.me/dario.faggioli
Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK)


[-- Attachment #1.2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 198 bytes --]

[-- Attachment #2: Type: text/plain, Size: 126 bytes --]

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel

Re: [PATCH] xl: fix `xl cpupool-list' behavior in case no pool name is provided

[Ian Campbell]

On Wed, 2013-09-11 at 13:13 +0200, Juergen Gross wrote:
> On 11.09.2013 13:06, Dario Faggioli wrote:
> > since it errors out, asking for at least one argument, and does
> > not display any useful output, which is wrong (we want the list
> > and the info about all the existing cpupools).
> >
> > IOW, the output is as follows:
> >
> >   ~# xl cpupool-list -c
> >   'xl cpupool-list' requires at least 1 argument.
> >   ...
> >
> > While it should be as follows:
> >
> >   ~# xl cpupool-list -c
> >   Name               CPU list
> >   Pool-0             0,1,2,3,4,5,6,7,8,9,10,11,12,13,14,15
> >
> > Signed-off-by: Dario Faggioli <dario.faggioli@citrix.com>
> 
> Acked-by: Juergen Gross <juergen.gross@ts.fujitsu.com>

Applied, thanks

Backport request for 4.3.x [was: Re: [PATCH] xl: fix `xl cpupool-list' behavior in case no pool name is provided]

[Dario Faggioli]

[-- Attachment #1.1: Type: text/plain, Size: 1546 bytes --]

On ven, 2013-09-13 at 13:35 +0100, Ian Campbell wrote:
> On Wed, 2013-09-11 at 13:13 +0200, Juergen Gross wrote:
> > On 11.09.2013 13:06, Dario Faggioli wrote:
> > > since it errors out, asking for at least one argument, and does
> > > not display any useful output, which is wrong (we want the list
> > > and the info about all the existing cpupools).
> > >
> > > IOW, the output is as follows:
> > >
> > >   ~# xl cpupool-list -c
> > >   'xl cpupool-list' requires at least 1 argument.
> > >   ...
> > >
> > > While it should be as follows:
> > >
> > >   ~# xl cpupool-list -c
> > >   Name               CPU list
> > >   Pool-0             0,1,2,3,4,5,6,7,8,9,10,11,12,13,14,15
> > >
> > > Signed-off-by: Dario Faggioli <dario.faggioli@citrix.com>
> > 
> > Acked-by: Juergen Gross <juergen.gross@ts.fujitsu.com>
> 
> Applied, thanks
> 
Thanks to you.

As already said, I verified that this bug also affects Xen 4.3. I'm
therefore requesting the backport of this patch, that is now commit
3998afdbf99959582dcd9f9f4df5a6fe7ce4ded8, to there.

`git cherry-pick'ing it from staging-4.3 works fine.

While at it, I tried 4.2.3 as well and that does not show the bug, so no
need to backport to anything farther than 4.3.

Thanks and Regards,
Dario

-- 
<<This happens because I choose it to happen!>> (Raistlin Majere)
-----------------------------------------------------------------
Dario Faggioli, Ph.D, http://about.me/dario.faggioli
Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK)


[-- Attachment #1.2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 198 bytes --]

[-- Attachment #2: Type: text/plain, Size: 126 bytes --]

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel

Backport request for 4.3.x [was: Re: [PATCH] xl: fix `xl cpupool-list' behavior in case no pool name is provided]

[Ian Jackson]

Dario Faggioli writes ("Backport request for 4.3.x [was: Re: [Xen-devel] [PATCH] xl: fix `xl cpupool-list' behavior in case no pool name is provided]"):
> As already said, I verified that this bug also affects Xen 4.3. I'm
> therefore requesting the backport of this patch, that is now commit
> 3998afdbf99959582dcd9f9f4df5a6fe7ce4ded8, to there.

I have added this to my list.  I'm not backporting it just yet because
it should have some time to settle in unstable.

Ian.

Re: Backport request for 4.3.x [was: Re: [PATCH] xl: fix `xl cpupool-list' behavior in case no pool name is provided]

[Dario Faggioli]

[-- Attachment #1.1: Type: text/plain, Size: 855 bytes --]

On ven, 2013-09-13 at 14:48 +0100, Ian Jackson wrote:
> Dario Faggioli writes ("Backport request for 4.3.x [was: Re: [Xen-devel] [PATCH] xl: fix `xl cpupool-list' behavior in case no pool name is provided]"):
> > As already said, I verified that this bug also affects Xen 4.3. I'm
> > therefore requesting the backport of this patch, that is now commit
> > 3998afdbf99959582dcd9f9f4df5a6fe7ce4ded8, to there.
> 
> I have added this to my list.  
>
Thanks.

> I'm not backporting it just yet because
> it should have some time to settle in unstable.
> 
Sure!

Regards,
Dario

-- 
<<This happens because I choose it to happen!>> (Raistlin Majere)
-----------------------------------------------------------------
Dario Faggioli, Ph.D, http://about.me/dario.faggioli
Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK)


[-- Attachment #1.2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 198 bytes --]

[-- Attachment #2: Type: text/plain, Size: 126 bytes --]

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel

Backport request for 4.3.x [was: Re: [PATCH] xl: fix `xl cpupool-list' behavior in case no pool name is provided]

[Ian Jackson]

Ian Jackson writes ("Backport request for 4.3.x [was: Re: [Xen-devel] [PATCH] xl: fix `xl cpupool-list' behavior in case no pool name is provided]"):
> Dario Faggioli writes ("Backport request for 4.3.x [was: Re: [Xen-devel] [PATCH] xl: fix `xl cpupool-list' behavior in case no pool name is provided]"):
> > As already said, I verified that this bug also affects Xen 4.3. I'm
> > therefore requesting the backport of this patch, that is now commit
> > 3998afdbf99959582dcd9f9f4df5a6fe7ce4ded8, to there.
> 
> I have added this to my list.  I'm not backporting it just yet because
> it should have some time to settle in unstable.

This is now in staging-4.3.

Ian.