From: Dario Faggioli <dario.faggioli@citrix.com>
To: Ian Campbell <Ian.Campbell@citrix.com>
Cc: Wei Liu <wei.liu2@citrix.com>,
Andrew Cooper <andrew.cooper3@citrix.com>,
Tim Deegan <tim@xen.org>,
xen-devel@lists.xen.org, Keir Fraser <keir.xen@gmail.com>,
Jan Beulich <JBeulich@suse.com>
Subject: Re: [PATCH v2 5/6] libxc: introduce xc_map_domain_meminfo (and xc_unmap_domain_meminfo)
Date: Fri, 13 Sep 2013 14:21:01 +0200 [thread overview]
Message-ID: <1379074861.6095.30.camel@Solace> (raw)
In-Reply-To: <1379073903.19256.50.camel@kazak.uk.xensource.com>
[-- Attachment #1.1: Type: text/plain, Size: 1058 bytes --]
On ven, 2013-09-13 at 13:05 +0100, Ian Campbell wrote:
> On Tue, 2013-09-10 at 19:54 +0200, Dario Faggioli wrote:
> > +static inline xen_pfn_t pfn_to_mfn(xen_pfn_t pfn, xen_pfn_t *p2m, int gwidth)
> > +{
> > + return ((xen_pfn_t) ((gwidth==8)?
> > + (((uint64_t *)p2m)[(pfn)]):
> > + ((((uint32_t *)p2m)[(pfn)]) == 0xffffffffU ?
> > + (-1UL) :
> > + (((uint32_t *)p2m)[(pfn)]))));
> > +}
> > +
>
> OMG. (since it's just moved no need to fix, but I couldn't let it pass).
>
:-D
It is pure code motion, so I did not touch it, but I'm up for trying to
refactor it a bit.
Will do in next version or, if the series gets in as is, in a follow up
patch, ok?
Regards,
Dario
--
<<This happens because I choose it to happen!>> (Raistlin Majere)
-----------------------------------------------------------------
Dario Faggioli, Ph.D, http://about.me/dario.faggioli
Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK)
[-- Attachment #1.2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 198 bytes --]
[-- Attachment #2: Type: text/plain, Size: 126 bytes --]
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
next prev parent reply other threads:[~2013-09-13 12:21 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-10 17:53 [PATCH v2 0/6] some libxc cleanups and xen-mfndump Dario Faggioli
2013-09-10 17:53 ` [PATCH v2 1/6] libxc: introduce xc_domain_get_guest_width() Dario Faggioli
2013-09-10 17:53 ` [PATCH v2 2/6] libxc: use xc_vcpu_setcontext() instead of calling do_domctl() Dario Faggioli
2013-09-10 17:53 ` [PATCH v2 3/6] libxc: use xc_vcpu_getinfo() " Dario Faggioli
2013-09-10 17:54 ` [PATCH v2 4/6] libxc: allow for ctxt to be NULL in xc_vcpu_setcontext Dario Faggioli
2013-09-10 17:54 ` [PATCH v2 5/6] libxc: introduce xc_map_domain_meminfo (and xc_unmap_domain_meminfo) Dario Faggioli
2013-09-13 12:05 ` Ian Campbell
2013-09-13 12:21 ` Dario Faggioli [this message]
2013-09-13 12:24 ` Ian Campbell
2013-09-13 13:02 ` Dario Faggioli
2013-09-13 13:12 ` Ian Campbell
2013-09-13 13:25 ` Ian Campbell
2013-09-13 13:35 ` Dario Faggioli
2013-09-10 17:54 ` [PATCH v2 6/6] tools/misc: introduce xen-mfndump Dario Faggioli
2013-09-11 8:09 ` [PATCH v2 0/6] some libxc cleanups and xen-mfndump Dario Faggioli
2013-09-13 12:33 ` Ian Campbell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1379074861.6095.30.camel@Solace \
--to=dario.faggioli@citrix.com \
--cc=Ian.Campbell@citrix.com \
--cc=JBeulich@suse.com \
--cc=andrew.cooper3@citrix.com \
--cc=keir.xen@gmail.com \
--cc=tim@xen.org \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).