From mboxrd@z Thu Jan  1 00:00:00 1970
From: Dario Faggioli <dario.faggioli@citrix.com>
Subject: Re: [PATCH v2 5/6] libxc: introduce
 xc_map_domain_meminfo (and xc_unmap_domain_meminfo)
Date: Fri, 13 Sep 2013 14:21:01 +0200
Message-ID: <1379074861.6095.30.camel@Solace>
References: <20130910174758.7735.13358.stgit@hit-nxdomain.opendns.com>
	<20130910175412.7735.58070.stgit@hit-nxdomain.opendns.com>
	<1379073903.19256.50.camel@kazak.uk.xensource.com>
Mime-Version: 1.0
Content-Type: multipart/mixed; boundary="===============1364082669678611527=="
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <1379073903.19256.50.camel@kazak.uk.xensource.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Ian Campbell <Ian.Campbell@citrix.com>
Cc: Wei Liu <wei.liu2@citrix.com>, Andrew Cooper <andrew.cooper3@citrix.com>, Tim Deegan <tim@xen.org>, xen-devel@lists.xen.org, Keir Fraser <keir.xen@gmail.com>, Jan Beulich <JBeulich@suse.com>
List-Id: xen-devel@lists.xenproject.org

--===============1364082669678611527==
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature"; boundary="=-e9vufC2YL9rwE7fYFNpT"

--=-e9vufC2YL9rwE7fYFNpT
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On ven, 2013-09-13 at 13:05 +0100, Ian Campbell wrote:
> On Tue, 2013-09-10 at 19:54 +0200, Dario Faggioli wrote:
> > +static inline xen_pfn_t pfn_to_mfn(xen_pfn_t pfn, xen_pfn_t *p2m, int =
gwidth)
> > +{
> > +  return ((xen_pfn_t) ((gwidth=3D=3D8)?
> > +                       (((uint64_t *)p2m)[(pfn)]):
> > +                       ((((uint32_t *)p2m)[(pfn)]) =3D=3D 0xffffffffU =
?
> > +                            (-1UL) :
> > +                            (((uint32_t *)p2m)[(pfn)]))));
> > +}
> > +
>=20
> OMG. (since it's just moved no need to fix, but I couldn't let it pass).
>=20
:-D

It is pure code motion, so I did not touch it, but I'm up for trying to
refactor it a bit.

Will do in next version or, if the series gets in as is, in a follow up
patch, ok?

Regards,
Dario

--=20
<<This happens because I choose it to happen!>> (Raistlin Majere)
-----------------------------------------------------------------
Dario Faggioli, Ph.D, http://about.me/dario.faggioli
Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK)


--=-e9vufC2YL9rwE7fYFNpT
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: This is a digitally signed message part
Content-Transfer-Encoding: 7bit

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.14 (GNU/Linux)

iEYEABECAAYFAlIzAy4ACgkQk4XaBE3IOsRfHgCfWSQaMsf6Qj0/BbAQqm3we2dJ
sYUAn2nPomqyJycjPF5v4sSM8Dti+ODi
=kCkf
-----END PGP SIGNATURE-----

--=-e9vufC2YL9rwE7fYFNpT--


--===============1364082669678611527==
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel

--===============1364082669678611527==--