From: Julien Grall <julien.grall@linaro.org>
To: xen-devel@lists.xen.org
Cc: patches@linaro.org, Julien Grall <julien.grall@linaro.org>,
ian.campbell@citrix.com, andre.przywara@linaro.org,
stefano.stabellini@eu.citrix.com
Subject: [PATCH v4 16/27] xen/arm: Create a fake cpus node in dom0 device tree
Date: Fri, 13 Sep 2013 13:49:23 +0100 [thread overview]
Message-ID: <1379076574-28316-17-git-send-email-julien.grall@linaro.org> (raw)
In-Reply-To: <1379076574-28316-1-git-send-email-julien.grall@linaro.org>
The number of cpus in dom0 can be different compare to the real number of
physical cpus.
For the moment, Xen assumes that the cpus are identical.
Signed-off-by: Julien Grall <julien.grall@linaro.org>
Acked-by: Ian Campbell <ian.campbell@citrix.com>
---
Changes in v3:
- for_each_child was renamed to dt_for_each_child
- improve comment in the code
---
xen/arch/arm/domain_build.c | 92 +++++++++++++++++++++++++++++++++++++++++++
1 file changed, 92 insertions(+)
diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c
index e1333a4..036155e 100644
--- a/xen/arch/arm/domain_build.c
+++ b/xen/arch/arm/domain_build.c
@@ -352,6 +352,93 @@ static int make_psci_node(void *fdt, const struct dt_device_node *parent)
return res;
}
+static int make_cpus_node(const struct domain *d, void *fdt,
+ const struct dt_device_node *parent)
+{
+ int res;
+ const struct dt_device_node *cpus = dt_find_node_by_path("/cpus");
+ const struct dt_device_node *npcpu;
+ unsigned int cpu;
+ const void *compatible = NULL;
+ u32 len;
+ /* Placeholder for cpu@ + a 32-bit number + \0 */
+ char buf[15];
+
+ DPRINT("Create cpus node\n");
+
+ if ( !cpus )
+ {
+ dprintk(XENLOG_ERR, "Missing /cpus node in the device tree?\n");
+ return -ENOENT;
+ }
+
+ /*
+ * Get the compatible property of CPUs from the device tree.
+ * We are assuming that all CPUs are the same so we are just look
+ * for the first one.
+ * TODO: Handle compatible per VCPU
+ */
+ dt_for_each_child_node(cpus, npcpu)
+ {
+ if ( dt_device_type_is_equal(npcpu, "cpu") )
+ {
+ compatible = dt_get_property(npcpu, "compatible", &len);
+ break;
+ }
+ }
+
+ if ( !compatible )
+ {
+ dprintk(XENLOG_ERR, "Can't find cpu in the device tree?\n");
+ return -ENOENT;
+ }
+
+ /* See Linux Documentation/devicetree/booting-without-of.txt
+ * section III.5.b
+ */
+ res = fdt_begin_node(fdt, "cpus");
+ if ( res )
+ return res;
+
+ res = fdt_property_cell(fdt, "#address-cells", 1);
+ if ( res )
+ return res;
+
+ res = fdt_property_cell(fdt, "#size-cells", 0);
+ if ( res )
+ return res;
+
+ for ( cpu = 0; cpu < d->max_vcpus; cpu++ )
+ {
+ DPRINT("Create cpu@%u node\n", cpu);
+
+ snprintf(buf, sizeof(buf), "cpu@%u", cpu);
+ res = fdt_begin_node(fdt, buf);
+ if ( res )
+ return res;
+
+ res = fdt_property(fdt, "compatible", compatible, len);
+ if ( res )
+ return res;
+
+ res = fdt_property_string(fdt, "device_type", "cpu");
+ if ( res )
+ return res;
+
+ res = fdt_property_cell(fdt, "reg", cpu);
+ if ( res )
+ return res;
+
+ res = fdt_end_node(fdt);
+ if ( res )
+ return res;
+ }
+
+ res = fdt_end_node(fdt);
+
+ return res;
+}
+
/* Map the device in the domain */
static int map_device(struct domain *d, const struct dt_device_node *dev)
{
@@ -440,6 +527,7 @@ static int handle_node(struct domain *d, struct kernel_info *kinfo,
DT_MATCH_COMPATIBLE("xen,xen"),
DT_MATCH_COMPATIBLE("xen,multiboot-module"),
DT_MATCH_COMPATIBLE("arm,psci"),
+ DT_MATCH_PATH("/cpus"),
{ /* sentinel */ },
};
const struct dt_device_node *child;
@@ -509,6 +597,10 @@ static int handle_node(struct domain *d, struct kernel_info *kinfo,
res = make_psci_node(kinfo->fdt, np);
if ( res )
return res;
+
+ res = make_cpus_node(d, kinfo->fdt, np);
+ if ( res )
+ return res;
}
res = fdt_end_node(kinfo->fdt);
--
1.7.10.4
next prev parent reply other threads:[~2013-09-13 12:49 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-13 12:49 [PATCH v4 00/27] Allow Xen to boot with a raw device tree Julien Grall
2013-09-13 12:49 ` [PATCH v4 01/27] xen/dts: Constify device_tree_flattened Julien Grall
2013-09-13 12:49 ` [PATCH v4 02/27] xen/dts: Prefix device tree macro by dt_ Julien Grall
2013-09-13 12:49 ` [PATCH v4 03/27] xen/dts: Don't add a fake property "name" in the device tree Julien Grall
2013-09-13 12:49 ` [PATCH v4 04/27] xen/dts: Add new helpers to use " Julien Grall
2013-09-13 12:49 ` [PATCH v4 05/27] xen: Use the right string comparison function in " Julien Grall
2013-09-13 12:49 ` [PATCH v4 06/27] xen/dts: Remove device_get_reg call in process_cpu_node Julien Grall
2013-09-13 12:49 ` [PATCH v4 07/27] xen/dts: Check "reg" property length in process_multiboot_node Julien Grall
2013-09-13 12:49 ` [PATCH v4 08/27] xen/dts: Check the CPU ID is not greater than NR_CPUS Julien Grall
2013-09-13 12:49 ` [PATCH v4 09/27] xen/video: hdlcd: Convert the driver to the new device tree API Julien Grall
2013-09-13 12:49 ` [PATCH v4 10/27] xen/video: hdlcd: Use early_printk instead of printk Julien Grall
2013-09-13 12:49 ` [PATCH v4 11/27] xen/arm: Use dt_device_match to avoid multiple if conditions Julien Grall
2013-09-13 12:49 ` [PATCH v4 12/27] xen/dts: dt_find_interrupt_controller: accept multiple compatible strings Julien Grall
2013-09-13 12:49 ` [PATCH v4 13/27] xen/arm: Build DOM0 FDT by browsing the device tree structure Julien Grall
2013-09-13 12:49 ` [PATCH v4 14/27] xen/arm: Don't map disabled device in DOM0 Julien Grall
2013-09-13 12:49 ` [PATCH v4 15/27] xen/arm: Create a fake PSCI node in dom0 device tree Julien Grall
2013-09-13 12:49 ` Julien Grall [this message]
2013-09-13 12:49 ` [PATCH v4 17/27] xen/arm: Create a fake GIC " Julien Grall
2013-09-13 12:49 ` [PATCH v4 18/27] xen/arm: Create a fake timer " Julien Grall
2013-09-13 12:49 ` [PATCH v4 19/27] xen/arm: Add new platform specific callback device_is_blacklist Julien Grall
2013-09-13 12:49 ` [PATCH v4 20/27] xen/arm: Remove devices used by Xen from dom0 device tree Julien Grall
2013-09-13 12:49 ` [PATCH v4 21/27] xen/arm: vexpress: Blacklist a list of board specific devices Julien Grall
2013-09-13 12:49 ` [PATCH v4 22/27] xen/arm: exynos5: Blacklist MCT device Julien Grall
2013-09-13 12:49 ` [PATCH v4 23/27] xen/dts: Clean up the exported API for device tree Julien Grall
2013-09-13 12:49 ` [PATCH v4 24/27] xen/dts: device_get_reg: cells are 32-bit big endian value Julien Grall
2013-09-13 12:49 ` [PATCH v4 25/27] xen/dts: replace get_val by dt_next_cell Julien Grall
2013-09-13 12:49 ` [PATCH v4 26/27] xen/arm: Check if the device is available before using it Julien Grall
2013-09-13 12:49 ` [PATCH v4 27/27] ARM: parse separate DT properties for different commandlines Julien Grall
2013-09-17 14:43 ` [PATCH v4 00/27] Allow Xen to boot with a raw device tree Ian Campbell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1379076574-28316-17-git-send-email-julien.grall@linaro.org \
--to=julien.grall@linaro.org \
--cc=andre.przywara@linaro.org \
--cc=ian.campbell@citrix.com \
--cc=patches@linaro.org \
--cc=stefano.stabellini@eu.citrix.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).