xen-devel.lists.xenproject.org archive mirror
 help / color / mirror / Atom feed
From: Julien Grall <julien.grall@linaro.org>
To: xen-devel@lists.xen.org
Cc: patches@linaro.org, Julien Grall <julien.grall@linaro.org>,
	ian.campbell@citrix.com, andre.przywara@linaro.org,
	stefano.stabellini@eu.citrix.com
Subject: [PATCH v4 24/27] xen/dts: device_get_reg: cells are 32-bit big endian value
Date: Fri, 13 Sep 2013 13:49:31 +0100	[thread overview]
Message-ID: <1379076574-28316-25-git-send-email-julien.grall@linaro.org> (raw)
In-Reply-To: <1379076574-28316-1-git-send-email-julien.grall@linaro.org>

Device tree cells are 32-bit big endian value. Use __be32 to avoid confusion
later.

Signed-off-by: Julien Grall <julien.grall@linaro.org>
Acked-by: Ian Campbell <ian.campbell@citrix.com>

---
    Changes in v3:
        - Divide the patch in 2 parts. Move in another patch
        s/get_val/dt_next_cell/
---
 xen/common/device_tree.c |   12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/xen/common/device_tree.c b/xen/common/device_tree.c
index 8e6d8c1..eac507d 100644
--- a/xen/common/device_tree.c
+++ b/xen/common/device_tree.c
@@ -154,7 +154,7 @@ static bool_t __init device_tree_node_compatible(const void *fdt, int node,
     return 0;
 }
 
-static void __init get_val(const u32 **cell, u32 cells, u64 *val)
+static void __init get_val(const __be32 **cell, u32 cells, u64 *val)
 {
     *val = 0;
 
@@ -168,7 +168,7 @@ static void __init get_val(const u32 **cell, u32 cells, u64 *val)
     }
 }
 
-static void __init device_tree_get_reg(const u32 **cell, u32 address_cells,
+static void __init device_tree_get_reg(const __be32 **cell, u32 address_cells,
                                        u32 size_cells, u64 *start, u64 *size)
 {
     get_val(cell, address_cells, start);
@@ -327,7 +327,7 @@ static void __init process_memory_node(const void *fdt, int node,
     const struct fdt_property *prop;
     int i;
     int banks;
-    const u32 *cell;
+    const __be32 *cell;
     paddr_t start, size;
     u32 reg_cells = address_cells + size_cells;
 
@@ -345,7 +345,7 @@ static void __init process_memory_node(const void *fdt, int node,
         return;
     }
 
-    cell = (const u32 *)prop->data;
+    cell = (const __be32 *)prop->data;
     banks = fdt32_to_cpu(prop->len) / (reg_cells * sizeof (u32));
 
     for ( i = 0; i < banks && early_info.mem.nr_banks < NR_MEM_BANKS; i++ )
@@ -396,7 +396,7 @@ static void __init process_multiboot_node(const void *fdt, int node,
                                           u32 address_cells, u32 size_cells)
 {
     const struct fdt_property *prop;
-    const u32 *cell;
+    const __be32 *cell;
     int nr;
     struct dt_mb_module *mod;
     int len;
@@ -418,7 +418,7 @@ static void __init process_multiboot_node(const void *fdt, int node,
         early_panic("fdt: node `%s': `reg` property length is too short\n",
                     name);
 
-    cell = (const u32 *)prop->data;
+    cell = (const __be32 *)prop->data;
     device_tree_get_reg(&cell, address_cells, size_cells,
                         &mod->start, &mod->size);
 
-- 
1.7.10.4

  parent reply	other threads:[~2013-09-13 12:49 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-09-13 12:49 [PATCH v4 00/27] Allow Xen to boot with a raw device tree Julien Grall
2013-09-13 12:49 ` [PATCH v4 01/27] xen/dts: Constify device_tree_flattened Julien Grall
2013-09-13 12:49 ` [PATCH v4 02/27] xen/dts: Prefix device tree macro by dt_ Julien Grall
2013-09-13 12:49 ` [PATCH v4 03/27] xen/dts: Don't add a fake property "name" in the device tree Julien Grall
2013-09-13 12:49 ` [PATCH v4 04/27] xen/dts: Add new helpers to use " Julien Grall
2013-09-13 12:49 ` [PATCH v4 05/27] xen: Use the right string comparison function in " Julien Grall
2013-09-13 12:49 ` [PATCH v4 06/27] xen/dts: Remove device_get_reg call in process_cpu_node Julien Grall
2013-09-13 12:49 ` [PATCH v4 07/27] xen/dts: Check "reg" property length in process_multiboot_node Julien Grall
2013-09-13 12:49 ` [PATCH v4 08/27] xen/dts: Check the CPU ID is not greater than NR_CPUS Julien Grall
2013-09-13 12:49 ` [PATCH v4 09/27] xen/video: hdlcd: Convert the driver to the new device tree API Julien Grall
2013-09-13 12:49 ` [PATCH v4 10/27] xen/video: hdlcd: Use early_printk instead of printk Julien Grall
2013-09-13 12:49 ` [PATCH v4 11/27] xen/arm: Use dt_device_match to avoid multiple if conditions Julien Grall
2013-09-13 12:49 ` [PATCH v4 12/27] xen/dts: dt_find_interrupt_controller: accept multiple compatible strings Julien Grall
2013-09-13 12:49 ` [PATCH v4 13/27] xen/arm: Build DOM0 FDT by browsing the device tree structure Julien Grall
2013-09-13 12:49 ` [PATCH v4 14/27] xen/arm: Don't map disabled device in DOM0 Julien Grall
2013-09-13 12:49 ` [PATCH v4 15/27] xen/arm: Create a fake PSCI node in dom0 device tree Julien Grall
2013-09-13 12:49 ` [PATCH v4 16/27] xen/arm: Create a fake cpus " Julien Grall
2013-09-13 12:49 ` [PATCH v4 17/27] xen/arm: Create a fake GIC " Julien Grall
2013-09-13 12:49 ` [PATCH v4 18/27] xen/arm: Create a fake timer " Julien Grall
2013-09-13 12:49 ` [PATCH v4 19/27] xen/arm: Add new platform specific callback device_is_blacklist Julien Grall
2013-09-13 12:49 ` [PATCH v4 20/27] xen/arm: Remove devices used by Xen from dom0 device tree Julien Grall
2013-09-13 12:49 ` [PATCH v4 21/27] xen/arm: vexpress: Blacklist a list of board specific devices Julien Grall
2013-09-13 12:49 ` [PATCH v4 22/27] xen/arm: exynos5: Blacklist MCT device Julien Grall
2013-09-13 12:49 ` [PATCH v4 23/27] xen/dts: Clean up the exported API for device tree Julien Grall
2013-09-13 12:49 ` Julien Grall [this message]
2013-09-13 12:49 ` [PATCH v4 25/27] xen/dts: replace get_val by dt_next_cell Julien Grall
2013-09-13 12:49 ` [PATCH v4 26/27] xen/arm: Check if the device is available before using it Julien Grall
2013-09-13 12:49 ` [PATCH v4 27/27] ARM: parse separate DT properties for different commandlines Julien Grall
2013-09-17 14:43 ` [PATCH v4 00/27] Allow Xen to boot with a raw device tree Ian Campbell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1379076574-28316-25-git-send-email-julien.grall@linaro.org \
    --to=julien.grall@linaro.org \
    --cc=andre.przywara@linaro.org \
    --cc=ian.campbell@citrix.com \
    --cc=patches@linaro.org \
    --cc=stefano.stabellini@eu.citrix.com \
    --cc=xen-devel@lists.xen.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).