* [PATCH] xl: fix `xl cpupool-list' behavior in case no pool name is provided
@ 2013-09-11 11:06 Dario Faggioli
2013-09-11 11:13 ` Juergen Gross
0 siblings, 1 reply; 8+ messages in thread
From: Dario Faggioli @ 2013-09-11 11:06 UTC (permalink / raw)
To: xen-devel; +Cc: George Dunlap, Ian Jackson, Juergen Gross, Ian Campbell
since it errors out, asking for at least one argument, and does
not display any useful output, which is wrong (we want the list
and the info about all the existing cpupools).
IOW, the output is as follows:
~# xl cpupool-list -c
'xl cpupool-list' requires at least 1 argument.
...
While it should be as follows:
~# xl cpupool-list -c
Name CPU list
Pool-0 0,1,2,3,4,5,6,7,8,9,10,11,12,13,14,15
Signed-off-by: Dario Faggioli <dario.faggioli@citrix.com>
---
tools/libxl/xl_cmdimpl.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/libxl/xl_cmdimpl.c b/tools/libxl/xl_cmdimpl.c
index 884f050..35b3e29 100644
--- a/tools/libxl/xl_cmdimpl.c
+++ b/tools/libxl/xl_cmdimpl.c
@@ -6570,7 +6570,7 @@ int main_cpupoollist(int argc, char **argv)
char *name;
int ret = 0;
- SWITCH_FOREACH_OPT(opt, "hc", opts, "cpupool-list", 1) {
+ SWITCH_FOREACH_OPT(opt, "hc", opts, "cpupool-list", 0) {
case 'c':
opt_cpus = 1;
break;
^ permalink raw reply related [flat|nested] 8+ messages in thread* Re: [PATCH] xl: fix `xl cpupool-list' behavior in case no pool name is provided
2013-09-11 11:06 [PATCH] xl: fix `xl cpupool-list' behavior in case no pool name is provided Dario Faggioli
@ 2013-09-11 11:13 ` Juergen Gross
2013-09-13 9:51 ` Dario Faggioli
2013-09-13 12:35 ` Ian Campbell
0 siblings, 2 replies; 8+ messages in thread
From: Juergen Gross @ 2013-09-11 11:13 UTC (permalink / raw)
To: Dario Faggioli; +Cc: George Dunlap, Ian Jackson, Ian Campbell, xen-devel
On 11.09.2013 13:06, Dario Faggioli wrote:
> since it errors out, asking for at least one argument, and does
> not display any useful output, which is wrong (we want the list
> and the info about all the existing cpupools).
>
> IOW, the output is as follows:
>
> ~# xl cpupool-list -c
> 'xl cpupool-list' requires at least 1 argument.
> ...
>
> While it should be as follows:
>
> ~# xl cpupool-list -c
> Name CPU list
> Pool-0 0,1,2,3,4,5,6,7,8,9,10,11,12,13,14,15
>
> Signed-off-by: Dario Faggioli <dario.faggioli@citrix.com>
Acked-by: Juergen Gross <juergen.gross@ts.fujitsu.com>
> ---
> tools/libxl/xl_cmdimpl.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/libxl/xl_cmdimpl.c b/tools/libxl/xl_cmdimpl.c
> index 884f050..35b3e29 100644
> --- a/tools/libxl/xl_cmdimpl.c
> +++ b/tools/libxl/xl_cmdimpl.c
> @@ -6570,7 +6570,7 @@ int main_cpupoollist(int argc, char **argv)
> char *name;
> int ret = 0;
>
> - SWITCH_FOREACH_OPT(opt, "hc", opts, "cpupool-list", 1) {
> + SWITCH_FOREACH_OPT(opt, "hc", opts, "cpupool-list", 0) {
> case 'c':
> opt_cpus = 1;
> break;
>
>
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xen.org
> http://lists.xen.org/xen-devel
>
>
--
Juergen Gross Principal Developer Operating Systems
PBG PDG ES&S SWE OS6 Telephone: +49 (0) 89 3222 2967
Fujitsu Technology Solutions e-mail: juergen.gross@ts.fujitsu.com
Domagkstr. 28 Internet: ts.fujitsu.com
D-80807 Muenchen Company details: ts.fujitsu.com/imprint.html
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [PATCH] xl: fix `xl cpupool-list' behavior in case no pool name is provided
2013-09-11 11:13 ` Juergen Gross
@ 2013-09-13 9:51 ` Dario Faggioli
2013-09-13 12:35 ` Ian Campbell
1 sibling, 0 replies; 8+ messages in thread
From: Dario Faggioli @ 2013-09-13 9:51 UTC (permalink / raw)
To: Juergen Gross; +Cc: George Dunlap, Ian Jackson, Ian Campbell, xen-devel
[-- Attachment #1.1: Type: text/plain, Size: 1162 bytes --]
On mer, 2013-09-11 at 13:13 +0200, Juergen Gross wrote:
> On 11.09.2013 13:06, Dario Faggioli wrote:
> > since it errors out, asking for at least one argument, and does
> > not display any useful output, which is wrong (we want the list
> > and the info about all the existing cpupools).
> >
> > IOW, the output is as follows:
> >
> > ~# xl cpupool-list -c
> > 'xl cpupool-list' requires at least 1 argument.
> > ...
> >
> > While it should be as follows:
> >
> > ~# xl cpupool-list -c
> > Name CPU list
> > Pool-0 0,1,2,3,4,5,6,7,8,9,10,11,12,13,14,15
> >
> > Signed-off-by: Dario Faggioli <dario.faggioli@citrix.com>
>
> Acked-by: Juergen Gross <juergen.gross@ts.fujitsu.com>
>
BTW, I just checked, and this affects 4.3.0 too.
I'll request a backport for this patch as soon as it hits the unstable
repository.
Regards,
Dario
--
<<This happens because I choose it to happen!>> (Raistlin Majere)
-----------------------------------------------------------------
Dario Faggioli, Ph.D, http://about.me/dario.faggioli
Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK)
[-- Attachment #1.2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 198 bytes --]
[-- Attachment #2: Type: text/plain, Size: 126 bytes --]
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] xl: fix `xl cpupool-list' behavior in case no pool name is provided
2013-09-11 11:13 ` Juergen Gross
2013-09-13 9:51 ` Dario Faggioli
@ 2013-09-13 12:35 ` Ian Campbell
2013-09-13 13:27 ` Backport request for 4.3.x [was: Re: [PATCH] xl: fix `xl cpupool-list' behavior in case no pool name is provided] Dario Faggioli
1 sibling, 1 reply; 8+ messages in thread
From: Ian Campbell @ 2013-09-13 12:35 UTC (permalink / raw)
To: Juergen Gross; +Cc: George Dunlap, Ian Jackson, Dario Faggioli, xen-devel
On Wed, 2013-09-11 at 13:13 +0200, Juergen Gross wrote:
> On 11.09.2013 13:06, Dario Faggioli wrote:
> > since it errors out, asking for at least one argument, and does
> > not display any useful output, which is wrong (we want the list
> > and the info about all the existing cpupools).
> >
> > IOW, the output is as follows:
> >
> > ~# xl cpupool-list -c
> > 'xl cpupool-list' requires at least 1 argument.
> > ...
> >
> > While it should be as follows:
> >
> > ~# xl cpupool-list -c
> > Name CPU list
> > Pool-0 0,1,2,3,4,5,6,7,8,9,10,11,12,13,14,15
> >
> > Signed-off-by: Dario Faggioli <dario.faggioli@citrix.com>
>
> Acked-by: Juergen Gross <juergen.gross@ts.fujitsu.com>
Applied, thanks
^ permalink raw reply [flat|nested] 8+ messages in thread
* Backport request for 4.3.x [was: Re: [PATCH] xl: fix `xl cpupool-list' behavior in case no pool name is provided]
2013-09-13 12:35 ` Ian Campbell
@ 2013-09-13 13:27 ` Dario Faggioli
2013-09-13 13:48 ` Ian Jackson
0 siblings, 1 reply; 8+ messages in thread
From: Dario Faggioli @ 2013-09-13 13:27 UTC (permalink / raw)
To: Jan Beulich; +Cc: Ian Jackson, Juergen Gross, xen-devel
[-- Attachment #1.1: Type: text/plain, Size: 1546 bytes --]
On ven, 2013-09-13 at 13:35 +0100, Ian Campbell wrote:
> On Wed, 2013-09-11 at 13:13 +0200, Juergen Gross wrote:
> > On 11.09.2013 13:06, Dario Faggioli wrote:
> > > since it errors out, asking for at least one argument, and does
> > > not display any useful output, which is wrong (we want the list
> > > and the info about all the existing cpupools).
> > >
> > > IOW, the output is as follows:
> > >
> > > ~# xl cpupool-list -c
> > > 'xl cpupool-list' requires at least 1 argument.
> > > ...
> > >
> > > While it should be as follows:
> > >
> > > ~# xl cpupool-list -c
> > > Name CPU list
> > > Pool-0 0,1,2,3,4,5,6,7,8,9,10,11,12,13,14,15
> > >
> > > Signed-off-by: Dario Faggioli <dario.faggioli@citrix.com>
> >
> > Acked-by: Juergen Gross <juergen.gross@ts.fujitsu.com>
>
> Applied, thanks
>
Thanks to you.
As already said, I verified that this bug also affects Xen 4.3. I'm
therefore requesting the backport of this patch, that is now commit
3998afdbf99959582dcd9f9f4df5a6fe7ce4ded8, to there.
`git cherry-pick'ing it from staging-4.3 works fine.
While at it, I tried 4.2.3 as well and that does not show the bug, so no
need to backport to anything farther than 4.3.
Thanks and Regards,
Dario
--
<<This happens because I choose it to happen!>> (Raistlin Majere)
-----------------------------------------------------------------
Dario Faggioli, Ph.D, http://about.me/dario.faggioli
Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK)
[-- Attachment #1.2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 198 bytes --]
[-- Attachment #2: Type: text/plain, Size: 126 bytes --]
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
^ permalink raw reply [flat|nested] 8+ messages in thread
* Backport request for 4.3.x [was: Re: [PATCH] xl: fix `xl cpupool-list' behavior in case no pool name is provided]
2013-09-13 13:27 ` Backport request for 4.3.x [was: Re: [PATCH] xl: fix `xl cpupool-list' behavior in case no pool name is provided] Dario Faggioli
@ 2013-09-13 13:48 ` Ian Jackson
2013-09-13 14:01 ` Dario Faggioli
2013-10-11 17:55 ` Ian Jackson
0 siblings, 2 replies; 8+ messages in thread
From: Ian Jackson @ 2013-09-13 13:48 UTC (permalink / raw)
To: Dario Faggioli; +Cc: Juergen Gross, Jan Beulich, xen-devel
Dario Faggioli writes ("Backport request for 4.3.x [was: Re: [Xen-devel] [PATCH] xl: fix `xl cpupool-list' behavior in case no pool name is provided]"):
> As already said, I verified that this bug also affects Xen 4.3. I'm
> therefore requesting the backport of this patch, that is now commit
> 3998afdbf99959582dcd9f9f4df5a6fe7ce4ded8, to there.
I have added this to my list. I'm not backporting it just yet because
it should have some time to settle in unstable.
Ian.
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: Backport request for 4.3.x [was: Re: [PATCH] xl: fix `xl cpupool-list' behavior in case no pool name is provided]
2013-09-13 13:48 ` Ian Jackson
@ 2013-09-13 14:01 ` Dario Faggioli
2013-10-11 17:55 ` Ian Jackson
1 sibling, 0 replies; 8+ messages in thread
From: Dario Faggioli @ 2013-09-13 14:01 UTC (permalink / raw)
To: Ian Jackson; +Cc: Juergen Gross, Jan Beulich, xen-devel
[-- Attachment #1.1: Type: text/plain, Size: 855 bytes --]
On ven, 2013-09-13 at 14:48 +0100, Ian Jackson wrote:
> Dario Faggioli writes ("Backport request for 4.3.x [was: Re: [Xen-devel] [PATCH] xl: fix `xl cpupool-list' behavior in case no pool name is provided]"):
> > As already said, I verified that this bug also affects Xen 4.3. I'm
> > therefore requesting the backport of this patch, that is now commit
> > 3998afdbf99959582dcd9f9f4df5a6fe7ce4ded8, to there.
>
> I have added this to my list.
>
Thanks.
> I'm not backporting it just yet because
> it should have some time to settle in unstable.
>
Sure!
Regards,
Dario
--
<<This happens because I choose it to happen!>> (Raistlin Majere)
-----------------------------------------------------------------
Dario Faggioli, Ph.D, http://about.me/dario.faggioli
Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK)
[-- Attachment #1.2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 198 bytes --]
[-- Attachment #2: Type: text/plain, Size: 126 bytes --]
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
^ permalink raw reply [flat|nested] 8+ messages in thread* Backport request for 4.3.x [was: Re: [PATCH] xl: fix `xl cpupool-list' behavior in case no pool name is provided]
2013-09-13 13:48 ` Ian Jackson
2013-09-13 14:01 ` Dario Faggioli
@ 2013-10-11 17:55 ` Ian Jackson
1 sibling, 0 replies; 8+ messages in thread
From: Ian Jackson @ 2013-10-11 17:55 UTC (permalink / raw)
To: Dario Faggioli, Jan Beulich, Juergen Gross, xen-devel
Ian Jackson writes ("Backport request for 4.3.x [was: Re: [Xen-devel] [PATCH] xl: fix `xl cpupool-list' behavior in case no pool name is provided]"):
> Dario Faggioli writes ("Backport request for 4.3.x [was: Re: [Xen-devel] [PATCH] xl: fix `xl cpupool-list' behavior in case no pool name is provided]"):
> > As already said, I verified that this bug also affects Xen 4.3. I'm
> > therefore requesting the backport of this patch, that is now commit
> > 3998afdbf99959582dcd9f9f4df5a6fe7ce4ded8, to there.
>
> I have added this to my list. I'm not backporting it just yet because
> it should have some time to settle in unstable.
This is now in staging-4.3.
Ian.
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2013-10-11 17:55 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-09-11 11:06 [PATCH] xl: fix `xl cpupool-list' behavior in case no pool name is provided Dario Faggioli
2013-09-11 11:13 ` Juergen Gross
2013-09-13 9:51 ` Dario Faggioli
2013-09-13 12:35 ` Ian Campbell
2013-09-13 13:27 ` Backport request for 4.3.x [was: Re: [PATCH] xl: fix `xl cpupool-list' behavior in case no pool name is provided] Dario Faggioli
2013-09-13 13:48 ` Ian Jackson
2013-09-13 14:01 ` Dario Faggioli
2013-10-11 17:55 ` Ian Jackson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).