From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dario Faggioli Subject: Re: [PATCH v2 5/5] xl: test script for the cpumap parser (for vCPU pinning) Date: Mon, 16 Sep 2013 20:50:54 +0200 Message-ID: <1379357454.6095.172.camel@Solace> References: <20130906154725.10218.45008.stgit@hit-nxdomain.opendns.com> <20130906155600.10218.27695.stgit@hit-nxdomain.opendns.com> <21039.23644.878700.819950@mariner.uk.xensource.com> <1378892977.10928.49.camel@kazak.uk.xensource.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============9050449388180737539==" Return-path: In-Reply-To: <1378892977.10928.49.camel@kazak.uk.xensource.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Campbell Cc: George Dunlap , Ian Jackson , xen-devel@lists.xen.org List-Id: xen-devel@lists.xenproject.org --===============9050449388180737539== Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="=-k9iyTaQ/urLwF/YInp6Z" --=-k9iyTaQ/urLwF/YInp6Z Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On mer, 2013-09-11 at 10:49 +0100, Ian Campbell wrote: > On Tue, 2013-09-10 at 18:52 +0100, Ian Jackson wrote: > > Dario Faggioli writes ("[PATCH v2 5/5] xl: test script for the cpumap p= arser (for vCPU pinning)"): > > > This commit introduces "check-xl-vcpupin-parse" for helping > > > verifying and debugging the (v)CPU bitmap parsing code in xl. > > >=20 > > > The script runs "xl -N vcpu-pin 0 all " > > > repeatedly, with various input strings, and checks that the > > > output is as expected. > [...] > > I think it would be better, TBH, if you separated out the test > > generation from the execution. check-xl-vif-parse et al have the test > > data as an annex to the harness material, but you could have it in a > > separate file which you could have a script to generate. >=20 > Support for testing specific strings which have been reported as buggy > in the past would be useful too. >=20 Done in v3 (just posted) via passing a "-s " option to the script. Dario --=20 <> (Raistlin Majere) ----------------------------------------------------------------- Dario Faggioli, Ph.D, http://about.me/dario.faggioli Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK) --=-k9iyTaQ/urLwF/YInp6Z Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.14 (GNU/Linux) iEYEABECAAYFAlI3Uw4ACgkQk4XaBE3IOsS3uwCfUG1FpSMPrs+6MSNKYxAB2WQi J+sAnjI2L77Yd2+6wnGsEE0oaUvlRNfS =NIyN -----END PGP SIGNATURE----- --=-k9iyTaQ/urLwF/YInp6Z-- --===============9050449388180737539== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel --===============9050449388180737539==--