From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dario Faggioli Subject: Re: [PATCH RFC v2 1/7] xen/vNUMA: vNUMA support for PV guests. Date: Tue, 17 Sep 2013 09:11:18 +0200 Message-ID: <1379401878.32441.42.camel@Abyss> References: <1379062190-13720-1-git-send-email-ufimtseva@gmail.com> <52381B4C02000078000F3DD5@nat28.tlf.novell.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1491615295900067714==" Return-path: In-Reply-To: <52381B4C02000078000F3DD5@nat28.tlf.novell.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Jan Beulich Cc: Keir Fraser , Li Yechen , George Dunlap , Matt Wilson , Stefano Stabellini , "xen-devel@lists.xen.org" , Elena Ufimtseva List-Id: xen-devel@lists.xenproject.org --===============1491615295900067714== Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="=-vUVQ2uZ3b0pdmcHE7+Jq" --=-vUVQ2uZ3b0pdmcHE7+Jq Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On mar, 2013-09-17 at 08:05 +0100, Jan Beulich wrote: > >>> On 17.09.13 at 08:44, Elena Ufimtseva wrote: >=20 > Please don't top post. >=20 > > George, after talking to Dario, I think the max number of physical > > nodes will not exceed 256. Dario's automatic NUMA > > placement work with this number and I think it can be easily u8. > > Unless anyone has other thoughts. >=20 > With nr_vnodes being uint16_t, the vnode numbers should be > too. Limiting them to u8 would possibly be even better, but then > nr_vnodes would better be unsigned int (perhaps that was the > case from the beginning, regardless of the types used for the > arrays). >=20 > The pnode array surely can also be uint8_t for the time being, > considering that there are other places where node IDs are > limited to 8 bits. >=20 All agreed. > And with struct acpi_table_slit having just 8-bit distances, there's > no apparent reason why the virtual distances can't be 8 bits too. >=20 > But - all this is only for the internal representations. Anything in > the public interface should be wide enough to allow future > extension. >=20 And, in fact, 'node_to_node_distance' in xen/include/public/sysctl.h (http://xenbits.xen.org/gitweb/?p=3Dxen.git;a=3Dblob;f=3Dxen/include/public= /sysctl.h) is uint32. Dario --=20 <> (Raistlin Majere) ----------------------------------------------------------------- Dario Faggioli, Ph.D, http://about.me/dario.faggioli Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK) --=-vUVQ2uZ3b0pdmcHE7+Jq Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.14 (GNU/Linux) iEYEABECAAYFAlI4AJYACgkQk4XaBE3IOsQ3MQCgl7SsJAwtfwDH/sThJkGrn1zQ rTsAniVpF8a5JADuxf+bxEDp+TxiUpPx =Vwdl -----END PGP SIGNATURE----- --=-vUVQ2uZ3b0pdmcHE7+Jq-- --===============1491615295900067714== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel --===============1491615295900067714==--