From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dario Faggioli Subject: Re: [PATCH RFC v2 2/2] linux/vnuma: Enables NUMA for domu PV guest Date: Tue, 17 Sep 2013 16:37:20 +0200 Message-ID: <1379428640.18543.4.camel@Abyss> References: <1379406841-7441-1-git-send-email-ufimtseva@gmail.com> <1379406841-7441-3-git-send-email-ufimtseva@gmail.com> <5238645D.8020602@citrix.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============6797777358581064495==" Return-path: In-Reply-To: <5238645D.8020602@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org Cc: Elena Ufimtseva , lccycc123@gmail.com, george.dunlap@eu.citrix.com, xen-devel@lists.xen.org, msw@amazon.com, boris.ostrovsky@oracle.com, anddavid.vrabel@citrix.com List-Id: xen-devel@lists.xenproject.org --===============6797777358581064495== Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="=-TFHZK1DNZFMR6o5k2nld" --=-TFHZK1DNZFMR6o5k2nld Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On mar, 2013-09-17 at 15:17 +0100, David Vrabel wrote: > On 17/09/13 09:34, Elena Ufimtseva wrote: > > After the NUMA topology was received from Xen, > > enable NUMA during boot. Should have CONFIG_NUMA > > enabled in kernel. > >=20 > > Changes since v1: > > - added additional checks for PV guest and hypercall > > support before enablinf NUMA; >=20 > As I said in response to the other patch, I don't think this does the > right thing. >=20 > I think xen_vnuma_support() needs to try the vnuma hypercall and check > it is successful. >=20 That can surely be done, I think. Elena? > > --- a/arch/x86/xen/setup.c > > +++ b/arch/x86/xen/setup.c > > @@ -20,6 +20,7 @@ > > #include > > #include > > #include > > +#include > > =20 > > #include > > #include > > @@ -583,6 +584,9 @@ void __init xen_arch_setup(void) > > WARN_ON(xen_set_default_idle()); > > fiddle_vdso(); > > #ifdef CONFIG_NUMA > > - numa_off =3D 1; > > + if (!xen_initial_domain() && xen_vnuma_support()) >=20 > I don't think there's a need to special case the initial domain here is > there? >=20 This is actually something that Konrad asked, since, apparently, there are AMD machines that just blows up, as Dom0, if this is on. Therefore, since, right now, the status of Elena's work is "just DomUs", we figured this could be fine for now. Of course, the final goal (whether for Elena or for someone else to pick it up) is to be able to enable vNUMA for Dom0 too, at which point we definitely will have to figure out a way to kill this special casing safely... What do you think? Regards, Dario --=20 <> (Raistlin Majere) ----------------------------------------------------------------- Dario Faggioli, Ph.D, http://about.me/dario.faggioli Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK) --=-TFHZK1DNZFMR6o5k2nld Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.14 (GNU/Linux) iEYEABECAAYFAlI4aSAACgkQk4XaBE3IOsQd/gCgk4GTcw0W6SeMGxpU/U9YdKKc 4psAn20UYpi7nPIsGf2WwLv6Hltw5kG8 =4pTe -----END PGP SIGNATURE----- --=-TFHZK1DNZFMR6o5k2nld-- --===============6797777358581064495== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel --===============6797777358581064495==--