From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dario Faggioli Subject: Re: [PATCH RFC v2 1/2] linux/vnuma: vNUMA for PV domu guest Date: Wed, 18 Sep 2013 09:33:45 +0200 Message-ID: <1379489625.18543.30.camel@Abyss> References: <1379406841-7441-1-git-send-email-ufimtseva@gmail.com> <1379406841-7441-2-git-send-email-ufimtseva@gmail.com> <5238657F.3040209@oracle.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============6890561861030185443==" Return-path: In-Reply-To: List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Elena Ufimtseva Cc: Li Yechen , George Dunlap , "xen-devel@lists.xen.org" , Matt Wilson , Boris Ostrovsky , anddavid.vrabel@citrix.com List-Id: xen-devel@lists.xenproject.org --===============6890561861030185443== Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="=-ZmcBw6GM57J09edmSUGG" --=-ZmcBw6GM57J09edmSUGG Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On mer, 2013-09-18 at 02:30 -0400, Elena Ufimtseva wrote: > On Tue, Sep 17, 2013 at 10:21 AM, Boris Ostrovsky > > >> +int __init xen_numa_init(void) > >> +{ [snip] > >> + setup_nr_node_ids(); > >> + /* Setting the cpu, apicid to node */ > >> + for_each_cpu(cpu, cpu_possible_mask) { > >> + set_apicid_to_node(cpu, cpu_to_node[cpu]); > >> + numa_set_node(cpu, cpu_to_node[cpu]); > >> + __apicid_to_node[cpu] =3D cpu_to_node[cpu]; > > > > > > Isn't this what set_apicid_to_node() above will do? >=20 > Yes, exactly the same ) will fix. > I seem to recall that something strange was happening if we do not do this in this way (i.e., calling the same stuff twice, or something like that), isn't it so Elena? If it is, please, explain that in a comment. However, it may well be possible that my recollection is wrong.. In which case, sorry for the noise. Anyway, in general, and both for this series and for the Xen one, I think the code could use a little bit more of commenting (along with the breaking up in paragraphs, as many have already pointed out). I know, I know, too much comments is also bad... Actually, finding the right balance between too few and too much is as much important as it is difficult! :-P Dario --=20 <> (Raistlin Majere) ----------------------------------------------------------------- Dario Faggioli, Ph.D, http://about.me/dario.faggioli Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK) --=-ZmcBw6GM57J09edmSUGG Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.14 (GNU/Linux) iEYEABECAAYFAlI5V1kACgkQk4XaBE3IOsTEhwCfZthJQYug431vm6MDVv6K5u3h ydcAn3VDZqN7L4U3n6LWLDto37wKcH8q =hCiI -----END PGP SIGNATURE----- --=-ZmcBw6GM57J09edmSUGG-- --===============6890561861030185443== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel --===============6890561861030185443==--