Re: [PATCH RFC v2 2/2] linux/vnuma: Enables NUMA for domu PV guest

[Dario Faggioli <dario.faggioli@citrix.com>]

[-- Attachment #1.1: Type: text/plain, Size: 1506 bytes --]

On mar, 2013-09-17 at 04:34 -0400, Elena Ufimtseva wrote:
> diff --git a/arch/x86/xen/setup.c b/arch/x86/xen/setup.c
> index 8f3eea6..2f2d28e 100644
> --- a/arch/x86/xen/setup.c
> +++ b/arch/x86/xen/setup.c
>
>  #include <xen/xen.h>
>  #include <xen/page.h>
> @@ -583,6 +584,9 @@ void __init xen_arch_setup(void)
>  	WARN_ON(xen_set_default_idle());
>  	fiddle_vdso();
>  #ifdef CONFIG_NUMA
> -	numa_off = 1;
> +	if (!xen_initial_domain() && xen_vnuma_support())
> +		numa_off = 0;
> +	else
> +		numa_off = 1;
>  #endif
>  }
I can't be positive about this, but I think that, if we go for David's
suggestions of:
 - testing for the hypercall being actually supported,
 - calling dummy_numa_init() directly from within xen_numa_init (in 
   case something go wrong), instead of going through all the 
   alternatives from x86_numa_init()

then we can even get rid of this numa_off=0|1 all together (which is
also something David was already suggesting, AFAICR).

It would be nice to know what the issue was at the time they had to
introduce this, and whether we can get to do some testing on any of the
boxes where it was exploding.

I'll investigate more, in the meanwhile, does anyone had any clue?

Dario

-- 
<<This happens because I choose it to happen!>> (Raistlin Majere)
-----------------------------------------------------------------
Dario Faggioli, Ph.D, http://about.me/dario.faggioli
Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK)


[-- Attachment #1.2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 198 bytes --]

[-- Attachment #2: Type: text/plain, Size: 126 bytes --]

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel