From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dario Faggioli Subject: Re: [PATCH RFC v2 2/2] linux/vnuma: Enables NUMA for domu PV guest Date: Wed, 18 Sep 2013 17:14:49 +0200 Message-ID: <1379517289.18543.154.camel@Abyss> References: <1379406841-7441-1-git-send-email-ufimtseva@gmail.com> <1379406841-7441-3-git-send-email-ufimtseva@gmail.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============7893258833519198838==" Return-path: In-Reply-To: <1379406841-7441-3-git-send-email-ufimtseva@gmail.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Elena Ufimtseva Cc: lccycc123@gmail.com, george.dunlap@eu.citrix.com, xen-devel@lists.xen.org, david.vrabel@citrix.com, msw@amazon.com, boris.ostrovsky@oracle.com List-Id: xen-devel@lists.xenproject.org --===============7893258833519198838== Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="=-4vIKcLrCW0Zh89w0Et9L" --=-4vIKcLrCW0Zh89w0Et9L Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On mar, 2013-09-17 at 04:34 -0400, Elena Ufimtseva wrote: > diff --git a/arch/x86/xen/setup.c b/arch/x86/xen/setup.c > index 8f3eea6..2f2d28e 100644 > --- a/arch/x86/xen/setup.c > +++ b/arch/x86/xen/setup.c > > #include > #include > @@ -583,6 +584,9 @@ void __init xen_arch_setup(void) > WARN_ON(xen_set_default_idle()); > fiddle_vdso(); > #ifdef CONFIG_NUMA > - numa_off =3D 1; > + if (!xen_initial_domain() && xen_vnuma_support()) > + numa_off =3D 0; > + else > + numa_off =3D 1; > #endif > } I can't be positive about this, but I think that, if we go for David's suggestions of: - testing for the hypercall being actually supported, - calling dummy_numa_init() directly from within xen_numa_init (in=20 case something go wrong), instead of going through all the=20 alternatives from x86_numa_init() then we can even get rid of this numa_off=3D0|1 all together (which is also something David was already suggesting, AFAICR). It would be nice to know what the issue was at the time they had to introduce this, and whether we can get to do some testing on any of the boxes where it was exploding. I'll investigate more, in the meanwhile, does anyone had any clue? Dario --=20 <> (Raistlin Majere) ----------------------------------------------------------------- Dario Faggioli, Ph.D, http://about.me/dario.faggioli Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK) --=-4vIKcLrCW0Zh89w0Et9L Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.14 (GNU/Linux) iEYEABECAAYFAlI5w2kACgkQk4XaBE3IOsQBiwCeKX1mpBYVcXKaT0m/iS366cm3 53gAoKONs2UzjYfKddCSYbKoViRFWWhC =/lIr -----END PGP SIGNATURE----- --=-4vIKcLrCW0Zh89w0Et9L-- --===============7893258833519198838== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel --===============7893258833519198838==--