From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dario Faggioli Subject: Re: [PATCH RFC v2 0/2] linux/vnuma: vNUMA PV guest support introduction Date: Wed, 18 Sep 2013 18:16:38 +0200 Message-ID: <1379520998.18543.183.camel@Abyss> References: <1379406841-7441-1-git-send-email-ufimtseva@gmail.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============3115105619882620062==" Return-path: In-Reply-To: <1379406841-7441-1-git-send-email-ufimtseva@gmail.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Elena Ufimtseva Cc: lccycc123@gmail.com, george.dunlap@eu.citrix.com, xen-devel@lists.xen.org, david.vrabel@citrix.com, msw@amazon.com, boris.ostrovsky@oracle.com List-Id: xen-devel@lists.xenproject.org --===============3115105619882620062== Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="=-L/T3E80Mc+B1GvCppzIi" --=-L/T3E80Mc+B1GvCppzIi Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On mar, 2013-09-17 at 04:33 -0400, Elena Ufimtseva wrote: > This patchset introduces vNUMA for PV domU guest. >=20 I'm picky and I know it, but I think domU and guest are synonyms... Having just one of them should be enough. Also, the subject line "linux/vnuma: vNUMA...". It is indeed a good practice to indicate to what component and subsystem the patches applies to. However, in this case, I don't think havin "linux/" there adds much, since you'll be sending these mainly in LKML (although, yes, they'll go on xen-devel too, but I honestly think we can manage). Regarding the "/vnuma" part, well, vnuma isn't really a subsystem. Actually, it does not even exist before this series, so again, I won't put it there. Actually, from a Linux developer/maintainer point of view, these patches are about Xen, so something like "xen:..." or "x86/xen:" is probably better > Enables PV guest to discover NUMA topology provided by Xen > and initializes NUMA topology on boot. XENMEM subop hypercall > is used to retreive information from Xen.=20 > The fact that this happens during the regular x86 NUMA initialization phase (i.e., in x86_numa_init()) is worth mentioning here. > Xen provides number=20 > of NUMA nodes, memory regions (start and end pfn) constructed=20 > based on e820 domU map, distance table and cpu to node map. i > xen_numa_init is called to setup NUMA related structures.=20 > To enable this mechanism, kernel should be compiled as PV guest > with CONFIG_NUMA=3Dy and Xen should support vNUMA functionality=20 > (patchset http://lists.xenproject.org/archives/html/xen-devel/2013-09/msg= 01337.html ). > =20 This is fine. Perhaps I'd add something about future plans, which are to extend this to work for Dom0 too. Dario --=20 <> (Raistlin Majere) ----------------------------------------------------------------- Dario Faggioli, Ph.D, http://about.me/dario.faggioli Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK) --=-L/T3E80Mc+B1GvCppzIi Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.14 (GNU/Linux) iEYEABECAAYFAlI50eYACgkQk4XaBE3IOsTH9ACgnMMzDa5swWy3PpTZpQrSIfK+ bLAAn2a0w2q7zggH30LasOOODwNFOh+6 =QY8L -----END PGP SIGNATURE----- --=-L/T3E80Mc+B1GvCppzIi-- --===============3115105619882620062== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel --===============3115105619882620062==--