From: Ian Campbell <ian.campbell@citrix.com>
To: Tim Deegan <tim@xen.org>
Cc: julien.grall@citrix.com, stefano.stabellini@eu.citrix.com,
xen-devel@lists.xen.org
Subject: Re: [PATCH RFC 5/7] xen: arm: rewrite start of day page table and cpu bring up
Date: Fri, 20 Sep 2013 18:09:58 +0100 [thread overview]
Message-ID: <1379696998.8994.43.camel@hastur.hellion.org.uk> (raw)
In-Reply-To: <20130919113652.GF52431@ocelot.phlegethon.org>
On Thu, 2013-09-19 at 12:36 +0100, Tim Deegan wrote:
>
> > - PRINT("- Ready -\r\n")
> > +1: PRINT("- Ready -\r\n")
>
> Again, I'd prefer the label to go above (logically connected to the end
> of the block being skipped) to avoid the risk of someone adding new code
> just before '- Ready -' and having it be accidentally skipped.
I've been half thinking about defining some macros:
#define BOOT_CPU_START(name) cbnz x22, boot_cpu_#name_skip
#define BOOT_CPU_END(name) boot_cpu_#name_skip:
So we would end up with:
BOOT_CPU_START(build_fixmap)
/* All the stuff to build the fixmap */
BOOT_CPU_END(build_fixmap)
I'm in two minds about whether this is an improvement though.
Ian.
next prev parent reply other threads:[~2013-09-20 17:09 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-17 1:37 [PATCH RFC 0/N] xen: arm: rework early bring up Ian Campbell
2013-09-17 1:40 ` [PATCH RFC 1/7] xen: arm: Load xen under 4GB on 32-bit Ian Campbell
2013-09-18 15:44 ` Julien Grall
2013-09-19 9:21 ` Tim Deegan
2013-09-17 1:40 ` [PATCH RFC 2/7] xen: arm: Log the raw MIDR on boot Ian Campbell
2013-09-17 12:05 ` Julien Grall
2013-09-19 9:21 ` Tim Deegan
2013-09-17 1:40 ` [PATCH RFC 3/7] xen: arm: make sure we stay within the memory bank during mm setup Ian Campbell
2013-09-17 12:19 ` Julien Grall
2013-09-19 9:27 ` Tim Deegan
2013-09-17 1:40 ` [PATCH RFC 4/7] xen: arm: add two new device tree helpers Ian Campbell
2013-09-17 13:05 ` Julien Grall
2013-09-18 17:11 ` Julien Grall
2013-09-18 17:14 ` Ian Campbell
2013-09-17 1:40 ` [PATCH RFC 5/7] xen: arm: rewrite start of day page table and cpu bring up Ian Campbell
2013-09-17 16:18 ` Julien Grall
2013-09-17 16:36 ` Ian Campbell
2013-09-17 16:55 ` Julien Grall
2013-09-17 18:30 ` Andre Przywara
2013-09-17 19:19 ` Ian Campbell
2013-09-18 13:57 ` Julien Grall
2013-09-18 15:12 ` Ian Campbell
2013-09-18 17:06 ` Julien Grall
2013-09-18 17:14 ` Ian Campbell
2013-09-19 11:36 ` Tim Deegan
2013-09-20 17:09 ` Ian Campbell [this message]
2013-09-20 17:16 ` Ian Campbell
2013-09-19 13:36 ` Tim Deegan
2013-09-17 1:40 ` [PATCH RFC 6/7] xen: arm: configure TCR_EL2 for 40 bit physical address space Ian Campbell
2013-09-18 15:50 ` Julien Grall
2013-09-19 13:42 ` Tim Deegan
2013-09-17 1:40 ` [PATCH RFC 7/7] xen: arm: split cpu0's domheap mapping PTs out from xen_second Ian Campbell
2013-09-19 13:47 ` Tim Deegan
2013-09-17 11:34 ` [PATCH RFC 0/N] xen: arm: rework early bring up Julien Grall
2013-09-17 12:43 ` Ian Campbell
2013-09-18 13:40 ` Julien Grall
2013-09-18 17:33 ` Julien Grall
2013-09-18 19:22 ` Ian Campbell
2013-09-18 19:24 ` Ian Campbell
2013-09-18 20:00 ` Julien Grall
2013-09-18 20:22 ` Ian Campbell
2013-09-18 21:14 ` Julien Grall
2013-09-18 21:28 ` Ian Campbell
2013-09-19 14:49 ` Julien Grall
2013-09-19 15:51 ` Ian Campbell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1379696998.8994.43.camel@hastur.hellion.org.uk \
--to=ian.campbell@citrix.com \
--cc=julien.grall@citrix.com \
--cc=stefano.stabellini@eu.citrix.com \
--cc=tim@xen.org \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).