* [PATCH] ns16550: Use correct #define symbol for HAS_IOPORTS
@ 2013-09-23 17:25 Andrew Cooper
2013-09-24 9:29 ` Ian Campbell
0 siblings, 1 reply; 2+ messages in thread
From: Andrew Cooper @ 2013-09-23 17:25 UTC (permalink / raw)
To: Xen-devel; +Cc: Andrew Cooper, Keir Frser, Ian Campbell, Jan Beulich
CID 1091471, Regression caused by 7c1de0038895cbc75ebd0caffc5b0f3f03c5ad51
This appears to be a typo which causes check_existence() to unconditionally
return 1 in all cases.
Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
CC: Keir Frser <keir@xen.org>
CC: Jan Beulich <jbeulich@suse.com>
CC: Ian Campbell <ian.campbell@citrix.com>
---
xen/drivers/char/ns16550.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/xen/drivers/char/ns16550.c b/xen/drivers/char/ns16550.c
index 5892eb7..9c2cded 100644
--- a/xen/drivers/char/ns16550.c
+++ b/xen/drivers/char/ns16550.c
@@ -503,7 +503,7 @@ static int __init check_existence(struct ns16550 *uart)
{
unsigned char status, scratch, scratch2, scratch3;
-#ifdef HAS_IO_PORTS
+#ifdef HAS_IOPORTS
/*
* We can't poke MMIO UARTs until they get I/O remapped later. Assume that
* if we're getting MMIO UARTs, the arch code knows what it's doing.
--
1.7.10.4
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] ns16550: Use correct #define symbol for HAS_IOPORTS
2013-09-23 17:25 [PATCH] ns16550: Use correct #define symbol for HAS_IOPORTS Andrew Cooper
@ 2013-09-24 9:29 ` Ian Campbell
0 siblings, 0 replies; 2+ messages in thread
From: Ian Campbell @ 2013-09-24 9:29 UTC (permalink / raw)
To: Andrew Cooper; +Cc: Keir Frser, Jan Beulich, Xen-devel
On Mon, 2013-09-23 at 18:25 +0100, Andrew Cooper wrote:
> CID 1091471, Regression caused by 7c1de0038895cbc75ebd0caffc5b0f3f03c5ad51
>
> This appears to be a typo which causes check_existence() to unconditionally
> return 1 in all cases.
>
> Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
> CC: Keir Frser <keir@xen.org>
> CC: Jan Beulich <jbeulich@suse.com>
Acked-by: Ian Campbell <ian.campbell@citrix.com>
> ---
> xen/drivers/char/ns16550.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/xen/drivers/char/ns16550.c b/xen/drivers/char/ns16550.c
> index 5892eb7..9c2cded 100644
> --- a/xen/drivers/char/ns16550.c
> +++ b/xen/drivers/char/ns16550.c
> @@ -503,7 +503,7 @@ static int __init check_existence(struct ns16550 *uart)
> {
> unsigned char status, scratch, scratch2, scratch3;
>
> -#ifdef HAS_IO_PORTS
> +#ifdef HAS_IOPORTS
> /*
> * We can't poke MMIO UARTs until they get I/O remapped later. Assume that
> * if we're getting MMIO UARTs, the arch code knows what it's doing.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-09-24 9:29 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-09-23 17:25 [PATCH] ns16550: Use correct #define symbol for HAS_IOPORTS Andrew Cooper
2013-09-24 9:29 ` Ian Campbell
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).