From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Cooper Subject: [PATCH 1/4] xen/irq: irq_to_desc() can't return NULL Date: Tue, 24 Sep 2013 13:10:35 +0100 Message-ID: <1380024638-14983-2-git-send-email-andrew.cooper3@citrix.com> References: <1380024638-14983-1-git-send-email-andrew.cooper3@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1380024638-14983-1-git-send-email-andrew.cooper3@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Xen-devel Cc: Andrew Cooper , Keir Fraser , Jan Beulich List-Id: xen-devel@lists.xenproject.org So NULL checks are logically dead code. Coverity IDs: 1055247, 1087147 Signed-off-by: Andrew Cooper CC: Keir Fraser CC: Jan Beulich --- xen/arch/x86/hvm/vmsi.c | 2 -- xen/arch/x86/irq.c | 2 -- 2 files changed, 4 deletions(-) diff --git a/xen/arch/x86/hvm/vmsi.c b/xen/arch/x86/hvm/vmsi.c index 4826b4a..b0766a4 100644 --- a/xen/arch/x86/hvm/vmsi.c +++ b/xen/arch/x86/hvm/vmsi.c @@ -304,8 +304,6 @@ static int msixtbl_write(struct vcpu *v, unsigned long address, goto out; desc = irq_to_desc(msi_desc->irq); - if ( !desc ) - goto out; spin_lock_irqsave(&desc->lock, flags); diff --git a/xen/arch/x86/irq.c b/xen/arch/x86/irq.c index c61cc46..e6036ec 100644 --- a/xen/arch/x86/irq.c +++ b/xen/arch/x86/irq.c @@ -646,8 +646,6 @@ void irq_move_cleanup_interrupt(struct cpu_user_regs *regs) continue; desc = irq_to_desc(irq); - if (!desc) - continue; spin_lock(&desc->lock); if (!desc->arch.move_cleanup_count) -- 1.7.10.4