From: Ian Campbell <ian.campbell@citrix.com>
To: xen-devel@lists.xen.org
Cc: julien.grall@linaro.org, tim@xen.org,
Ian Campbell <ian.campbell@citrix.com>,
andre.przywara@linaro.org, stefano.stabellini@eu.citrix.com
Subject: [PATCH v3 4/9] xen/arm: do not relocate Xen outside of visible RAM
Date: Thu, 26 Sep 2013 12:35:37 +0100 [thread overview]
Message-ID: <1380195342-23931-4-git-send-email-ian.campbell@citrix.com> (raw)
In-Reply-To: <1380195308.29483.78.camel@kazak.uk.xensource.com>
Since we do not handle non-contiguous banks of memory lets avoid relocating
Xen into such a bank. Avoids issues such as free_init_memory releasing pages
which are outside of the frametable.
Signed-off-by: Ian Campbell <ian.campbell@citrix.com>
---
xen/arch/arm/setup.c | 10 +++++++++-
1 file changed, 9 insertions(+), 1 deletion(-)
diff --git a/xen/arch/arm/setup.c b/xen/arch/arm/setup.c
index d8556bb..56333e7 100644
--- a/xen/arch/arm/setup.c
+++ b/xen/arch/arm/setup.c
@@ -240,17 +240,25 @@ static paddr_t __init get_xen_paddr(void)
{
struct dt_mem_info *mi = &early_info.mem;
paddr_t min_size;
- paddr_t paddr = 0;
+ paddr_t paddr = 0, last_end;
int i;
min_size = (_end - _start + (XEN_PADDR_ALIGN-1)) & ~(XEN_PADDR_ALIGN-1);
+ last_end = mi->bank[0].start;
+
/* Find the highest bank with enough space. */
for ( i = 0; i < mi->nr_banks; i++ )
{
const struct membank *bank = &mi->bank[i];
paddr_t s, e;
+ /* We can only deal with contiguous memory at the moment */
+ if ( last_end != bank->start )
+ break;
+
+ last_end = bank->start + bank->size;
+
if ( bank->size >= min_size )
{
e = consider_modules(bank->start, bank->start + bank->size,
--
1.7.10.4
next prev parent reply other threads:[~2013-09-26 11:35 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-26 11:35 [PATCH v3 0/9] xen: arm: memory mangement fixes / improvements Ian Campbell
2013-09-26 11:35 ` [PATCH v3 1/9] xen/arm: ensure the xenheap is 32MB aligned Ian Campbell
2013-09-26 11:35 ` [PATCH v3 2/9] xen/arm: DOMHEAP_SECOND_PAGES is arm32 specific Ian Campbell
2013-09-26 11:35 ` [PATCH v3 3/9] xen/arm: Reserve FDT via early module mechanism Ian Campbell
2013-09-26 11:35 ` Ian Campbell [this message]
2013-09-26 11:35 ` [PATCH v3 5/9] xen/arm: cope with modules outside of "visible" RAM Ian Campbell
2013-09-26 11:35 ` [PATCH v3 6/9] xen/arm: Support dtb /memreserve/ regions Ian Campbell
2013-09-26 11:35 ` [PATCH v3 7/9] xen/arm: rename boot misc region to boot reloc now it has a single purpose Ian Campbell
2013-09-26 11:35 ` [PATCH v3 8/9] xen/arm: print the location of the Xen heap on 32 bit Ian Campbell
2013-09-26 11:35 ` [PATCH v3 9/9] xen: support RAM at addresses 0 and 4096 Ian Campbell
2013-09-26 14:47 ` [PATCH v3 0/9] xen: arm: memory mangement fixes / improvements Tim Deegan
2013-09-26 16:40 ` Ian Campbell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1380195342-23931-4-git-send-email-ian.campbell@citrix.com \
--to=ian.campbell@citrix.com \
--cc=andre.przywara@linaro.org \
--cc=julien.grall@linaro.org \
--cc=stefano.stabellini@eu.citrix.com \
--cc=tim@xen.org \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).