From: Ian Campbell <ian.campbell@citrix.com>
To: xen-devel@lists.xen.org
Cc: julien.grall@linaro.org, tim@xen.org,
Ian Campbell <ian.campbell@citrix.com>,
anup.patel@linaro.org, stefano.stabellini@eu.citrix.com
Subject: [PATCH 5/5] xen: arm: correctly round down MFN to 1GB boundary make sure pagetable mask macros as physaddr size
Date: Mon, 7 Oct 2013 12:38:16 +0100 [thread overview]
Message-ID: <1381145896-25890-5-git-send-email-ian.campbell@citrix.com> (raw)
In-Reply-To: <1381145870.21562.93.camel@kazak.uk.xensource.com>
~FIRST_MASK is nothing like correct for rounding down an MFN. It is the
inverse *and* an address not a framenumber so wrong in every dimension! We
cannot use FIRST_MASK since that would mask off any zeroeth level bits.
Instead calculate the correct value from FIRST_SIZE.
Signed-off-by: Ian Campbell <ian.campbell@citrix.com>
---
xen/arch/arm/mm.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/xen/arch/arm/mm.c b/xen/arch/arm/mm.c
index e48d473..887930a 100644
--- a/xen/arch/arm/mm.c
+++ b/xen/arch/arm/mm.c
@@ -656,7 +656,7 @@ void __init setup_xenheap_mappings(unsigned long base_mfn,
end_mfn = base_mfn + nr_mfns;
/* Align to previous 1GB boundary */
- base_mfn &= ~FIRST_MASK;
+ base_mfn &= ~((FIRST_SIZE>>PAGE_SHIFT)-1);
offset = base_mfn - xenheap_mfn_start;
vaddr = DIRECTMAP_VIRT_START + offset*PAGE_SIZE;
--
1.7.10.4
next prev parent reply other threads:[~2013-10-07 11:38 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-07 11:37 [PATCH 0/5] xen: arm: fixups for systems with RAM above 4GB Ian Campbell
2013-10-07 11:38 ` [PATCH 1/5] xen: correct xenheap_bits after "xen: support RAM at addresses 0 and 4096" Ian Campbell
2013-10-07 11:38 ` [PATCH 2/5] xen: arm: Enable 40 bit addressing in VTCR for arm64 Ian Campbell
2013-10-21 15:23 ` Julien Grall
2013-10-07 11:38 ` [PATCH 3/5] xen: arm: map entire memory banks on arm64 Ian Campbell
2013-10-07 11:38 ` [PATCH 4/5] xen: arm: make sure pagetable mask macros have appropriate size Ian Campbell
2013-10-21 15:29 ` Julien Grall
2013-10-21 15:53 ` Julien Grall
2013-10-22 10:18 ` Ian Campbell
2013-10-07 11:38 ` Ian Campbell [this message]
2013-10-07 11:43 ` [PATCH 0/5] xen: arm: fixups for systems with RAM above 4GB Ian Campbell
2013-10-10 8:40 ` Ian Campbell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1381145896-25890-5-git-send-email-ian.campbell@citrix.com \
--to=ian.campbell@citrix.com \
--cc=anup.patel@linaro.org \
--cc=julien.grall@linaro.org \
--cc=stefano.stabellini@eu.citrix.com \
--cc=tim@xen.org \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).