* [PATCH] xen/arm32: Call start_xen only on the boot CPU
@ 2013-10-07 14:44 Julien Grall
2013-10-10 10:41 ` Ian Campbell
0 siblings, 1 reply; 2+ messages in thread
From: Julien Grall @ 2013-10-07 14:44 UTC (permalink / raw)
To: xen-devel; +Cc: patches, tim, ian.campbell, Julien Grall, stefano.stabellini
The boot CPU can have a CPU ID non-equal to zero. Xen needs to check the
logical CPU ID (in r12) to know if the CPU is the boot one.
Signed-off-by: Julien Grall <julien.grall@linaro.org>
---
xen/arch/arm/arm32/head.S | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/xen/arch/arm/arm32/head.S b/xen/arch/arm/arm32/head.S
index 92b3c48..ce1d21a 100644
--- a/xen/arch/arm/arm32/head.S
+++ b/xen/arch/arm/arm32/head.S
@@ -403,7 +403,8 @@ launch:
sub sp, #CPUINFO_sizeof /* Make room for CPU save record */
mov r0, r10 /* Marshal args: - phys_offset */
mov r1, r8 /* - DTB address */
- movs r2, r7 /* - CPU ID */
+ mov r2, r7 /* - CPU ID */
+ teq r12, #0
beq start_xen /* and disappear into the land of C */
b start_secondary /* (to the appropriate entry point) */
--
1.7.10.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] xen/arm32: Call start_xen only on the boot CPU
2013-10-07 14:44 [PATCH] xen/arm32: Call start_xen only on the boot CPU Julien Grall
@ 2013-10-10 10:41 ` Ian Campbell
0 siblings, 0 replies; 2+ messages in thread
From: Ian Campbell @ 2013-10-10 10:41 UTC (permalink / raw)
To: Julien Grall; +Cc: stefano.stabellini, tim, patches, xen-devel
On Mon, 2013-10-07 at 15:44 +0100, Julien Grall wrote:
> The boot CPU can have a CPU ID non-equal to zero. Xen needs to check the
> logical CPU ID (in r12) to know if the CPU is the boot one.
>
> Signed-off-by: Julien Grall <julien.grall@linaro.org>
acked + applied, thanks.
64-bit looks correct already to me.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-10-10 10:41 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-10-07 14:44 [PATCH] xen/arm32: Call start_xen only on the boot CPU Julien Grall
2013-10-10 10:41 ` Ian Campbell
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).