From: Ian Campbell <ian.campbell@citrix.com>
To: xen-devel@lists.xen.org
Cc: julien.grall@linaro.org, tim@xen.org,
Ian Campbell <ian.campbell@citrix.com>,
stefano.stabellini@eu.citrix.com
Subject: [PATCH RFC 05/15] xen: arm: implement XEN_DOMCTL_set_address_size
Date: Mon, 7 Oct 2013 17:39:51 +0100 [thread overview]
Message-ID: <1381164001-1446-5-git-send-email-ian.campbell@citrix.com> (raw)
In-Reply-To: <1381163944.21562.129.camel@kazak.uk.xensource.com>
This subarch specific to plumb through to arm32 and arm64 versions.
The toolstack uses this to select 32- vs 64-bit guests (or rather it does on
x86 an soon will for arm too).
I noticed that domctl.c and sysctl.c weren't including xen/hypercall.h to get
their arch_do_fooctl prototypes, so fix that.
Signed-off-by: Ian Campbell <ian.campbell@citrix.com>
---
xen/arch/arm/arm32/Makefile | 1 +
xen/arch/arm/arm32/domctl.c | 35 +++++++++++++++++++++++
xen/arch/arm/arm64/Makefile | 1 +
xen/arch/arm/arm64/domctl.c | 59 +++++++++++++++++++++++++++++++++++++++
xen/arch/arm/domctl.c | 7 ++++-
xen/arch/arm/sysctl.c | 1 +
xen/include/asm-arm/hypercall.h | 3 ++
7 files changed, 106 insertions(+), 1 deletion(-)
create mode 100644 xen/arch/arm/arm32/domctl.c
create mode 100644 xen/arch/arm/arm64/domctl.c
diff --git a/xen/arch/arm/arm32/Makefile b/xen/arch/arm/arm32/Makefile
index aacdcb9..65ecff4 100644
--- a/xen/arch/arm/arm32/Makefile
+++ b/xen/arch/arm/arm32/Makefile
@@ -7,5 +7,6 @@ obj-y += traps.o
obj-y += domain.o
obj-y += vfp.o
obj-y += smpboot.o
+obj-y += domctl.o
obj-$(EARLY_PRINTK) += debug.o
diff --git a/xen/arch/arm/arm32/domctl.c b/xen/arch/arm/arm32/domctl.c
new file mode 100644
index 0000000..c2ca4d3
--- /dev/null
+++ b/xen/arch/arm/arm32/domctl.c
@@ -0,0 +1,35 @@
+/******************************************************************************
+ * Subarch-specific domctl.c
+ *
+ * Copyright (c) 2013, Citrix Systems
+ */
+
+#include <xen/config.h>
+#include <xen/types.h>
+#include <xen/lib.h>
+#include <xen/errno.h>
+#include <xen/sched.h>
+#include <xen/hypercall.h>
+#include <public/domctl.h>
+
+long subarch_do_domctl(struct xen_domctl *domctl, struct domain *d,
+ XEN_GUEST_HANDLE_PARAM(xen_domctl_t) u_domctl)
+{
+ switch ( domctl->cmd )
+ {
+ case XEN_DOMCTL_set_address_size:
+ return domctl->u.address_size.size == 32 ? 0 : -EINVAL;
+ default:
+ return -ENOSYS;
+ }
+}
+
+/*
+ * Local variables:
+ * mode: C
+ * c-file-style: "BSD"
+ * c-basic-offset: 4
+ * tab-width: 4
+ * indent-tabs-mode: nil
+ * End:
+ */
diff --git a/xen/arch/arm/arm64/Makefile b/xen/arch/arm/arm64/Makefile
index 5d28bad..d2d5875 100644
--- a/xen/arch/arm/arm64/Makefile
+++ b/xen/arch/arm/arm64/Makefile
@@ -6,5 +6,6 @@ obj-y += traps.o
obj-y += domain.o
obj-y += vfp.o
obj-y += smpboot.o
+obj-y += domctl.o
obj-$(EARLY_PRINTK) += debug.o
diff --git a/xen/arch/arm/arm64/domctl.c b/xen/arch/arm/arm64/domctl.c
new file mode 100644
index 0000000..e2b4617
--- /dev/null
+++ b/xen/arch/arm/arm64/domctl.c
@@ -0,0 +1,59 @@
+/******************************************************************************
+ * Subarch-specific domctl.c
+ *
+ * Copyright (c) 2013, Citrix Systems
+ */
+
+#include <xen/config.h>
+#include <xen/types.h>
+#include <xen/lib.h>
+#include <xen/errno.h>
+#include <xen/sched.h>
+#include <xen/hypercall.h>
+#include <public/domctl.h>
+
+static long switch_mode(struct domain *d, enum domain_type type)
+{
+ if ( d == NULL )
+ return -EINVAL;
+ if ( d->tot_pages != 0 )
+ return -EBUSY;
+ if ( d->arch.type == type )
+ return 0;
+
+ d->arch.type = type;
+
+ return 0;
+}
+
+long subarch_do_domctl(struct xen_domctl *domctl, struct domain *d,
+ XEN_GUEST_HANDLE_PARAM(xen_domctl_t) u_domctl)
+{
+ switch ( domctl->cmd )
+ {
+ case XEN_DOMCTL_set_address_size:
+ switch ( domctl->u.address_size.size )
+ {
+ case 32:
+ return switch_mode(d, DOMAIN_PV32);
+ case 64:
+ return switch_mode(d, DOMAIN_PV64);
+ default:
+ return -EINVAL;
+ }
+ break;
+
+ default:
+ return -ENOSYS;
+ }
+}
+
+/*
+ * Local variables:
+ * mode: C
+ * c-file-style: "BSD"
+ * c-basic-offset: 4
+ * tab-width: 4
+ * indent-tabs-mode: nil
+ * End:
+ */
diff --git a/xen/arch/arm/domctl.c b/xen/arch/arm/domctl.c
index 851ee40..546e86b 100644
--- a/xen/arch/arm/domctl.c
+++ b/xen/arch/arm/domctl.c
@@ -9,12 +9,17 @@
#include <xen/lib.h>
#include <xen/errno.h>
#include <xen/sched.h>
+#include <xen/hypercall.h>
#include <public/domctl.h>
long arch_do_domctl(struct xen_domctl *domctl, struct domain *d,
XEN_GUEST_HANDLE_PARAM(xen_domctl_t) u_domctl)
{
- return -ENOSYS;
+ switch ( domctl->cmd )
+ {
+ default:
+ return subarch_do_domctl(domctl, d, u_domctl);
+ }
}
void arch_get_info_guest(struct vcpu *v, vcpu_guest_context_u c)
diff --git a/xen/arch/arm/sysctl.c b/xen/arch/arm/sysctl.c
index 6388204..98bab6a 100644
--- a/xen/arch/arm/sysctl.c
+++ b/xen/arch/arm/sysctl.c
@@ -10,6 +10,7 @@
#include <xen/types.h>
#include <xen/lib.h>
#include <xen/errno.h>
+#include <xen/hypercall.h>
#include <public/sysctl.h>
void arch_do_physinfo(xen_sysctl_physinfo_t *pi) { }
diff --git a/xen/include/asm-arm/hypercall.h b/xen/include/asm-arm/hypercall.h
index 3327a96..94a92d4 100644
--- a/xen/include/asm-arm/hypercall.h
+++ b/xen/include/asm-arm/hypercall.h
@@ -6,6 +6,9 @@ int do_physdev_op(int cmd, XEN_GUEST_HANDLE_PARAM(void) arg);
long do_arm_vcpu_op(int cmd, int vcpuid, XEN_GUEST_HANDLE_PARAM(void) arg);
+long subarch_do_domctl(struct xen_domctl *domctl, struct domain *d,
+ XEN_GUEST_HANDLE_PARAM(xen_domctl_t) u_domctl);
+
#endif /* __ASM_ARM_HYPERCALL_H__ */
/*
* Local variables:
--
1.7.10.4
next prev parent reply other threads:[~2013-10-07 16:39 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-07 16:39 [PATCH RFC 00/15] xen: arm: 64-bit guest support and domU FDT autogeneration Ian Campbell
2013-10-07 16:39 ` [PATCH RFC 01/15] xen: arm: Report aarch64 capability Ian Campbell
2013-10-10 14:25 ` Julien Grall
2013-10-07 16:39 ` [PATCH RFC 02/15] xen: arm: Add comment regard arm64 zImage v0 vs v1 Ian Campbell
2013-10-10 14:26 ` Julien Grall
2013-10-07 16:39 ` [PATCH RFC 03/15] xen: arm: allocate dom0 memory separately from preparing the dtb Ian Campbell
2013-10-10 14:38 ` Julien Grall
2013-10-24 17:06 ` Ian Campbell
2013-10-07 16:39 ` [PATCH RFC 04/15] xen: arm: add enable-method to cpu nodes for arm64 guests Ian Campbell
2013-10-10 14:40 ` Julien Grall
2013-10-07 16:39 ` Ian Campbell [this message]
2013-10-07 16:39 ` [PATCH RFC 06/15] xen: arm: implement arch_set_info_guest for 64-bit vcpus Ian Campbell
2013-10-07 16:39 ` [PATCH RFC 07/15] xenctx: fix typo in arm64 output Ian Campbell
2013-10-10 14:43 ` Julien Grall
2013-10-24 21:47 ` Ian Campbell
2013-10-07 16:39 ` [PATCH RFC 08/15] tools: check for libfdt when building for ARM Ian Campbell
2013-10-07 16:39 ` [PATCH RFC 09/15] libxc: arm: rename various bits of zimage load with 32 suffix Ian Campbell
2013-10-10 15:27 ` Julien Grall
2013-10-07 16:39 ` [PATCH RFC 10/15] libxc: allow caller to specify guest rambase rather than hardcoding Ian Campbell
2013-10-10 15:31 ` Julien Grall
2013-10-10 15:34 ` Ian Campbell
2013-10-07 16:39 ` [PATCH RFC 11/15] libxc: allow passing a device tree blob to the guest Ian Campbell
2013-10-07 16:39 ` [PATCH RFC 12/15] libxc: support for arm64 Image format Ian Campbell
2013-10-10 15:43 ` Julien Grall
2013-10-10 15:56 ` Ian Campbell
2013-10-21 9:46 ` Ian Campbell
2013-10-21 15:11 ` Julien Grall
2013-10-07 16:39 ` [PATCH RFC 13/15] libxc: arm64 vcpu initialisation Ian Campbell
2013-10-10 15:54 ` Julien Grall
2013-10-10 15:59 ` Ian Campbell
2013-10-10 16:04 ` Julien Grall
2013-10-10 16:09 ` Ian Campbell
2013-10-14 22:36 ` Julien Grall
2013-10-07 16:40 ` [PATCH RFC 14/15] libxl: build a device tree for ARM guests Ian Campbell
2013-10-14 23:11 ` Julien Grall
2013-10-15 10:00 ` Ian Campbell
2013-10-15 13:23 ` Julien Grall
2013-10-15 13:33 ` Ian Campbell
2013-10-15 13:49 ` Julien Grall
2013-10-15 13:52 ` Ian Campbell
2013-10-15 13:46 ` Julien Grall
2013-10-07 16:40 ` [PATCH RFC 15/15] libxl: remove spurious newline from LOG() message Ian Campbell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1381164001-1446-5-git-send-email-ian.campbell@citrix.com \
--to=ian.campbell@citrix.com \
--cc=julien.grall@linaro.org \
--cc=stefano.stabellini@eu.citrix.com \
--cc=tim@xen.org \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).